Merge branch 'config_snapshots' into updating

xs/src/slic3r/Config/Snapshot.cpp

@@ -133,6 +133,21 @@ void Snapshot::load_ini(const std::string &path)
     }
 }
 
+static std::string reason_string(const Snapshot::Reason reason) 
+{
+    switch (reason) {
+    case Snapshot::SNAPSHOT_UPGRADE:
+        return "upgrade";
+    case Snapshot::SNAPSHOT_DOWNGRADE:
+        return "downgrade";
+    case Snapshot::SNAPSHOT_USER:
+        return "user";
+    case Snapshot::SNAPSHOT_UNKNOWN:
+    default:
+        return "unknown";
+    }
+}
+
 void Snapshot::save_ini(const std::string &path)
 {
 	boost::nowide::ofstream c;
@@ -145,7 +160,7 @@ void Snapshot::save_ini(const std::string &path)
 	c << "time_captured = " << Slic3r::Utils::format_time_ISO8601Z(this->time_captured) << std::endl;
 	c << "slic3r_version_captured = " << this->slic3r_version_captured.to_string() << std::endl;
 	c << "comment = " << this->comment << std::endl;
-	c << "reason = " << this->reason << std::endl;
+	c << "reason = " << reason_string(this->reason) << std::endl;
 
     // Export the active presets at the time of the snapshot.
 	c << std::endl << "[presets]" << std::endl;
@@ -294,6 +309,11 @@ const Snapshot&	SnapshotDB::take_snapshot(const AppConfig &app_config, Snapshot:
         Snapshot::VendorConfig cfg;
         cfg.name = vendor.first;
         cfg.models_variants_installed = vendor.second;
+        for (auto it = cfg.models_variants_installed.begin(); it != cfg.models_variants_installed.end();)
+            if (it->second.empty())
+                cfg.models_variants_installed.erase(it ++);
+            else
+                ++ it;
         // Read the active config bundle, parse the config version.
         PresetBundle bundle;
         bundle.load_configbundle((data_dir / "vendor" / (cfg.name + ".ini")).string(), PresetBundle::LOAD_CFGBUNDLE_VENDOR_ONLY);

xs/src/slic3r/Config/Snapshot.hpp

@@ -57,6 +57,8 @@ public:
 	std::string 				comment;
 	Reason						reason;
 
+	std::string 				format_reason() const;
+
 	// Active presets at the time of the snapshot.
 	std::string 				print;
 	std::vector<std::string>	filaments;

xs/src/slic3r/Config/Version.cpp

@@ -15,11 +15,131 @@ namespace Config {
 
 static boost::optional<Semver> s_current_slic3r_semver = Semver::parse(SLIC3R_VERSION);
 
+// Optimized lexicographic compare of two pre-release versions, ignoring the numeric suffix.
+static int compare_prerelease(const char *p1, const char *p2)
+{
+	for (;;) {
+		char c1 = *p1 ++;
+		char c2 = *p2 ++;
+		bool a1 = std::isalpha(c1) && c1 != 0;
+		bool a2 = std::isalpha(c2) && c2 != 0;
+		if (a1) {
+			if (a2) {
+				if (c1 != c2)
+					return (c1 < c2) ? -1 : 1;
+			} else
+				return 1;
+		} else {
+			if (a2)
+				return -1;
+			else
+				return 0;
+		}
+	}
+	// This shall never happen.
+	return 0;
+}
+
+bool Version::is_slic3r_supported(const Semver &slic3r_version) const
+{ 
+	if (! slic3r_version.in_range(min_slic3r_version, max_slic3r_version))
+		return false;
+	// Now verify, whether the configuration pre-release status is compatible with the Slic3r's pre-release status.
+	// Alpha Slic3r will happily load any configuration, while beta Slic3r will ignore alpha configurations etc.
+	const char *prerelease_slic3r = slic3r_version.prerelease();
+	const char *prerelease_config = this->config_version.prerelease();
+	if (prerelease_config == nullptr)
+		// Released config is always supported.
+		return true;
+	else if (prerelease_slic3r == nullptr)
+		// Released slic3r only supports released configs.
+		return false;
+	// Compare the pre-release status of Slic3r against the config.
+	// If the prerelease status of slic3r is lexicographically lower or equal 
+	// to the prerelease status of the config, accept it.
+	return compare_prerelease(prerelease_slic3r, prerelease_config) != 1;
+}
+
 bool Version::is_current_slic3r_supported() const
 {
 	return this->is_slic3r_supported(*s_current_slic3r_semver);
 }
 
+#if 0
+//TODO: This test should be moved to a unit test, once we have C++ unit tests in place.
+static int version_test()
+{
+	Version v;
+	v.config_version 	 = *Semver::parse("1.1.2");
+	v.min_slic3r_version = *Semver::parse("1.38.0");
+	v.max_slic3r_version = Semver::inf();
+	assert(v.is_slic3r_supported(*Semver::parse("1.38.0")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.38.0-alpha")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.37.0-alpha")));
+	// Test the prerelease status.
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-rc2")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0")));
+	v.config_version 	 = *Semver::parse("1.1.2-alpha");
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha1")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0-beta")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0-rc2")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0")));
+	v.config_version 	 = *Semver::parse("1.1.2-alpha1");
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha1")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0-beta")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0-rc2")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0")));
+	v.config_version 	 = *Semver::parse("1.1.2-beta");
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0-rc")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0-rc2")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0")));
+	v.config_version 	 = *Semver::parse("1.1.2-rc");
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-rc")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-rc2")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0")));
+	v.config_version 	 = *Semver::parse("1.1.2-rc2");
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-alpha1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-beta1")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-rc")));
+	assert(v.is_slic3r_supported(*Semver::parse("1.39.0-rc2")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.39.0")));
+	// Test the upper boundary.
+	v.config_version 	 = *Semver::parse("1.1.2");
+	v.max_slic3r_version = *Semver::parse("1.39.3-beta1");
+	assert(v.is_slic3r_supported(*Semver::parse("1.38.0")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.38.0-alpha")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.38.0-alpha1")));
+	assert(! v.is_slic3r_supported(*Semver::parse("1.37.0-alpha")));
+	return 0;
+}
+static int version_test_run = version_test();
+#endif
+
 inline char* left_trim(char *c)
 {
 	for (; *c == ' ' || *c == '\t'; ++ c);
@@ -141,6 +261,15 @@ size_t Index::load(const boost::filesystem::path &path)
     return m_configs.size();
 }
 
+Semver Index::version() const
+{
+    Semver ver = Semver::zero();
+    for (const Version &cv : m_configs)
+        if (cv.config_version >= ver)
+            ver = cv.config_version;
+    return ver;
+}
+
 Index::const_iterator Index::find(const Semver &ver) const
 { 
 	Version key;

xs/src/slic3r/Config/Version.hpp

@@ -27,7 +27,7 @@ struct Version
 	// Single comment line.
 	std::string comment;
 
-	bool 		is_slic3r_supported(const Semver &slicer_version) const { return slicer_version.in_range(min_slic3r_version, max_slic3r_version); }
+	bool 		is_slic3r_supported(const Semver &slicer_version) const;
 	bool 		is_current_slic3r_supported() const;
 };
 
@@ -59,6 +59,9 @@ public:
 	size_t						load(const boost::filesystem::path &path);
 
 	const std::string&			vendor() const { return m_vendor; }
+	// Returns version of the index as the highest version of all the configs.
+	// If there is no config, Semver::zero() is returned.
+	Semver						version() const;
 
 	const_iterator				begin()   const { return m_configs.begin(); }
 	const_iterator				end()     const { return m_configs.end(); }