3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2025-07-13 09:47:58 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fixed regression causing retraction to be skipped when Retract Length was 0 but Use Firmware Retraction was enabled. Includes regression test. #2359

Browse source
This commit is contained in:
Alessandro Ranellucci 2014-11-23 19:28:18 +01:00
parent a1193d28bc
commit 60a76b8cfa
3 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
xs/src/libslic3r/GCodeWriter.cpp
View file

@ -417,6 +417,12 @@ std::string
GCodeWriter::_retract(double length, double restart_extra, const std::string &comment)
{
std::ostringstream gcode;
/* If firmware retraction is enabled, we use a fake value of 1
since we ignore the actual configured retract_length which
might be 0, in which case the retraction logic gets skipped. */
if (this->config.use_firmware_retraction) length = 1;
double dE = this->_extruder->retract(length, restart_extra);
if (dE != 0) {
if (this->config.use_firmware_retraction) {