Several minor improvements and fixed warnings

This commit is contained in:
Lukas Matena 2021-10-01 14:31:22 +02:00
parent 1edbdcfecf
commit 4ca2401b69
5 changed files with 8 additions and 7 deletions

View file

@ -1922,7 +1922,7 @@ namespace Slic3r {
{
int min_id = its.indices.front()[0];
int max_id = min_id;
for (const Vec3i face : its.indices) {
for (const Vec3i& face : its.indices) {
for (const int tri_id : face) {
if (tri_id < 0 || tri_id >= int(geometry.vertices.size())) {
add_error("Found invalid vertex id");

View file

@ -626,7 +626,7 @@ void AMFParserContext::endElement(const char * /* name */)
// Verify validity of face indices, find the vertex span.
int min_id = m_volume_facets.front()[0];
int max_id = min_id;
for (const Vec3i face : m_volume_facets) {
for (const Vec3i& face : m_volume_facets) {
for (const int tri_id : face) {
if (tri_id < 0 || tri_id >= int(m_object_vertices.size())) {
this->stop("Malformed triangle mesh");