From 46af00aa017365709b0a8a482638c8faf14b27d9 Mon Sep 17 00:00:00 2001 From: discip <53649486+discip@users.noreply.github.com> Date: Fri, 18 Jul 2025 08:06:48 +0200 Subject: [PATCH] hide `Reverse threshold` when not editable (#10161) * make **`Reverse threshold`** inactive when **`Reverse only internal perimeters`** is activated * Update ConfigManipulation.cpp * 100%% => 100% Also fixed a typo along the way. --- localization/i18n/OrcaSlicer.pot | 2 +- src/slic3r/GUI/ConfigManipulation.cpp | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/localization/i18n/OrcaSlicer.pot b/localization/i18n/OrcaSlicer.pot index cb5c116d47..5d8e75c2cb 100644 --- a/localization/i18n/OrcaSlicer.pot +++ b/localization/i18n/OrcaSlicer.pot @@ -11727,7 +11727,7 @@ msgstr "" #, possible-c-format, possible-boost-format msgid "" "Detect the overhang percentage relative to line width and use different " -"speed to print. For 100%% overhang, bridge speed is used." +"speed to print. For 100% overhang, bridge speed is used." msgstr "" msgid "Filament to print walls" diff --git a/src/slic3r/GUI/ConfigManipulation.cpp b/src/slic3r/GUI/ConfigManipulation.cpp index f57aa5f812..9818260b00 100644 --- a/src/slic3r/GUI/ConfigManipulation.cpp +++ b/src/slic3r/GUI/ConfigManipulation.cpp @@ -824,9 +824,7 @@ void ConfigManipulation::toggle_print_fff_options(DynamicPrintConfig *config, co bool has_overhang_reverse = config->opt_bool("overhang_reverse"); bool force_wall_direction = config->opt_enum("wall_direction") != WallDirection::Auto; bool allow_overhang_reverse = !has_spiral_vase && !force_wall_direction; - toggle_field("overhang_reverse", allow_overhang_reverse); - toggle_field("overhang_reverse_threshold", has_detect_overhang_wall); - toggle_line("overhang_reverse_threshold", allow_overhang_reverse && has_overhang_reverse); + toggle_line("overhang_reverse", allow_overhang_reverse); toggle_line("overhang_reverse_internal_only", allow_overhang_reverse && has_overhang_reverse); bool has_overhang_reverse_internal_only = config->opt_bool("overhang_reverse_internal_only"); if (has_overhang_reverse_internal_only){ @@ -834,6 +832,7 @@ void ConfigManipulation::toggle_print_fff_options(DynamicPrintConfig *config, co new_conf.set_key_value("overhang_reverse_threshold", new ConfigOptionFloatOrPercent(0,true)); apply(config, &new_conf); } + toggle_line("overhang_reverse_threshold", has_detect_overhang_wall && allow_overhang_reverse && has_overhang_reverse && !has_overhang_reverse_internal_only); toggle_line("timelapse_type", is_BBL_Printer);