3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2025-07-07 06:57:36 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix issue that sharp tails are supported regardless of support blockers (#8743)

Browse source 
when using normal support (SoftFever/OrcaSlicer#8737)

Co-authored-by: SoftFever <softfeverever@gmail.com>
This commit is contained in:
Noisyfox 2025-03-08 11:03:40 +08:00 • committed by GitHub
parent 69bab18a8e
commit 464b89c3a7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 17 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/libslic3r/Support/SupportMaterial.cpp
View file

@ -1331,6 +1331,15 @@ struct SupportAnnotations
// Append custom supports. // Append custom supports.
object.project_and_append_custom_facets(false, EnforcerBlockerType::ENFORCER, enforcers_layers); object.project_and_append_custom_facets(false, EnforcerBlockerType::ENFORCER, enforcers_layers);
object.project_and_append_custom_facets(false, EnforcerBlockerType::BLOCKER, blockers_layers); object.project_and_append_custom_facets(false, EnforcerBlockerType::BLOCKER, blockers_layers);
// Expand the blocker a bit. Custom blockers produce strips
// spanning just the projection between the two slices.
// Subtracting them as they are may leave unwanted narrow
// residues of diff_polygons that would then be supported.
for (auto& blocker : blockers_layers) {
if (!blocker.empty())
blocker = expand(union_(blocker), float(1000. * SCALED_EPSILON));
}
} }
std::vector<Polygons> enforcers_layers; std::vector<Polygons> enforcers_layers;
@ -1490,11 +1499,7 @@ static inline ExPolygons detect_overhangs(
// Apply the "support blockers". // Apply the "support blockers".
if (!annotations.blockers_layers.empty() && !annotations.blockers_layers[layer_id].empty()) { if (!annotations.blockers_layers.empty() && !annotations.blockers_layers[layer_id].empty()) {
// Expand the blocker a bit. Custom blockers produce strips const auto& blocker = annotations.blockers_layers[layer_id];
// spanning just the projection between the two slices.
// Subtracting them as they are may leave unwanted narrow
// residues of diff_polygons that would then be supported.
auto blocker = expand(union_(annotations.blockers_layers[layer_id]), float(1000. * SCALED_EPSILON));
diff_polygons = diff(diff_polygons, blocker); diff_polygons = diff(diff_polygons, blocker);
layer.sharp_tails = diff_ex(layer.sharp_tails, blocker); layer.sharp_tails = diff_ex(layer.sharp_tails, blocker);
} }
@ -2217,6 +2222,13 @@ SupportGeneratorLayersPtr PrintObjectSupportMaterial::top_contact_layers(
ExPolygons overhang = diff_ex({ expoly }, lower_layer->lslices); ExPolygons overhang = diff_ex({ expoly }, lower_layer->lslices);
layer->sharp_tails.push_back(expoly); layer->sharp_tails.push_back(expoly);
layer->sharp_tails_height.push_back( accum_height ); layer->sharp_tails_height.push_back( accum_height );
// Apply the "support blockers".
if (!annotations.blockers_layers.empty() && !annotations.blockers_layers[layer_nr].empty()) {
const auto& blocker = annotations.blockers_layers[layer_nr];
overhang = diff_ex(overhang, blocker);
}
append(overhangs_per_layers[layer_nr], overhang); append(overhangs_per_layers[layer_nr], overhang);
} }