From 36550f1fc52971bef28193206ed6c28c40486975 Mon Sep 17 00:00:00 2001 From: SoftFever Date: Sun, 8 Sep 2024 22:02:12 +0800 Subject: [PATCH] deprecate overhang_speed_classic option and enable slowdown_for_curled_perimeters by default --- src/libslic3r/PrintConfig.cpp | 8 ++++++-- src/slic3r/GUI/Tab.cpp | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/libslic3r/PrintConfig.cpp b/src/libslic3r/PrintConfig.cpp index 5c1b6d8043..cab6094d74 100644 --- a/src/libslic3r/PrintConfig.cpp +++ b/src/libslic3r/PrintConfig.cpp @@ -1040,6 +1040,7 @@ void PrintConfigDef::init_fff_params() def->mode = comAdvanced; def->set_default_value(new ConfigOptionFloatOrPercent(50, true)); + // Orca: deprecated def = this->add("overhang_speed_classic", coBool); def->label = L("Classic mode"); def->category = L("Speed"); @@ -1068,7 +1069,7 @@ void PrintConfigDef::init_fff_params() "applied even if the overhanging perimeter is part of a bridge. For example, when the perimeters are 100% overhanging" ", with no wall supporting them from underneath, the 100% overhang speed will be applied."); def->mode = comAdvanced; - def->set_default_value(new ConfigOptionBool{ false }); + def->set_default_value(new ConfigOptionBool{ true }); def = this->add("overhang_1_4_speed", coFloatOrPercent); def->label = "(10%, 25%)"; @@ -6203,6 +6204,8 @@ void PrintConfigDef::handle_legacy(t_config_option_key &opt_key, std::string &va } else if (opt_key == "draft_shield" && value == "limited") { value = "disabled"; + } else if (opt_key == "overhang_speed_classic") { + value = "0"; } // Ignore the following obsolete configuration keys: @@ -6220,7 +6223,8 @@ void PrintConfigDef::handle_legacy(t_config_option_key &opt_key, std::string &va "z_hop_type", "z_lift_type", "bed_temperature_difference","long_retraction_when_cut", "retraction_distance_when_cut", "extruder_type", - "internal_bridge_support_thickness","extruder_clearance_max_radius", "top_area_threshold", "reduce_wall_solid_infill","filament_load_time","filament_unload_time" + "internal_bridge_support_thickness","extruder_clearance_max_radius", "top_area_threshold", "reduce_wall_solid_infill","filament_load_time","filament_unload_time", + "smooth_coefficient", "overhang_totally_speed" }; if (ignore.find(opt_key) != ignore.end()) { diff --git a/src/slic3r/GUI/Tab.cpp b/src/slic3r/GUI/Tab.cpp index c719e51a24..9a28521bad 100644 --- a/src/slic3r/GUI/Tab.cpp +++ b/src/slic3r/GUI/Tab.cpp @@ -2164,7 +2164,8 @@ void TabPrint::build() optgroup->append_single_option_line("support_interface_speed"); optgroup = page->new_optgroup(L("Overhang speed"), L"param_overhang_speed", 15); optgroup->append_single_option_line("enable_overhang_speed", "slow-down-for-overhang"); - optgroup->append_single_option_line("overhang_speed_classic", "slow-down-for-overhang"); + // Orca: DEPRECATED + // optgroup->append_single_option_line("overhang_speed_classic", "slow-down-for-overhang"); optgroup->append_single_option_line("slowdown_for_curled_perimeters"); Line line = { L("Overhang speed"), L("This is the speed for various overhang degrees. Overhang degrees are expressed as a percentage of line width. 0 speed means no slowing down for the overhang degree range and wall speed is used") }; line.label_path = "slow-down-for-overhang";