Bugfix: crash when slicing one layer objects with sailfish G-code flavor. Includes regression test. #2335

This commit is contained in:
Alessandro Ranellucci 2014-11-06 21:06:09 +01:00
parent 11bd1e68e2
commit 30b0869595
4 changed files with 22 additions and 4 deletions

View file

@ -1,4 +1,4 @@
use Test::More tests => 11;
use Test::More tests => 16;
use strict;
use warnings;
@ -101,15 +101,22 @@ use Slic3r::Test;
my ($print, $comment) = @_;
my @percent = ();
my $got_100 = 0;
my $extruding_after_100 = 0;
Slic3r::GCode::Reader->new->parse(Slic3r::Test::gcode($print), sub {
my ($self, $cmd, $args, $info) = @_;
if ($cmd eq 'M73') {
push @percent, $args->{P};
$got_100 = 1 if $args->{P} eq '100';
}
if ($info->{extruding} && $got_100) {
$extruding_after_100 = 1;
}
});
# the extruder heater is turned off when M73 P100 is reached
ok !(defined first { $_ > 100 } @percent), "M73 is never given more than 100% ($comment)";
ok !$extruding_after_100, "no extrusions after M73 P100 ($comment)";
};
{
@ -133,6 +140,13 @@ use Slic3r::Test;
my $print = Slic3r::Test::init_print(['20mm_cube','20mm_cube'], config => $config);
$test->($print, 'two objects');
}
{
my $config = Slic3r::Config->new_from_defaults;
$config->set('gcode_flavor', 'sailfish');
my $print = Slic3r::Test::init_print('20mm_cube', config => $config, scale_xyz => [1,1, 1/(20/$config->layer_height) ]);
$test->($print, 'one layer object');
}
}
__END__