From f5a2d65492df4a6ba25e6ae333d206a0a57f5e46 Mon Sep 17 00:00:00 2001 From: Raoul Rubien Date: Sat, 13 Sep 2025 12:12:01 +0200 Subject: [PATCH 1/2] fixes: possibly dangling reference to a temporary [-Wdangling-reference] --- src/slic3r/GUI/Gizmos/GLGizmoPainterBase.cpp | 12 ++++++------ src/slic3r/GUI/Gizmos/GLGizmoPainterBase.hpp | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/slic3r/GUI/Gizmos/GLGizmoPainterBase.cpp b/src/slic3r/GUI/Gizmos/GLGizmoPainterBase.cpp index 319f3a57cf..6242ee9c18 100644 --- a/src/slic3r/GUI/Gizmos/GLGizmoPainterBase.cpp +++ b/src/slic3r/GUI/Gizmos/GLGizmoPainterBase.cpp @@ -1126,8 +1126,8 @@ TriangleSelector::ClippingPlane GLGizmoPainterBase::get_clipping_plane_in_volume return TriangleSelector::ClippingPlane({float(normal_transformed.x()), float(normal_transformed.y()), float(normal_transformed.z()), offset_transformed}); } -ColorRGBA TriangleSelectorGUI::enforcers_color = {0.5f, 1.f, 0.5f, 1.f}; -ColorRGBA TriangleSelectorGUI::blockers_color = {1.f, 0.5f, 0.5f, 1.f}; +const ColorRGBA TriangleSelectorGUI::enforcers_color = {0.5f, 1.f, 0.5f, 1.f}; +const ColorRGBA TriangleSelectorGUI::blockers_color = {1.f, 0.5f, 0.5f, 1.f}; ColorRGBA TriangleSelectorGUI::get_seed_fill_color(const ColorRGBA& base_color) { @@ -1151,10 +1151,10 @@ void TriangleSelectorGUI::render(ImGuiWrapper* imgui, const Transform3d& matrix) return; assert(shader->get_name() == "gouraud" || shader->get_name() == "mm_gouraud"); - for (auto iva : {std::make_pair(&m_iva_enforcers, enforcers_color), - std::make_pair(&m_iva_blockers, blockers_color)}) { - iva.first->set_color(iva.second); - iva.first->render(); + for (auto iva : {std::make_pair(m_iva_enforcers, enforcers_color), + std::make_pair(m_iva_blockers, blockers_color)}) { + iva.first.set_color(iva.second); + iva.first.render(); } for (auto& iva : m_iva_seed_fills) { diff --git a/src/slic3r/GUI/Gizmos/GLGizmoPainterBase.hpp b/src/slic3r/GUI/Gizmos/GLGizmoPainterBase.hpp index 444f6609ff..9b2d731de2 100644 --- a/src/slic3r/GUI/Gizmos/GLGizmoPainterBase.hpp +++ b/src/slic3r/GUI/Gizmos/GLGizmoPainterBase.hpp @@ -49,8 +49,8 @@ public: } // BBS - static ColorRGBA enforcers_color; - static ColorRGBA blockers_color; + static const ColorRGBA enforcers_color; + static const ColorRGBA blockers_color; #ifdef PRUSASLICER_TRIANGLE_SELECTOR_DEBUG void render_debug(ImGuiWrapper* imgui); From 2f58eface9d84c1b61282133a7e672d03fee0626 Mon Sep 17 00:00:00 2001 From: Raoul Rubien Date: Sat, 13 Sep 2025 12:44:01 +0200 Subject: [PATCH 2/2] fixes: the address of int construct_assemble_list(...) will never be NULL [-Waddress] --- src/OrcaSlicer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/OrcaSlicer.cpp b/src/OrcaSlicer.cpp index 4a2cd1ab96..ef6cedd6a4 100644 --- a/src/OrcaSlicer.cpp +++ b/src/OrcaSlicer.cpp @@ -1791,7 +1791,7 @@ int CLI::run(int argc, char **argv) } } catch (std::exception& e) { - boost::nowide::cerr << construct_assemble_list << ": " << e.what() << std::endl; + boost::nowide::cerr << "construct_assemble_list: " << e.what() << std::endl; record_exit_reson(outfile_dir, CLI_DATA_FILE_ERROR, 0, cli_errors[CLI_DATA_FILE_ERROR], sliced_info); flush_and_exit(CLI_DATA_FILE_ERROR); }