3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2025-07-08 07:27:41 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove unused parameter from place_seam method (#6421)

Browse source
This commit is contained in:
Vovodroid 2024-08-18 11:32:56 +03:00 • committed by GitHub
parent 12c4ff0d93
commit 2acd858bf3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/libslic3r/GCode.cpp
View file

@ -4493,8 +4493,7 @@ std::string GCode::extrude_loop(ExtrusionLoop loop, std::string description, dou
float seam_overhang = std::numeric_limits<float>::lowest(); float seam_overhang = std::numeric_limits<float>::lowest();
if (!m_config.spiral_mode && description == "perimeter") { if (!m_config.spiral_mode && description == "perimeter") {
assert(m_layer != nullptr); assert(m_layer != nullptr);
bool is_outer_wall_first = m_config.wall_sequence == WallSequence::OuterInner; m_seam_placer.place_seam(m_layer, loop, this->last_pos(), seam_overhang);
m_seam_placer.place_seam(m_layer, loop, is_outer_wall_first, this->last_pos(), seam_overhang);
} else } else
loop.split_at(last_pos, false); loop.split_at(last_pos, false);

2
src/libslic3r/GCode/SeamPlacer.cpp
View file

@ -1486,7 +1486,7 @@ void SeamPlacer::init(const Print &print, std::function<void(void)> throw_if_can
} }
} }
void SeamPlacer::place_seam(const Layer *layer, ExtrusionLoop &loop, bool external_first, void SeamPlacer::place_seam(const Layer *layer, ExtrusionLoop &loop,
const Point &last_pos, float& overhang) const { const Point &last_pos, float& overhang) const {
using namespace SeamPlacerImpl; using namespace SeamPlacerImpl;
const PrintObject *po = layer->object(); const PrintObject *po = layer->object();

2
src/libslic3r/GCode/SeamPlacer.hpp
View file

@ -143,7 +143,7 @@ public:
void init(const Print &print, std::function<void(void)> throw_if_canceled_func); void init(const Print &print, std::function<void(void)> throw_if_canceled_func);
void place_seam(const Layer *layer, ExtrusionLoop &loop, bool external_first, const Point &last_pos, float& overhang) const; void place_seam(const Layer *layer, ExtrusionLoop &loop, const Point &last_pos, float& overhang) const;
private: private:
void gather_seam_candidates(const PrintObject *po, const SeamPlacerImpl::GlobalModelInfo &global_model_info); void gather_seam_candidates(const PrintObject *po, const SeamPlacerImpl::GlobalModelInfo &global_model_info);
void calculate_candidates_visibility(const PrintObject *po, void calculate_candidates_visibility(const PrintObject *po,