3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2025-07-08 07:27:41 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix #3311: filament Load / Unload time was not used in time estimation (#3706)

Browse source 
* Fix for #3311:

The `config.filament_load_time.values` and `config.filament_unload_time.values` are completely ignored. This was working in PrusaSlicer and apparently BBS converted the `GCodeProcessor::TimeProcessor.filament_load_times` and `GCodeProcessor::TimeProcessor.filament_unload_times` from being `std::vector<float>` to just `float` and they were using the BBS specific and currently hidden `machine_load_filament_time` and `machine_unload_filament_time` config values. Reverted that change by copying those lines from PrusaSlicer.

* Fix for #3311:

Updated the previously fixed to code to keep compatibility with BBS printer .

* Fix for #3311:

Updated `GCodeProcessor::get_filament_unload_time()` to keep compatibility with BBS printers.
This commit is contained in:
Erkan Ozgur Yilmaz 2024-01-25 10:42:27 +00:00 • committed by GitHub
parent aac618dcb7
commit 252788419b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 72 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/libslic3r/GCode/GCodeProcessor.hpp
View file

@ -476,8 +476,8 @@ namespace Slic3r {
bool machine_envelope_processing_enabled;
MachineEnvelopeConfig machine_limits;
// Additional load / unload times for a filament exchange sequence.
float filament_load_times;
float filament_unload_times;
std::vector<float> filament_load_times;
std::vector<float> filament_unload_times;
bool disable_m73;
std::array<TimeMachine, static_cast<size_t>(PrintEstimatedStatistics::ETimeMode::Count)> machines;