3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2025-10-31 04:31:15 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Fix arrange crash with ASAN

Browse source
This commit is contained in:
tamasmeszaros 2019-09-13 11:01:02 +02:00
parent 7fe691f14e
commit 177a96a768
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/libnest2d/include/libnest2d/selections/selection_boilerplate.hpp
View file

@ -33,10 +33,16 @@ protected:
// then it should be removed from the list // then it should be removed from the list
auto it = c.begin(); auto it = c.begin();
while (it != c.end() && !stopcond_()) { while (it != c.end() && !stopcond_()) {
Placer p{bin};
p.configure(pcfg); // WARNING: The copy of itm needs to be created before Placer.
// Placer is working with references and its destructor still
// manipulates the item this is why the order of stack creation
// matters here.
const Item& itm = *it; const Item& itm = *it;
Item cpy{itm}; Item cpy{itm};
Placer p{bin};
p.configure(pcfg);
if (!p.pack(cpy)) it = c.erase(it); if (!p.pack(cpy)) it = c.erase(it);
else it++; else it++;
} }