3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2025-10-18 22:31:13 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Add a simple subtle outline effect by drawing back faces using wireframe mode (#2934)

Browse source 
* Add a simple subtle outline effect by drawing back faces using wireframe mode

* Show outline in white if the model color is too dark

* Make the outline algorithm more reliable

* Enable cull face, which fix render on Linux

* Fix `disable_cullface`
This commit is contained in:
Noisyfox 2023-12-03 09:27:03 +08:00 • committed by GitHub
parent 2745575dd2
commit 0cee513416
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 46 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/slic3r/GUI/3DScene.cpp
View file

@ -472,10 +472,6 @@ void GLVolume::render_with_outline(const Transform3d &view_model_matrix)
//BBS add render for simple case
void GLVolume::simple_render(GLShaderProgram* shader, ModelObjectPtrs& model_objects, std::vector<ColorRGBA> extruder_colors)
{
if (this->is_left_handed())
glFrontFace(GL_CW);
glsafe(::glCullFace(GL_BACK));
bool color_volume = false;
ModelObject* model_object = nullptr;
ModelVolume* model_volume = nullptr;
@ -504,6 +500,7 @@ void GLVolume::simple_render(GLShaderProgram* shader, ModelObjectPtrs& model_obj
}
} while (0);
auto r = [&]() {
if (color_volume && !picking) {
// when force_transparent, we need to keep the alpha
if (force_native_color && render_color.is_transparent()) {
@ -545,6 +542,29 @@ void GLVolume::simple_render(GLShaderProgram* shader, ModelObjectPtrs& model_obj
else
model.render(this->tverts_range);
}
};
if (this->is_left_handed())
glFrontFace(GL_CW);
// Render front faces
glsafe(::glCullFace(GL_BACK));
r();
// Then render back faces in line mode to add an outline
GLboolean cull_face = GL_FALSE;
::glGetBooleanv(GL_CULL_FACE, &cull_face);
glsafe(::glEnable(GL_CULL_FACE));
glsafe(::glCullFace(GL_FRONT));
glsafe(::glPolygonMode(GL_BACK, GL_LINE));
r();
// Reset mode
glsafe(::glPolygonMode(GL_BACK, GL_FILL));
glsafe(::glCullFace(GL_BACK));
if (!cull_face)
glsafe(::glDisable(GL_CULL_FACE));
if (this->is_left_handed())
glFrontFace(GL_CCW);
}
@ -854,6 +874,7 @@ void GLVolumeCollection::render(GLVolumeCollection::ERenderType type, bool disab
}
glsafe(::glCullFace(GL_BACK));
glsafe(::glEnable(GL_CULL_FACE));
if (disable_cullface)
glsafe(::glDisable(GL_CULL_FACE));

5
src/slic3r/GUI/GCodeViewer.cpp
View file

@ -1247,6 +1247,7 @@ void GCodeViewer::render(int canvas_width, int canvas_height, int right_margin)
glsafe(::glEnable(GL_DEPTH_TEST));
render_shells();
glsafe(::glClear(GL_DEPTH_BUFFER_BIT)); // This makes sure toolpaths are on top of shells
render_toolpaths();
float legend_height = 0.0f;
render_legend(legend_height, canvas_width, canvas_height, right_margin);
@ -4030,7 +4031,7 @@ void GCodeViewer::render_shells()
if (shader == nullptr)
return;
glsafe(::glDepthMask(GL_FALSE));
//glsafe(::glDepthMask(GL_FALSE));
shader->start_using();
shader->set_uniform("emission_factor", 0.1f);
@ -4039,7 +4040,7 @@ void GCodeViewer::render_shells()
shader->set_uniform("emission_factor", 0.0f);
shader->stop_using();
glsafe(::glDepthMask(GL_TRUE));
//glsafe(::glDepthMask(GL_TRUE));
}
//BBS