Commit graph

34519 commits

Author SHA1 Message Date
Saumya Jain
fd01684a23
Update resources/qml/WelcomePages/AddLocalPrinterScrollView.qml
Co-authored-by: Jaime van Kessel <nallath@gmail.com>
2024-04-12 12:31:57 +02:00
Saumya Jain
17372064c7
Update resources/qml/WelcomePages/AddLocalPrinterScrollView.qml
Co-authored-by: Jaime van Kessel <nallath@gmail.com>
2024-04-12 12:31:52 +02:00
Saumya Jain
a3911bdbfa PR comments
CURA-11003
2024-04-12 12:29:07 +02:00
Saumya Jain
1457569aeb Fix handling of undefined printer items in AddLocalPrinterScrollView
This commit addresses an issue wherein undefined current items were not properly handled in the AddLocalPrinterScrollView module. We've changed the code so that it now checks if currentItem and currentItem.name exist before attempting to assign. If they don't exist, we now set default values to avoid null or undefined references. This prevents potential errors or inconsistent behaviors in the UI.

CURA-11003
2024-04-10 17:24:55 +02:00
Saumya Jain
3908db7696 Update search bar style and theme alteration
CURA-11003
2024-04-10 15:45:24 +02:00
Saumya Jain
8f09d35955
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-10 15:17:14 +02:00
HellAholic
e37434abef
Merge pull request #18824 from Ultimaker/CURA-10903-warn-for-deleted-files
Add detection for deleted files in printer linter
2024-04-10 15:01:06 +02:00
Saumya Jain
c6ff0d3030 Enhance error reporting for deleted files
The code now checks if a requested file is present in the files list before diagnosing issues and generating error reports for it. It will help prevent attempting to diagnose or report on files that do not exist or deleted, thus enhancing efficiency and preventing possible error generation

CURA-10903
2024-04-10 14:50:26 +02:00
Saumya Jain
a965392559 Update method for getting PR number and modify output report
The code updates the way we fetch the Pull Request number in the Github action. Rather than using an external action, we directly make use of Github's CLI, which helps improve the speed and reliability of the workflow. Additionally, the output report's format in terminal.py, previously named as "Git Comment", has been changed to "Error Files" to better reflect the information it carries.

CURA-10903
2024-04-10 14:16:25 +02:00
Saumya Jain
d52cd78852 Update GitHub workflow to use create-or-update-comment action
In this update, the GitHub workflow now uses the 'create-or-update-comment' action instead of the 'find-comment' action for PR comments. Additionally, a step has been added to get the PR number. This change is expected to facilitate more efficient PR commenting and handling.

CURa-10903
2024-04-10 14:01:17 +02:00
Saumya Jain
bb94ce9e75 fixing typo checks
CURA-10903
2024-04-09 11:37:42 +02:00
Saumya Jain
561a40d000 Implement GitComment class and update workflow files
A new GitComment class was implemented to replace Diagnostic for deleted file checks. As part of this change, both main workflow files (printer-linter-pr-diagnose.yml and printer-linter-pr-post.yml) have been updated to accommodate this new class. Also, reports now use 'comment.md' instead of 'fixes.yml'. All of this is ultimately geared at improving diagnostic functionality and allowing deleted file checks to output directly to a Git comment.

CURA-10903
2024-04-09 11:33:24 +02:00
Saumya Jain
d017f0ec9c increased size of clear icon
CURA-11003
2024-04-08 15:37:48 +02:00
Saumya Jain
78b7793cd4
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-08 14:08:38 +02:00
Saumya Jain
702f8573c3
Merge branch 'main' into CURA-10903-warn-for-deleted-files 2024-04-08 14:03:48 +02:00
HellAholic
bb444a6eb4
Merge pull request #18822 from Ultimaker/CURA-10904-printer-linter-material-temperature
Cura 10904 printer linter material temperature
2024-04-08 13:38:24 +02:00
Saumya Jain
323a347248
Merge branch 'main' into CURA-10904-printer-linter-material-temperature 2024-04-08 12:50:52 +02:00
Saumya Jain
29617ea22f removed path with parent because it doesn't exist anymore 2024-04-08 12:42:33 +02:00
Saumya Jain
061a80deb4
Merge branch 'main' into CURA-10903-warn-for-deleted-files 2024-04-08 12:25:36 +02:00
Saumya Jain
b3a25893fc fix results to result
CURA-10903
2024-04-08 12:25:10 +02:00
Saumya Jain
c53e611c81 Update printer-linter workflow and fix file checks order
CURA-10903
2024-04-08 12:23:26 +02:00
HellAholic
d842d9c139
Merge pull request #18815 from Ultimaker/CURA-11748-crash-during-the-material-setting-load
Update MaterialNode initialization and metadata retrieval
2024-04-08 12:17:52 +02:00
Saumya Jain
13ad75a240 fixing command
CURA-10903
2024-04-08 10:52:17 +02:00
Saumya Jain
8b135b5562 Update command to retrieve deleted files
CURA-10903
2024-04-08 10:50:24 +02:00
Saumya Jain
2f8829c2d1 GIT_DIFF not necessarity have the info of deleted files
CURA-10903
2024-04-08 10:42:17 +02:00
Saumya Jain
7231c273a1 Refactor textChanged event
helps to increase code readability and maintainability.

CURA-11003
2024-04-05 16:26:33 +02:00
Saumya Jain
66754d837b Remove redundant printerSearchTimer
CURA-11003
2024-04-05 16:24:34 +02:00
Saumya Jain
38382eeec7 Add detection for deleted files in printer linter
This update adds a new check for deleted files in the printer linter. This will alert the user when a file has been deleted that could potentially disrupt upgrade scripts. An argument "--deleted" is also added to terminal.py to facilitate this new check. Additionally, the printer-linter version has been incremented to 0.1.2.

CURA-10903
2024-04-05 15:55:30 +02:00
Saumya Jain
794cdfd077 Same as before.
CURA-10904
2024-04-05 11:59:39 +02:00
Saumya Jain
0049271ae8
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-05 10:10:23 +02:00
Saumya Jain
6609741323 Fix potential key error in printer linter
CURA-10904
2024-04-05 10:06:28 +02:00
Saumya Jain
e5fb40b48c Add material temperature check in linter
CURA-10904
2024-04-05 10:02:08 +02:00
Erwan MATHIEU
8020b9d97d Move back to testing packages on main 2024-04-04 15:05:13 +02:00
Saumya Jain
7a6f195b74 changed filter from "id" to "name" as both are different
CURA-11003
2024-04-04 14:37:51 +02:00
Saumya Jain
f35865e3c4 property name hasSearchFilter changed
CURA-11003
2024-04-04 14:13:58 +02:00
Saumya Jain
2ed0377a05 added column for removing the magic number
CURA-11003
2024-04-04 14:09:58 +02:00
Saumya Jain
b944e35c25 Update MaterialNode initialization and metadata retrieval
Although this is rare scenario.This allows for metadata retrieval from the container directly if one is provided, otherwise metadata is fetched using the container_id from the ContainerRegistry. Updated the MaterialNode creation in the VariantNode class(only one scenario) to pass the container.

CURA-11748
2024-04-04 13:19:32 +02:00
Saumya Jain
a6e91fecf3
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-03 17:08:11 +02:00
Saumya Jain
da8db6201e merge 5.7 2024-04-03 16:59:46 +02:00
Saumya Jain
4c42ed7085 Refactor code in AddLocalPrinterScrollView.qml
The commit simplifies the function for updating current items in the AddLocalPrinterScrollView.qml file. It also removes unnecessary properties and functions, streamlining the process for setting printer info. The changes improve code readability and efficiency

CURA-11003
2024-04-03 16:16:28 +02:00
Saumya Jain
b810e63c60
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-03 14:52:19 +02:00
Saumya Jain
56d6325671 expanding found machines inside sections
CURA-11003
2024-04-03 14:50:14 +02:00
Saumya Jain
2249e298ca Implement printer search feature in local printer selection
Added a search field in the 'Add Local Printer' section which allows users to search for their desired printer. A timer has been set to trigger the search function as the user types into the search field. A clear button is visible for easy removal of the search text. Adjusted the ListModel.py to correctly emit dataChanged signal when there are changes in the list.

CURA-11003
2024-04-03 12:32:25 +02:00
HellAholic
8c0225c20e
Merge pull request #18796 from Ultimaker/CURA-11738-string-correction-for-openUCP
Corrected string
2024-04-03 12:25:35 +02:00
Jaime van Kessel
b5f56dfb97
Merge pull request #18724 from nathanrooy/main
Fixed "positionning" -> "positioning" typo
2024-04-03 09:42:18 +02:00
Nathan Rooy
e8d7a3cda6
Merge branch 'main' into main 2024-04-02 10:20:27 -04:00
Erwan MATHIEU
04ddb8e6e0 Merge remote-tracking branch 'origin/5.7' into 5.7 2024-04-02 14:11:31 +02:00
Erwan MATHIEU
40742565e7 Set proper 5.7.0 version 2024-04-02 14:11:08 +02:00
Erwan MATHIEU
bd5b4c3742 Pin dependancies versions for 5.7.0 2024-04-02 14:10:48 +02:00
Erwan MATHIEU
e08123bf86
Merge pull request #18798 from Ultimaker/CURA-11801-values-not-visible-saving-ucp
Values now shown while saving UCP
2024-04-02 14:09:51 +02:00