It seems that the extra logic doesn't play well with a menu bar.
Since we don't need to make this menu invisible ever, there is no need for the
extra logic to hide it. As such we can just use the regular menu
CURA-8683
This is more in line with what you see, so you can click on the icon properly to open the per-object settings panel. And the text gets properly elided where the icon starts.
And an example of such usage: In the material sync via cloud we only want to sync with printers that can receive those materials.
We might want to add a message for the user to also make sure the firmware is up to date. Because if the firmware is not up to date now it will show no printers and instruct the user how to connect the printer to the cloud.
Contributes to issue CURA-8671.
Conflicts:
resources/i18n/de_DE/fdmprinter.def.json.po -> German translations got some fixes in master while we also updated the new translations for 4.12.
This prevents being able to align the text vertically with the troubleshooting button though. The text may become the larger of the two, in which case the text should be leading the height. Qt can do this with a Layout, however it then can't automatically adjust the width of the layout there since that would create a polish loop in the layout.
Contributes to issue CURA-8609.
Because with our default theme, the neutral icon is empty. This causes the alignment of the label next to it to appear off.
Contributes to issue CURA-8609.
It's moving there now. However if there are any errors syncing with the printers, the troubleshooting link has to disappear from there.
This makes the layout quite complex, since the icon on the left and the button on the right are no longer vertically centred. The text used to be vertically centred too, but can't do that any more since the text is not the determiner of the height any more, with there being a horizontally aligned button below it. It's all a bit complex now.
Contributes to issue CURA-8609.
Don't just use white rectangles or black text. Use the theme where appropriate. And these rectangles are just outlines.
Contributes to issue CURA-8609.