Commit graph

7605 commits

Author SHA1 Message Date
c.lamboo
6d0acbe095 Always show correct number of connected machines
Calculate number of connected machines _after_ the abstract machine its connected is removed from the list

CURA-9277
2022-09-02 16:28:10 +02:00
c.lamboo
27fc11b840 Prevent abstract machines from being deleted in the config menu
CURA-9277
2022-09-02 16:26:17 +02:00
c.lamboo
8bb2671a28 Don't show abstract machines in configuration page
So they cannot be removed through the preferences

CURA-9289
2022-09-02 16:26:17 +02:00
Maël Kerbiriou
111136cf49 use automatic drop down setting from SceneNodeSettings 2022-09-01 15:29:52 +02:00
Jaime van Kessel
438871648b
Don't notify qml of update if no configurations changed
This might be the cause of #11608, but i'm not entirely sure. Whatever
the case, it's also not going to hurt checking this...
2022-08-31 16:31:39 +02:00
c.lamboo
c73b980a3d Merge branch 'main' into CURA-9422_abstract_cloud_monitor_redux
# Conflicts:
#	resources/qml/PrinterSelector/MachineListButton.qml
2022-08-31 16:05:00 +02:00
Jaime van Kessel
ded3873249
Fix abstract machines being displayed twice 2022-08-31 15:12:25 +02:00
Remco Burema
a713b1e9e9
Merge pull request #13165 from Ultimaker/CURA-8463_cloud_configuration
Show all configurations in "abstract" printer from cloud
2022-08-31 14:50:13 +02:00
Remco Burema
afeec473f6 Small fixes (mostly QML warnings and the like).
done as part of CURA-9422
2022-08-31 14:15:05 +02:00
Remco Burema
4ea437ba28 Make send to DF in monitor for abstract printer work (again-ish).
Already moslty implemented, but a new approach of the base feature (abstract cloud printers) made a more? elegant and functioning implementation possible.

(re)implements CURA-9422
2022-08-31 14:13:47 +02:00
Jaime van Kessel
5daf45e750
Merge pull request #13172 from digitalfrost/310822
MachineAction.py: Use error method with Logger
2022-08-31 14:11:31 +02:00
joeydelarago
ab722eb93c Default printers should be collapsed
CURA-9514
2022-08-31 13:19:12 +02:00
digitalfrost
9084c31ce7 MachineAction.py: Use error method with Logger
Use f-string and error method with Logger instead of "Old Style" string
formatting.
2022-08-31 12:11:20 +02:00
Casper Lamboo
dccffdeca3
Update cura/Machines/Models/MachineListModel.py 2022-08-31 11:08:37 +02:00
joeydelarago
19835844bf Change listType -> componentType. Makes it a bit more clear that this variable decides which component should be used for the model.
CURA-9514
2022-08-31 10:50:20 +02:00
Jaime van Kessel
4c55befad7
Merge branch 'main' of github.com:Ultimaker/Cura into CURA-8463_cloud_configuration 2022-08-31 10:39:05 +02:00
joeydelarago
b999a88b26 Update function name to match code style
CURA-9514
2022-08-31 10:26:57 +02:00
joeydelarago
9f204f2e43 Update isAbstractMachine to match Role name format.
CURA-9514
2022-08-31 10:20:50 +02:00
joeydelarago
760e53c401 Fix indentation
Remove debug statement

CURA-9514
2022-08-31 10:19:02 +02:00
joeydelarago
daab1aae71 QML was attempting to fetch variables that were emtpy. Using self.clear() properly removed unused items when the list is resized to be smaller.
Also add some dummy variables inside cloud printer expand and contract buttons.

CURA-9514
2022-08-31 10:05:41 +02:00
c.lamboo
aa1c09591f Typo
CURA-9514
2022-08-31 08:15:13 +02:00
c.lamboo
60b12b9247 Use list model to display show hide buttons
CURA-9514
2022-08-31 07:58:05 +02:00
c.lamboo
ac732e9604 Add button to hide/show connected printers
CURA-9514
2022-08-30 23:15:54 +02:00
joeydelarago
f3b9040561 Add sanity check for printers that are online. They must have an online connection type. This can pop up when adding a printer from a 3mf since we do not store the connection_type but we do store is_online=True.
CURA-9277
2022-08-29 14:03:23 +02:00
Jaime van Kessel
506f2b9820
Remove code duplication in createAbstractMachine
This also caused a crash when an abstract machine with multiple extruders was selected

CURA-8463
2022-08-26 14:08:03 +02:00
Jaime van Kessel
46532828a4
Add logging for when setting the active machine failed
CURA-8463
2022-08-26 13:46:01 +02:00
Jaime van Kessel
0516b27f2b
Clean up formatting of documentation
Boyscouting!

CURA-8463
2022-08-26 13:35:13 +02:00
Remco Burema
95f234679c Placeholder; the selected printer to monitor is abstract, but cloud-capable.
forms the base of CURA-9422
2022-08-26 13:10:09 +02:00
c.lamboo
ff7c9eddde Add documentation
CURA-9514, CURA-9277
2022-08-26 11:34:34 +02:00
c.lamboo
f000b75661 Move getMachinesWithDefinition to MachinesManager
CURA-9514, CURA-9277
2022-08-26 11:16:10 +02:00
c.lamboo
8b84db7059 Remove AbstractMachine
Having a separate class for the AbstractMachine complicated things; it's behaviour was extremely similar to the GlobalStack so adding one more stack container type in addition to the many similar setting container types we already have adds complexity to the system. Having these different classes for machines and abstract machines also add complexity to the update script as the abstract machines were stored in a separate folder from the machine types.

Because of these reasons we decided to replace the AbstractMachine by a GlobalStack where the is_abstract_machine property metadata property is set to True.

CURA-9514, CURA-9277

Co-authored-by: joeydelarago <joeydelarago@gmail.com>
2022-08-26 10:45:45 +02:00
digitalfrost
bb0870008e CuraSceneController.py : Fix problem with log message and use f-string
- Correct log message (we want to log the "selected" build plate)
- Use f-string and debug method for Logger instead of "Old Style" string formatting.
2022-08-24 20:22:20 +02:00
digitalfrost
afb90b4b2e Move initialization of found_solution_for_all
Initialize the variable found_solution_for_all with False and
 don't set it a the exception block.
2022-08-24 19:52:26 +02:00
Casper Lamboo
197683c6c6
Merge pull request #13102 from Ultimaker/CURA-9514_collapsable_printers_list
[CURA-9514] Collapsable printers list
2022-08-24 16:07:41 +02:00
joeydelarago
04580b8fdc Simplify logic by having abstract printers always be online.
CURA-9221
2022-08-24 14:33:04 +02:00
joeydelarago
b4e5fd8526 Remove debug statement
CURA-9514
2022-08-24 10:24:53 +02:00
joeydelarago
1e898ff930 Remove redundant comment
CURA-9514
2022-08-24 10:23:35 +02:00
joeydelarago
91b8c97dae Subtract online printers from list of all printers instead of searching for offline printers.
This prevents printers without "is_online" in the metadata from being left out, and is generally more defensive for uncertain states.

CURA-9514
2022-08-24 10:09:45 +02:00
joeydelarago
52b2a8322c Include LAN printers in abstract printers list
Make filtering clearer by splitting it up into multiple lines.

CURA-9514
2022-08-24 10:06:51 +02:00
digitalfrost
e9172b10af
Use f-string and warn method with Logger
Use f-string and warn method for Logger instead of "Old Style" string formatting.

Co-authored-by: Jelle Spijker <spijker.jelle@gmail.com>
2022-08-23 20:01:47 +02:00
digitalfrost
9f3a1cfe0a Use f-string and info method with Logger
Use f-string and info method for Logger instead of "Old Style" string
formating.
2022-08-23 19:53:50 +02:00
joeydelarago
eea8935741 Set minimum width, so that drop down is still readable on small screens
CURA-9514
2022-08-23 16:20:04 +02:00
joeydelarago
035fb27ab0 Code style
CURA-9514
2022-08-23 15:44:42 +02:00
joeydelarago
93e2bef303 Group printers by section (Connected Printers/Other Printers)
Cleanup redundant code.

CURA-9514
2022-08-23 15:44:16 +02:00
joeydelarago
b18080c332 Rename AbstractStacksModel.py -> MachineListModel.py since this model includes both abstract machine stacks and regular machines
Add machineCount for displaying the number of machines of a type.

MachineSelectorButton is in use in other places, swapped it out for a new Component MachineListButton.

CURA-9514
2022-08-23 14:29:05 +02:00
joeydelarago
bedb76d516 Update comment
CURA-9514
2022-08-23 13:11:17 +02:00
joeydelarago
7ffa770fb4 Searching container registry returns ContainerStacks.
Made typing more generic to work with an ContainerStack to compensate.

Made AbstractMachine getMachines a classmethod so it can be called with ContainerStacks.

CURA-9514
2022-08-23 10:35:00 +02:00
Jelle Spijker
63dc79dca1
Merge pull request #13082 from digitalfrost/200822
OnExitCallbackManager.py: improve documentation
2022-08-23 10:27:21 +02:00
Jelle Spijker
cc9a413a49
Merge pull request #12909 from digitalfrost/310722
Use dataclasses for Peripheral
2022-08-23 10:23:47 +02:00
Jelle Spijker
67c8585c68
Merge pull request #12929 from digitalfrost/020822
MachineErrorChecker.py: Move _error_check_timer initialization to a separate function
2022-08-23 10:19:24 +02:00