Commit graph

24769 commits

Author SHA1 Message Date
Kostas Karmas
d47623d58a Remove duplicate addition of items in the node_items list
CURA-7440
2020-10-09 17:19:53 +02:00
Kostas Karmas
f9bd5e3dcd Modify arrange() to optionally create AddSceneNodeOperations
Then the MultiplyObjectsJob can use the arrange function instead of duplicating the code

CURA-7440
2020-10-09 17:12:59 +02:00
Kostas Karmas
518003f027 Remove unused variables
CURA-7440
2020-10-09 16:03:31 +02:00
Kostas Karmas
eedbcb6a2d Fix z position of objects that end outside the buildplate
When multiplying objects or inserting objects in the scene that do not fit in the buildplate, those
objects would correctly end up outside the buildplate, but their Z position would be aligned at the
absolute Z=0 of the buildplate.

This commit fixes that by compensating in the z-axis, properly moving the object outside the
buildplate in the correct z-position so that it's bottom is aligned with the original object.

CURA-7440
2020-10-09 15:59:50 +02:00
Jaime van Kessel
0493fb24df
Add extra human readable strings to asserts 2020-10-09 15:08:27 +02:00
Jaime van Kessel
8f4dd3cb12
Made the asserts of the profile tests a bit more explicit
This makes it easier to read the test outcome, since it gives
much better hints what can / needs to be done to fix it.
2020-10-09 14:02:47 +02:00
Jaime van Kessel
bfef61ad81
Use fastConfigParser for the versionUpToDate test
This makes the test a fair bit faster!
2020-10-09 13:58:26 +02:00
Jaime van Kessel
f31490125c
Add test to check if profile ID's are unique
CURA-7763
2020-10-09 13:53:58 +02:00
Kostas Karmas
0922f03ca5 Merge branch 'CURA-7440-pynest2d_for_arrange' of https://github.com/Ultimaker/Cura into CURA-7440-pynest2d_for_arrange 2020-10-09 13:52:07 +02:00
Remco Burema
d3ec1d7d28
Cache wasn't valid due to a reference being stored, not a copy.
paer of CURA-7440
2020-10-09 13:39:53 +02:00
Jaime van Kessel
77290451e1
Remove a bunch of unneeded properties from the labels
CURA-7745
2020-10-08 18:00:53 +02:00
Jaime van Kessel
ec5796400b
Remove hardcoded narrow_margins
CURA-7745
2020-10-08 17:55:11 +02:00
Jaime van Kessel
3e67d20890
Remove monitor_text_primary
It's so close to the text one that it really doesn't make sense to keep it.
Boyscouting the code a bit here

CURA-7745
2020-10-08 17:31:19 +02:00
Jaime van Kessel
910d8ec472
Fix reference error
CURA-7745
2020-10-08 17:22:24 +02:00
Jaime van Kessel
99f42c179f
Remove hardcoded value for num extruders
CURA-7745
2020-10-08 17:18:24 +02:00
Kostas Karmas
8678682d94 Reformat file and remove unused import
CURA-7440
2020-10-08 16:27:36 +02:00
Ghostkeeper
6bfa24686f
Mark disallowed areas as disallowed areas
Also improve the filtering a bit so that it's no longer dependent on the order. Doesn't really matter in this case but it should be more robust.

Contributes to issue CURA-7754.
2020-10-08 11:10:24 +02:00
Jaime van Kessel
a46bf8d6fa
Apply suggestions from code review
CURA-7440

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>
2020-10-08 09:43:22 +02:00
Remco Burema
24f95a9cab
Fix confusing nozzle-node 'ghost' in simulation-view.
part of a 30-min fix
2020-10-07 16:22:22 +02:00
Jip-Hop
3a16750b5a
Update creality_cr10max.def.json
We need the same fix as in https://github.com/Ultimaker/Cura/pull/7526 for the CR-10 Max as well.
2020-10-07 16:10:22 +02:00
Kostas Karmas
f25bfd717e Recalculate the number of user settings after setting the quality group
So that the dialog ensures actually knows that there are no changed settings and will not show up.

CURA-7728
2020-10-06 09:55:11 +02:00
Ghostkeeper
55f0c10f94
Upgrade usage of support_tree_enabled
This setting no longer exists.

Contributes to issue CURA-7752.
2020-10-05 17:59:57 +02:00
Ghostkeeper
87eca6f46a
Raise error if there is a syntax error in stored post-processing scripts
Instead of just crashing the entire application.

Fixes Sentry issue CURA-19W.
2020-10-05 17:59:25 +02:00
Jaime van Kessel
d801f9838a
Fix mypy issues
It doesn't seem to like blanket imports

CURA-7440
2020-10-05 14:52:50 +02:00
Jaime van Kessel
59b9639d87
Don't let arranger place all objects on the same spot if they don't fit
CURA-7440
2020-10-05 14:31:42 +02:00
Jaime van Kessel
a14135be5e
Add some documentation to the arrange nest algorithm
CURA-7440
2020-10-05 14:24:34 +02:00
Jaime van Kessel
9312dc5c07
Add deprecated tag to arranger
CURA-7440
2020-10-05 14:15:49 +02:00
Jaime van Kessel
a1f43e7bcf
Also use the new arranger when multiplying objects 2020-10-05 14:09:50 +02:00
Ghostkeeper
9b5005fc90
Fix Biqu definition files
There were a number of problems with it:
* There were duplicate JSON keys. One of the duplicates gets ignored then according to the JSON implementation in Python.
* There were some 'value' properties that contained undefined variables since the setting type was a string and the value is a string containing a Python expression that should result in a string, not a plain string.
* There was one instance in which a 'default_value' property contained a formula.

Contributes to issue CURA-7752.
2020-10-05 13:47:24 +02:00
Jaime van Kessel
5823140b21
Always add multiplied nodes to the root.
No idea why it was using the parent of the current node. It's
technically the same, but this is much more explicit

CURA-7440
2020-10-05 13:45:24 +02:00
Ghostkeeper
a73cd96e1a
Rename Biqu quality profiles to have unique IDs
These IDs were the same as the Creality profiles. As a result, only one profile could load into Cura of the two duplicates. In this case it chose Biqu's profile, and the Creality profiles wouldn't load as a result.

Contributes to issue CURA-7752.
2020-10-05 13:39:31 +02:00
Jaime van Kessel
30966beed2
Let autoplacement also take the existing nodes into account
CURA-7440
2020-10-05 13:37:57 +02:00
Jaime van Kessel
a34f1a6504
Arrange newly placed models
CURA-7440
2020-10-05 13:14:21 +02:00
Jaime van Kessel
2d084c9e2b
Remove the old arrange from mesh placement on load
For some reaso it was also handling the move up to the buildplate (which it
really shouldn't do)

CURA-7440
2020-10-05 13:08:28 +02:00
Ghostkeeper
abe2a56a03
Merge branch 'hotfix/simplify-baud-job-plugin' of https://github.com/aerotog/Cura into aerotog-hotfix/simplify-baud-job-plugin 2020-10-05 13:02:13 +02:00
Kim Evgeniy
adcd2df800
upload new extruder ZAV v1 2020-10-04 23:10:54 +03:00
kimer2002
1b463b7210
upload new printer ZAV 2020-10-04 23:01:25 +03:00
kimer2002
d798dfffb6
Add files via upload 2020-10-04 22:54:40 +03:00
Ghostkeeper
2ec5ffba0d
Assign FABtotum profiles to 0.4mm nozzle
This is the default (preferred) nozzle for the FABtotum Personal Fabricator.
Apparently when these nozzle profiles were added, the existing quality profiles weren't considered. We'll now put them on the nozzle size that the FABtotum printer had before the nozzle profiles were added. There is also the Pro nozzle for FABtotum but I think the Lite is more likely what the profiles were originally made for, since that is the default.
2020-10-02 15:04:57 +02:00
Ghostkeeper
5415ded35d
Update setting_version of new profiles
Normally we'd require contributors to submit up-to-date profiles but in this case they did, we were just slow to respond.

Contributes to issue CURA-7757.
2020-10-02 14:05:24 +02:00
Ghostkeeper
b2a5cd9703
Merge branch 'master' of https://github.com/eMotion-Tech/Cura into eMotion-Tech-master 2020-10-02 13:51:17 +02:00
Ghostkeeper
cd683bdcb6
Clarify description of what happens if bed temperature is 0
A bit more accurate.

Fixes #8460.
2020-10-02 13:31:57 +02:00
Jaime van Kessel
274dc8d06c
Split up arrange
This splits up the finding of new positions with the actual move. This is needed
for when we want to place new nodes on model load.

CURA-7440
2020-10-02 11:21:57 +02:00
Jaime van Kessel
c25351c98a
Remove unused imports
CURA-7440
2020-10-02 10:06:41 +02:00
Jaime van Kessel
8c1985cdb3
Move nest2darrange to it's own function
This makes it a lot easier to re-use it

CURA-7440
2020-10-02 10:06:09 +02:00
Jaime van Kessel
c33c025a6c
Add getters for Width/height/depth to build volume
CURA-7440
2020-10-02 10:04:46 +02:00
Tim Guenthner
27eb72c64a Remove redundant variable 2020-10-01 19:47:41 -05:00
Luke Harrison
ecf32a261e
Added BIQU machine base files as well as BIQU B1 machine files. (#8276)
* Added BIQU machine base files as well as BIQU B1 machine files.

* Fixed a variants settings version error.

* Updated base def by removing excluded materials and changing the pref to pla175

* Fixed the machine name value which should only take a default value and not also a value.

* Increased the max extruder feedrate to allow the default retraction speed.

* Removed comments from the quality profiles. Removed author from variants. Adjusted materials in quality profiles to refer to the 175 profiles directly.

* Enabled coasting by default in the B1 profile and increased the width of infill for the base profile.

* Updated all quality and variants configs to use settings version 16 in anticipation of release 4.8

* Final tweaks to B1 start gcode

* Added an ABL version of the B1 with tweaked start codes.
2020-09-30 17:00:10 +02:00
Remco Burema
395cdc14bb
Add warning max-value to skin-edge-support settings.
Can keep the CPUoccupied for a long time with higher values. Decided that very few people will need that many layers anyway. Rather than complete defer, at least warn people something might be up.

a 5-min. fix
2020-09-30 12:41:36 +02:00
Jaime van Kessel
e0e65b91b5
Take disallowed areas into account when arranging
CURA-7440
2020-09-30 10:34:35 +02:00