Commit graph

9887 commits

Author SHA1 Message Date
fieldOfView
4600ee9355 Change wording for clarity 2020-03-22 18:35:01 +01:00
fieldOfView
6e09e9821f Show support settings when support meshes are present in the scene 2020-03-22 18:23:32 +01:00
Ghostkeeper
485e37e7f5
Extruders can be undefined, not null
This happens when the printer is changed, such as when changing the Machine Width in the machine settings dialogue. It updates these menus then and if not all extruders are defined it'll give the following errors:
2020-03-20 16:56:57,839 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/resources/qml/Menus/SettingsMenu.qml:51: TypeError: Cannot read property 'isEnabled' of undefined
2020-03-20 16:56:57,840 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/resources/qml/Menus/SettingsMenu.qml:44: TypeError: Cannot read property 'isEnabled' of undefined
2020-03-20 16:56:57,841 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/resources/qml/Menus/MaterialMenu.qml:26: TypeError: Cannot read property 'isEnabled' of undefined
2020-03-20 16:56:57,841 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/resources/qml/Menus/MaterialMenu.qml:28: TypeError: Cannot read property 'material' of undefined

Done during Turbo Testing and Tooling.
2020-03-20 17:03:08 +01:00
Ghostkeeper
2f3462203c
Fix QML errors due to property providers not being initialised yet
This then updates in a fraction of a millisecond later before things even appear on the screen, so it's not so bad to not have a tooltip or to have it show 0 then.

Done during Turbo Testing and Tooling.
2020-03-20 16:58:18 +01:00
Ghostkeeper
31aee866f4
Check if options are available before matching on them
This prevents a QML warning when the ListModel is created before the property provider is. This QML warning looked like this:
2020-03-20 15:04:30,012 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/cura/../resources/qml/MachineSettings/ComboBoxWithOptions.qml:74: TypeError: Cannot call method 'match' of undefined

Done during Turbo Testing and Tooling.
2020-03-20 15:09:46 +01:00
Ghostkeeper
5cfe71e516
Fix binding loop in action panel widget
This widget can't set its width to the width of its children, since its children anchor to its right-hand side which depends on the width.
This fixes the following warning in the log:
2020-03-20 14:25:20,351 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/plugins/PrepareStage/PrepareMain.qml:16:5: QML ActionPanelWidget: Binding loop detected for property width

Done during Turbo Testing and Tooling.
2020-03-20 14:52:33 +01:00
Ghostkeeper
3af91bfca7
Fix QML warning assigning undefined to an integer field
Fixes the following QML warning in the logs:
2020-03-20 14:02:13,482 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml:125:13: Unable to assign [undefined] to int

Instead it now assigns the first extruder before a printer has been created. The first extruder also doesn't exist yet at this point, but this doesn't really matter because there is no interface to show yet at this point.

Done during Turbo Testing and Tooling.
2020-03-20 14:17:24 +01:00
Ghostkeeper
c44f82c44f
Add placeholder header pattern
This removes a warning from our log that this image couldn't be found. Instead it now draws a completely transparent image there.
The warning that is no longer in the log now looked like this:
2020-03-20 13:52:27,980 - WARNING - [MainThread] UM.Qt.Bindings.Theme.getImage [133]: No image header_pattern defined in Theme

Done during Turbo Testing and Tooling.
2020-03-20 14:05:42 +01:00
Ghostkeeper
c7e6553dbf
Disallow printers larger than 2km
To do this, I'm giving more power to the NumericTextFieldWithUnit QML element, to allow an arbitrary minimum and maximum. Enforcing this minimum and maximum is fairly simple with a JavaScript hook. This hook is necessary because the DoubleValidator allows intermediary values which defeats the purpose, essentially allowing any number as long as it has the correct number of digits.
Printers larger than 2km would start to give overflow errors in its X and Y coordinates. Z is okay up to about 9 billion kilometres in theory, since we don't need to do any squaring math on those coordinates afaik. In practice I'm doing this because at very high values the Arranger also gives errors because Numpy can't handle those extremely big arrays (since the arranger creates a 2mm grid).

Fixes Sentry issue CURA-CB.
2020-03-20 11:16:16 +01:00
Jaime van Kessel
decf96e99e
Set verticalAlignment of numericTextField
Contributes to #7300
2020-03-20 11:04:24 +01:00
Ghostkeeper
44b61d370f
Merge branch 'master' of github.com:Ultimaker/Cura 2020-03-19 14:48:45 +01:00
Ghostkeeper
df0a3143d2
Merge branch 'master' of https://github.com/Magicfirm/Cura into Magicfirm-master 2020-03-19 14:43:47 +01:00
konskarm
90ed7ac184
Merge pull request #7298 from Ultimaker/CURA-7311_stair_step_height_0_for_pva
Reduce stair step height to 0 for PVA
2020-03-19 14:12:28 +01:00
konskarm
7d2391c4ed
Merge pull request #7101 from yyh1002/master
Add DXU machine profile
2020-03-18 16:12:50 +01:00
Ghostkeeper
fdd1cef11a
Reduce stair step height to 0 for PVA
Given that:
* stair stepping is intended to be used to reduce the adhesion between support and the model, where the support rests on the model, and to reduce scarring, and
* PVA doesn't suffer from scarring or adhesion issues due to its water-solubility, and
* our current stair stepping algorithm has some bugs, causing support to disappear sometimes

we've decided to set stair stepping to 0 for all PVA profiles for UM3, UMS5 and UMS3.

Contributes to issue CURA-7311.
2020-03-18 15:50:27 +01:00
Jaime van Kessel
ced25adc2b
Merge branch 'CURA-7017_link_to_help' of github.com:Ultimaker/Cura 2020-03-18 10:49:35 +01:00
Kostas Karmas
34f81ed0b0 Add link then the printer is not found
CURA-7017
2020-03-18 09:31:13 +01:00
konskarm
39f41e8e74
Merge pull request #7112 from mehmetsutas/master
Update Rigid3D Printer Profiles
2020-03-17 16:37:58 +01:00
jeffkyjin
aea8dc4856 remove has_machine_quality for grid 2+ 2020-03-17 23:27:00 +08:00
konskarm
c19a0c24a2
Merge pull request #7243 from oducceu/master
Add Flying Bear Printers
2020-03-16 09:08:18 +01:00
Ghostkeeper
ca65aa4112
Add missing setting descriptions
These are summarised from the Settings Guide articles I wrote a month ago.
2020-03-15 19:33:53 +01:00
ODUCCEU
a5bdea75e0 Reduce redundant variants 2020-03-13 13:45:35 +03:00
ODUCCEU
68988c1d7b Change file names according to naming convention 2020-03-13 12:52:51 +03:00
Jaime van Kessel
78bbc4c955
Add work around to prevent setting not updating 2020-03-12 13:38:36 +01:00
Jaime van Kessel
d01286a340
Remove all duplicate entries from dark theme 2020-03-10 11:57:30 +01:00
Jaime van Kessel
1a24e9a04a
Remove unneeded overrides from dark theme 2020-03-10 11:35:07 +01:00
Jaime van Kessel
9f8b882452
Merge branch 'transparent_support' of https://github.com/Ghostkeeper/Cura 2020-03-10 11:26:05 +01:00
Ghostkeeper
d7d91d2fec
Don't translate 'Language:' string
This should make it easier to find the language drop-down again if you can't read the current language.

Done as a 5 minute fix.
2020-03-10 11:19:32 +01:00
Ghostkeeper
d2cab162ed
Make support render transparently
This way you can still sort of see what is being supported under there. Handy!

However because the layer view is rendered on top of everything else, the Z buffering is a bit messed up. This makes the support always exactly the transparency value in the theme regardless of how many layers of support are drawn. That's nice, because it makes it so that you can always see through the support.

This doesn't work when the colour scheme of layer view is not set to Line Type. There is no differentiation between support and other things then. Support infill seems to not be used at all by layer view, but I've also made the support interface transparent just like the normal support.
2020-03-10 01:06:11 +01:00
Ghostkeeper
7b0964abef
Merge branch 'DenyCZ-4.5' 2020-03-09 16:57:09 +01:00
Ghostkeeper
0c9a8d3a7c
Add Czech language to the list
You can now select Czech as your Cura language.

Contributes to issue CURA-7285.
2020-03-09 16:55:13 +01:00
Ghostkeeper
b2e626b020
Update header of Czech translations
It's now in the same format as the rest of the languages.

Contributes to issue CURA-7285.
2020-03-09 16:41:58 +01:00
Ghostkeeper
48aa92e04c
Merge branch '4.5' of https://github.com/DenyCZ/Cura into DenyCZ-4.5 2020-03-09 16:33:42 +01:00
Ghostkeeper
fe8e892568
Give warning if preshrink is larger than wall thickness
If it is larger, it could cause gaps to appear between the walls where infill is exposed.

Contributes to #7231.
2020-03-09 16:07:10 +01:00
Jaime van Kessel
d041131f84
Merge branch 'fix_preheat_fields' of https://github.com/fieldOfView/Cura 2020-03-09 13:02:02 +01:00
Ghostkeeper
466964cf41
Change the sign of comparing against density
Contributes to issue CURA-7287.
2020-03-09 12:48:07 +01:00
Ghostkeeper
287e31554b
Merge branch 'master' into Skin_Edge_Settings 2020-03-09 12:47:13 +01:00
ODUCCEU
1ccf73d11e Add Flying Bear Ghost 4S Printer 2020-03-08 18:37:48 +03:00
Daniel Ciepluch
c96d9e27b8 Strings revisited 2020-03-06 20:44:00 +01:00
Ghostkeeper
c32677d27a
Don't hard-code application name here either
Seems that there are 30-ish places where this is hard-coded in the rest of our code base too. I'm not going to fix all of those.
2020-03-06 15:58:41 +01:00
Jaime van Kessel
68ad38de28
Fix sizing of the machine action dialog
Contributes to #7224
2020-03-06 11:02:59 +01:00
Ghostkeeper
365d1c0f74
Reset 'has responded' state when pressing Add
It's maybe not a good idea to remember this state only in QML. Not changing that now though.

Contributes to issue CURA-7017.
2020-03-05 17:39:57 +01:00
Ghostkeeper
2dcf5a9c97
Fix link to connecting page
Contributes to issue CURA-7017.
2020-03-05 14:01:02 +01:00
Ghostkeeper
25292a4c7c
Add link to help pages if it can't connect
I don't know what the link is supposed to be linking to though. Yet.

Contributes to issue CURA-7017.
2020-03-05 13:16:54 +01:00
Ghostkeeper
0e564abbea
Merge branch 'master' of ssh://github.com/Ultimaker/Cura 2020-03-02 14:14:51 +01:00
Ghostkeeper
4a754a0735
Realign build plate models
Contributes to issue CURA-7270.
2020-03-02 14:11:49 +01:00
Ghostkeeper
c4b060ca48
Merge branch 'dagoma_discoultimate' of https://github.com/0r31/Cura into 0r31-dagoma_discoultimate 2020-03-02 13:38:53 +01:00
fieldOfView
67af1aa19d Fix the positioning of multi-line tooltip anchor-points 2020-02-28 23:00:56 +01:00
fieldOfView
ddbd843d91 Fix showing tooltips for actionbuttons that have a tooltip text set 2020-02-28 22:31:34 +01:00
Jaime van Kessel
670a106957
Be a bit more gracefull when adding a machine failed
This seems to happen for people that manually add machines to cura
but mess something up when copying the files.

CURA-3X
2020-02-28 17:03:38 +01:00