These formulas were using a setting that didn't exist any more.
Not sure how this got through QA. Oh well, this is what they are intending.
This formula is a little bit weird in how it works with support meshes if support is disabled, but it's more or less as good as it gets. The formula is mirrored from how other Ultimaker printers write it down, but slightly simplified with the same outcome.
The DoubleValidator depends on the system locale, requiring users with certain locales to enter floats with a comma instead of a dot (though confusingly floats are always represented with a decimal a dot). Instead of configuring the DoubleValidator with a locale that only accepts decimal dots, this commit uses a RegExpValidator, like other numeric fields in Cura does.
After https://github.com/Ultimaker/Cura/pull/8684 raft_airgap and speed_layer_0 existed twice in some of the quality profiles.
This commit fixes that by removing the old (calculated) values.
Although it is not entirely sure yet, we are fairly certain that libArachne release will have
a setting version of 18, so it is changed by this commit. With this change, the VersionUpgrader
will be properly triggered.
Contributes to CURA-7683 and CURA-7656
Things to note:
* Since there is no VersionUpgrader from 4.8 to 4.9, this versionUpgrader attempts to upgrade
files made in 4.8. This means that it touches files with setting_version = 16.
* The upgrade of the setting_version to 18 is currently commented out because we are not entirely
sure that 18 will be the setting_version in 5.0.
* This versionUpgrader removes the following three settings that were removed in libArachne
* "Compensate Wall Overlaps"
* "Compensate Outer Wall Overlaps"
* "Compensate Inner Wall Overlaps"
* The VersionUpgrader also disabled Fuzzy Skin from any profiles that may have it enabled, as fuzzy
skin currently doesn't work in libArachne.
* The printer definitions have NOT been updated to the new setting_version to avoid having to deal
with an enormous merge conflict in case the setting_version of 5.0 is something other than 18.
* Since the VersionUpgrader does not alter the setting_version, it will run every time Cura starts.
In short, this versionUpgrader runs and removes the deleted settings but it does not really change
the setting_version of any files.
Contributes to CURA-7683 and CURA-7656
Similar to the previous setting Wall Transition Length, but this determines how fast lines come together, which can be faster than the Wall Transition Length.
Contributes to issue CURA-7686.
This is quite a complex setting. Hopefully this helps a bit to understand it. Needs an extensive article in the Settings Guide I'd say!
Done alongside issue CURA-7686.
The draft and ooze shield use the skirt/brim settings to print. So these settings should be adjustable if the draft or ooze shield is enabled. It's a bit weird UX-wise, but it's correct. The UX problem will be tackled later.
Apparently this was already done for the speed/acceleration/jerk settings so no change necessary there.
Contributes to issue #8808.
Two problems with this description:
- It claims that meshes with lower rank override meshes with higher rank. It's the other way around.
- It mentions 'rank' in one sentence and then 'order' in the next. I've corrected this to use the term 'rank' in both sentences for clarity. This is also the term used for the setting label, to be consistent.
Found in issue #8821.
Fuzzy skin needs to be modified to work with the new libArachne toolpaths. Until then, it will
remain unavailable.
Contributes to CURA-7678 via CURA-7876
