Commit graph

23379 commits

Author SHA1 Message Date
Lipu Fei
5149baf593 Fix custom quality fetching
CURA-6913
2019-10-21 09:06:07 +02:00
Lipu Fei
4aadcba01c
Merge pull request #6549 from Ultimaker/CURA-6897_qml_warnings_materials_page
CURA-6897_qml_warnings_materials_page
2019-10-21 08:50:31 +02:00
Ghostkeeper
8cd583ad33
Only show conical support min width if angle is positive
If the angle is 0 or negative, this setting won't have any effect since the support cannot be made wider than it already is using this setting. It can only prevent it from becoming smaller, and it will only become smaller from a positive conical support angle.

Discovered during work on the Settings Guide.
2019-10-21 01:48:01 +02:00
Ghostkeeper
4a5673746c
Remove unused default_value overrides
These are overrides of default_value while there is a value defined. As such these overrides had no effect at all.
Changing them to value can actually change the behaviour of the profile. That is not what the profile author has apparently tested with, so I'm not doing that. I'm just removing the unused data.
In the future if we get new definitions the author gets notified of the error so that he may test more effectively. The legacy can't be fixed without re-testing, so I'm leaving that to the authors.

Done during Turbo Testing & Tooling. I want to go home for the weekend now...
2019-10-18 18:38:16 +02:00
Ghostkeeper
15ea29924a
Sort definition files before testing them
When going through the list of tests for many printers to fix them, it's then easier to go through the failed list. They will appear in the same order as in my IDE. Just a bit of an ease of life thing without any real cost.

Done during Turbo Testing & Tooling.
2019-10-18 17:02:40 +02:00
Ghostkeeper
1d7ad38db2
Also name which setting has the dysfunctional override
So that it's easier to remove it.

Done during Turbo Testing & Tooling.
2019-10-18 17:00:47 +02:00
Ghostkeeper
76b5f9d37b
Fix testing if JSON elements are mappings
Turns out that the JSON objects extend from dict, so this works.
Also turns out that strings have a __getitem__. Who knew?

Done during Turbo Testing & Tooling.
2019-10-18 16:57:57 +02:00
Ghostkeeper
b24dad1563
Merge branch 'master' of ssh://github.com/Ultimaker/Cura 2019-10-18 16:53:08 +02:00
Ghostkeeper
9316df72b3
Add test for overriding default_value while there is a value
This should not be done anywhere since the default_value won't have any effect then. We disregard CuraEngine's command line method here but that's infeasible with those profiles anyway.

Done during Turbo Testing & Tooling.
2019-10-18 16:45:15 +02:00
Remco Burema
25d76aee5a Workaround: Make the type-checker understand what's going on. 2019-10-18 14:46:44 +02:00
Remco Burema
270cb67480 Merge branch 'master' of https://github.com/Ultimaker/Cura 2019-10-18 14:01:20 +02:00
Remco Burema
15bdf0fa1c Change the description of 'Initial Bottom Layers'.
part of CURA-5918
2019-10-18 14:00:16 +02:00
Remco Burema
1885dddf45 Merge branch 'feat_open_top_bottom' of https://github.com/BagelOrb/Cura into BagelOrb-feat_open_top_bottom 2019-10-18 12:55:52 +02:00
Jaime van Kessel
41dbf51e36
Merge branch 'master' of github.com:Ultimaker/Cura 2019-10-18 12:00:03 +02:00
Jaime van Kessel
c7a6fa4a00
Remove fixed override of prime tower position
Now it uses the calculated value from fdm_printer, which is way smarter about it
2019-10-18 11:59:21 +02:00
Ghostkeeper
d0c760d48b
Merge branch 'mb-per-object-setting-check-speedup' of https://github.com/smartavionics/Cura into smartavionics-mb-per-object-setting-check-speedup 2019-10-18 11:27:29 +02:00
Jaime van Kessel
6de7437626
Merge branch 'master' of github.com:Ultimaker/Cura 2019-10-18 10:51:37 +02:00
Jaime van Kessel
0aa2a4994c
Merge branch 'feature_restore_window_geometry' of https://github.com/fieldOfView/Cura 2019-10-18 10:45:28 +02:00
Nino van Hooff
915c8e560c Fix mypy warning 2019-10-18 09:04:00 +02:00
Ghostkeeper
84c9b28bb2
Move maximum resolution itself out of experimental as well
This was forgotten accidentally, it seems.
2019-10-18 00:07:43 +02:00
Mark Burton
82bd89991e Improve code style. 2019-10-17 16:43:07 +01:00
Nino van Hooff
b182830c21 Add tooltips for intent profiles to the Custom Quality panel.
The description is optional.
Tooltip will not show if no description is set

CURA-6853
2019-10-17 17:17:06 +02:00
Nino van Hooff
3709cfa4ed Add tooltips for intent profiles to the Recommended Quality panel.
The description is optional.
Tooltip will not show if no description is set

CURA-6853
2019-10-17 15:54:03 +02:00
Nino van Hooff
664ed4a6a6 Take a more generic approach to safe areas for the SimulationView
Re-implements layer slider positioning

CURA-6853
2019-10-17 12:52:30 +02:00
Mark Burton
f3f9a2393f Return early from _checkStackForErrors() if top container is empty. 2019-10-17 09:21:24 +01:00
Ghostkeeper
ad5fae5b66
Only allow optimising infill travels when combing is enabled
That's the only time when it will have any effect, since the only thing this does is to calculate the distance to the next infill line better if the nozzle has to make a detour due to combing.
2019-10-17 01:29:24 +02:00
Nino van Hooff
8322a36548 Fix some QML warnings in the MaterialsPage 2019-10-16 16:59:52 +02:00
Ghostkeeper
ad2077b76b
Merge branch 'CURA-6801_remove_quality_manager' 2019-10-16 16:18:53 +02:00
Ghostkeeper
87f9c6d7cc
Add typing for MachineNodeMap's constructor
Contributes to issue CURA-6793.

Co-Authored-By: Jaime van Kessel <nallath@gmail.com>
2019-10-16 14:11:29 +00:00
Ghostkeeper
c12817170c
Merge branch 'master' into CURA-6793_performance 2019-10-16 15:47:41 +02:00
Ghostkeeper
8179dfc412
Make cache of machines a protected field
We don't want to use it outside of the mapping. This mapping should be transparent.
We are still using it from our tests though but that's fine. Tests are allowed to touch private fields.

Contributes to issue CURA-6793.
2019-10-16 15:04:07 +02:00
Ghostkeeper
5624f0a8ae
Fix tests with new lazy-loading technique
The new lazy loading requests different functions from the registry so we need to mock that out.
Also fix the manual insertion of things into the lazy-loaded mapping.

Contributes to issue CURA-6793.
2019-10-16 14:59:46 +02:00
Remco Burema
f30f157736
Merge pull request #6504 from Ultimaker/CURA-6864_add_s5_intents
Add UMS5 intent profiles
2019-10-16 14:56:21 +02:00
Ghostkeeper
7348c70af6
Don't get whole container to just get metadata
A performance improvement, especially in the material models.

Contributes to issue CURA-6793.
2019-10-16 13:56:23 +02:00
Ghostkeeper
9b836d95d9
Remove quality, variant and material manager
We don't use them any more and they are deprecated.

Removing them removes a lot of maintenance.

Contributes to issue CURA-6801.
2019-10-16 13:00:38 +02:00
Ghostkeeper
9f84304829
Defensive against missing global qualities
This is just something I encountered. Could be that some profiles got corrupted. In my case, I had a bug in Uranium that I fixed later.

Contributes to issue CURA-6793.
2019-10-16 12:56:05 +02:00
Tim Kuipers
1b383736ab turn off Union overlapping volumes when Surface mode is Surface only 2019-10-16 12:51:05 +02:00
Ghostkeeper
401390209f
Robustness against missing approximate diameter
Pretend like that material doesn't exist then.

Contributes to issue CURA-6793.
2019-10-16 10:59:58 +02:00
Lipu Fei
86ff7443cf Fix QML undefined errors 2019-10-16 10:36:36 +02:00
Nino van Hooff
ac8a7d4aeb Add whitespace between plugin name and licence string in license dialog 2019-10-16 09:44:09 +02:00
Lipu Fei
ae6f0eb77e Re-fix quality model update
CURA-6883
2019-10-15 15:55:21 +02:00
Lipu Fei
d350c9e3d9 Update quality and intent models when extruders get changed
CURA-6894
2019-10-15 15:53:55 +02:00
Ghostkeeper
f93f26444b
Revert "Fix QualityManagementModel update"
This reverts commit fe8b7a48e6.

This commit caused Cura to crash when creating a custom quality profile.

Contributes to issue CURA-6883.
2019-10-15 15:33:41 +02:00
Ghostkeeper
c875252b53
Fix some mistakes indicated by PyCharm's linting 2019-10-15 15:27:58 +02:00
Lipu Fei
59fa73448a Fix material diameter change
CURA-6868
2019-10-15 15:03:35 +02:00
Ghostkeeper
ce4c5a1c93
Remove unnecessary listening to switching extruder tabs
Also fix unnecessary emitting of switching extruder tabs.

This should improve performance a lot. I tested a lot of things and am convinced that it didn't break anything. But the automated GUI tests and QA team should be the final arbiters of that...

Contributes to issue CURA-6793.
2019-10-15 15:01:45 +02:00
Lipu Fei
d105150f53
Merge pull request #6533 from Ultimaker/CURA-6863_duplicated_material_oddness
CURA-6863 duplicated material oddness
2019-10-15 15:00:55 +02:00
Lipu Fei
0af8bd5e94 Fix merge conflicts 2019-10-15 15:00:03 +02:00
Nino van Hooff
e15952b25e Merge remote-tracking branch 'origin/master' 2019-10-15 14:37:52 +02:00
Nino van Hooff
845cab5573 Clarified comment for duplicating materials 2019-10-15 14:37:37 +02:00