Commit graph

31424 commits

Author SHA1 Message Date
digitalfrost
54b9ed97ae Use is not operator rather than not ... is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-08 10:04:46 +02:00
digitalfrost
ff07129f2c Use is not operator rather than not ... is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-08 10:04:46 +02:00
digitalfrost
06e61a3129 Use is not operator rather than not ... is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-08 10:04:46 +02:00
digitalfrost
72751b2507 Use is not operator rather than not ... is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-08 09:36:53 +02:00
digitalfrost
0f0815efab Use is not operator rather than not ...is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-08 09:33:26 +02:00
digitalfrost
d65e198e8c Use is not operator rather than not ...is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-08 09:28:26 +02:00
digitalfrost
2f9e5b00bb Use is not operator rather than not ... is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-07 10:09:33 +02:00
Anson Liu
c7946e5c78
Added Cooling Rate setting 2022-08-06 16:54:37 -04:00
Anson Liu
38b04b0a4d
Merge branch 'Ultimaker:main' into master 2022-08-06 16:53:48 -04:00
Remco Burema
81a34d1d18
Merge pull request #12692 from Ultimaker/PP-187_move_shrinkage_compensation_values_to_fdm_materials
Removed shrinkage compensation from the quality profiles. They have b…
2022-08-06 11:07:35 +02:00
Remco Burema
5b851e4630 Click on checkbox only for checkbox-setting.
People accidentally set (checkbox) settings when mis-clicking slightly when scrolling through the settings.

CURA-9530
2022-08-05 13:33:50 +02:00
digitalfrost
1c3479c9fc Refactor check for unknown line types
Using .where()  clarifies the intent.
2022-08-05 11:08:20 +02:00
digitalfrost
9ac7eb4da7 Use enumerate to iterate over self._types
This is more pythonic.
The comparaison in the if block below the for loop now becomes clearer.
2022-08-05 10:37:02 +02:00
j.spijker@ultimaker.com
3c9d38ebd4 First Update and upgrade on Linux
hoping this will solve the libegl-mesa not being able to download on the GH 22.04 runner
2022-08-04 23:29:40 +02:00
digitalfrost
a39fed1dc3 Use one line conditional assignment
Use one line conditional assignement instead of if else block.
The intent is now clearer and the code is easier to read.
2022-08-04 09:45:47 +02:00
j.spijker@ultimaker.com
c1ae1872d0 Make sure build and generate steps are present
Contributes to CURA-8831
2022-08-03 17:49:13 +02:00
j.spijker@ultimaker.com
ae7023b2db Create the package
Contributes to CURA-8831
2022-08-03 17:10:53 +02:00
j.spijker@ultimaker.com
cc329955f0 Just do an actual create
Contributes to CURA-8831
2022-08-03 17:02:50 +02:00
j.spijker@ultimaker.com
7bd90d21ab First do a build
Contributes to CURA-8831
2022-08-03 16:59:01 +02:00
j.spijker@ultimaker.com
15e1d063d8 Also create the generator folder
Contributes to CURA-8831
2022-08-03 16:51:54 +02:00
j.spijker@ultimaker.com
2845b9a42b Export-pkg requires a build dir
Contributes to CURA-8831
2022-08-03 16:11:50 +02:00
j.spijker@ultimaker.com
145194cc25 Only export-pkg on Linux
No need for bins and therefor different OSes

Contributes to CURA-8831
2022-08-03 15:51:03 +02:00
j.spijker@ultimaker.com
4e31b4328c Treat it as bool
Contributes to CURA-8831
2022-08-03 15:49:35 +02:00
digitalfrost
fad47856e4 Rename _start_time to _check_start_time
This better reflects what _start_time is and makes the code easier
to read. _check_start_time is  self documenting.
The current comment next to _start_time is erroneous
since _start_time is not "measuring the checking time"
2022-08-03 11:40:15 +02:00
digitalfrost
556b009a9d Fix Bug in timing MachineErrorChecker execution
We want the Logger in line 215 to give the execution time in seconds
so we don't want the start time to be the epoch.
Currently the logger will output something like
time = 1659518458.5s
not like
time = 3.0s
2022-08-03 11:26:39 +02:00
j.spijker@ultimaker.com
cf548613ca Add cura env to Run environments
Contributes to CURA-8831
2022-08-03 08:51:41 +02:00
j.spijker@ultimaker.com
f95b22404a fix base_dir for venv when running from source
Contributes to CURA-8831
2022-08-03 08:51:41 +02:00
j.spijker@ultimaker.com
e4feae414b Build pyarcus and pysavitar shared
Contributes to CURA-8828, CURA-8829 and CURA-8831
2022-08-03 08:51:41 +02:00
j.spijker@ultimaker.com
de9d432398 Use new pysavitar as package
Contributes to CURA-8828, CURA-8829 and CURA-8831
2022-08-02 15:47:17 +02:00
j.spijker@ultimaker.com
76b2984426 Use new pynest2d package
Contributes to CURA-8828, CURA-8829 and CURA-8831
2022-08-02 12:56:25 +02:00
digitalfrost
cba2e07adc
Remove extra spaces 2022-08-02 09:08:46 +02:00
digitalfrost
b13b7a892d Move _error_check_timer initialization to a separate function
This simplifies understanding the class __init__ function
2022-08-02 08:55:17 +02:00
j.spijker@ultimaker.com
a7b1052b27 Use the latest pyarcus dependency
Since we split of Arcus and pyArcus into separate repo's

Contributes to CURA-8824 and CURA-8831
2022-08-01 16:11:51 +02:00
Jelle Spijker
7b768ca810
Merge pull request #12866 from Ultimaker/CURA-9220_hide_if_no_permission
Hide cloud interaction buttons if the user has no permissions to them
2022-08-01 12:41:11 +02:00
Jelle Spijker
405baea1ae
Merge pull request #12898 from Ultimaker/CURA-9520_warning_line_density_children
Don't show warning color for children of support_infill_rate when using tree support
2022-08-01 12:37:59 +02:00
j.spijker@ultimaker.com
d1e8ae1ca7 Fix curapackage intent and intents mappings
Contributes to SD-3871 and CURA-7667
2022-08-01 11:16:48 +02:00
Ghostkeeper
8a55a2aff6
Further review suggestions
Contributes to issue CURA-9220.
2022-08-01 10:49:29 +02:00
Ghostkeeper
84cf72d58f
Document shortcoming of isMine check
Contributes to issue CURA-9220.
2022-08-01 10:49:29 +02:00
Ghostkeeper
da289b51d0
Deprecate additionalRights property
Consumers should now use the permissions system which gets the permissions from the account via a separate API call.

Contributes to issue CURA-9220.
2022-08-01 10:49:29 +02:00
Ghostkeeper
7c1a254812
Add newlines before properties
As suggested in the code review.

Contributes to issue CURA-9220.

Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-08-01 10:47:57 +02:00
digitalfrost
cfeab2e6c0 Use dataclasses for Peripheral
Since Peripheral is a data class use dataclasses
2022-07-31 11:46:03 +02:00
j.spijker@ultimaker.com
5a8047e7d9 Don't show warning color for children of support_infill_rate when using tree support
CURA-9520 PPM: Tree support has infill density 15%, but should have 0%
2022-07-29 18:04:49 +02:00
Ghostkeeper
9bb3b1a375
Merge branch 'CURA-9031_add_slice_id_to_griffin_gcode_header' 2022-07-29 16:02:39 +02:00
Ghostkeeper
a0f640586c
Add slice ID to example data
Contributes to issue CURA-9031.
2022-07-29 15:57:10 +02:00
Jelle Spijker
c27cee8a72
Merge pull request #12878 from Ultimaker/CURA-9520_Fix_support_infill_tree_support
CURA-9520_Fix_support_infill_tree_support
2022-07-29 12:32:43 +02:00
j.spijker@ultimaker.com
6df721eb7a Don't use conan 1.51.0
Conan 1.51.0 seems to have bug in the MSBuild generator, used on Windows
2022-07-29 12:17:01 +02:00
j.spijker@ultimaker.com
d9e3e4d395 Made slice_uuid a public field
Contributes to CURA-9031
2022-07-29 12:13:12 +02:00
Ghostkeeper
d27ed71518
Increase maximum integer length to 12 characters
This may cause overflows if the integer type is 32-bit, but we tend to use 64-bit anyway. And 9,999,999 was already an overflow too.

Fixes #12859.
2022-07-29 10:30:25 +02:00
digitalfrost
b8f448a359
Add link to style guide
Add link to the document that describes the code conventions and guidelines to be followed in all Ultimaker code, regardless the programming environment / language.
This document is located in the Ultimaker/Meta repo.
2022-07-28 11:18:16 +02:00
j.spijker@ultimaker.com
fdad2590da Switch to macos-11
This will drop support for MacOS 10.15 and lower, which will be deprecated
within the next 3 months or so. But the GH hosted runners have dropped support
for this already.

https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/
2022-07-28 10:44:55 +02:00