Commit graph

8977 commits

Author SHA1 Message Date
Arjen Hiemstra
5892f13349 Fix naming of definitionChanges property in test 2017-03-27 17:55:44 +02:00
Arjen Hiemstra
da751fa0ea We raise InvalidContainerError, not KeyError when a container was not found 2017-03-27 17:55:24 +02:00
Arjen Hiemstra
270cdd08cb Don't modify ContainerStack._containerRegistry property
We do not use it in GlobalStack
2017-03-27 17:54:44 +02:00
Arjen Hiemstra
385d8ac5b5 Properly mock Container and ContainerRegistry objects in Global stack test 2017-03-27 17:53:30 +02:00
Arjen Hiemstra
b6fafb06ed Ensure we initialize the list of containers for GlobalStack 2017-03-27 17:52:38 +02:00
Arjen Hiemstra
39803cf7dd Add missing imports to Extruder/GlobalStack 2017-03-27 17:52:16 +02:00
Ghostkeeper
2810054f8e
Fix spelling of maximum skin angle expansion description 2017-03-27 16:00:09 +02:00
Lipu Fei
50266f760b
Revert "Prevent MachineSettings dialog go beyond the top of screen"
This reverts commit a0f841e8eb.
2017-03-27 16:00:08 +02:00
Jack Ha
efa1513e4c
Changed all Not Supported Draft quality profiles to Not Supported Superdraft to prevent double Not Supported entries. CURA-3555 2017-03-27 16:00:08 +02:00
Ghostkeeper
b67b41653f
Fix spelling of maximum skin angle expansion description 2017-03-27 15:59:27 +02:00
Jaime van Kessel
88704051d1 Filter bar is now always visible
CURA-3574
2017-03-27 15:47:30 +02:00
Lipu Fei
6644a4d386 Revert "Prevent MachineSettings dialog go beyond the top of screen"
This reverts commit a0f841e8eb.
2017-03-27 11:09:40 +02:00
Jack Ha
088202c366 Changed all Not Supported Draft quality profiles to Not Supported Superdraft to prevent double Not Supported entries. CURA-3555 2017-03-27 10:30:51 +02:00
Arjen Hiemstra
5196ea695c Add a notify signal to all container properties in GlobalStack
Contributes to CURA-3497
2017-03-27 01:35:34 +02:00
Arjen Hiemstra
dd8ea6175c Add properties for user changes etc. to ExtruderStack 2017-03-27 01:32:36 +02:00
fieldOfView
67d66905ba Fix crash when editing material diameter
While editing the diameter value in the materials pane, it can happen that the radius evaluates to 0. This led to a division by zero.

Fixes https://github.com/Ultimaker/Cura/issues/1582
2017-03-26 14:08:07 +02:00
fieldOfView
2b761b87ac Fail gracefully when libSavitar is not found
By catching the ImportError, this prevents the logs being clogged with exceptions in start and when the plugins preference page is touched.
2017-03-25 09:56:02 +01:00
Ghostkeeper
ccd22ef36d
Add tests for setting property on other parts of extruder stack
It then asks the property back and sees if it was changed.

Contributes to issue CURA-3497.
2017-03-24 17:55:21 +01:00
Ghostkeeper
129f01aa24
Add tests for setting property on user changes of extruder stack
Setting a property directly should put it in the user changes.

Contributes to issue CURA-3497.
2017-03-24 17:52:53 +01:00
Ghostkeeper
fe95755f75
Add tests for setVariantById
One for when the ID exists, and one for when it doesn't.

Contributes to issue CURA-3497.
2017-03-24 17:50:14 +01:00
Ghostkeeper
a5d91139ef
Add tests for setQualityChangesById
One for when the ID exists, and one for when it doesn't.

Contributes to issue CURA-3497.
2017-03-24 17:49:14 +01:00
Ghostkeeper
393ee7838a
Add tests for setQualityById
One for when the ID exists, and one for when it doesn't.

Contributes to issue CURA-3497.
2017-03-24 17:48:27 +01:00
Ghostkeeper
eb7035db45
Add tests for setMaterialById
One for when the ID exists, and one for when it doesn't.

Contributes to issue CURA-3497.
2017-03-24 17:46:59 +01:00
Ghostkeeper
e4952ac8c5
Add tests for setDefinitionById
One for when the ID exists, and one for when it doesn't.

Contributes to issue CURA-3497.
2017-03-24 17:44:22 +01:00
Ghostkeeper
78e78ac147
Add test for settings behaving like a stack
The stack order is very fixed here. Is that bad?

Contributes to issue CURA-3497.
2017-03-24 17:40:41 +01:00
Ghostkeeper
2936b9bf24
Fail deserialize test if missing container doesn't raise an exception
If it raised an exception, we were checking whether it was the proper exception. But if it wasn't raising an exception we weren't checking anything. That's fixed now (and the header of the function is improved a bit too).

Contributes to issue CURA-3497.
2017-03-24 17:37:23 +01:00
Ghostkeeper
7913ff9bf2
Add test for deserializing with a missing container
A container is missing in the registry, so it should raise an exception.

Contributes to issue CURA-3497.
2017-03-24 17:35:31 +01:00
Ghostkeeper
69c53dcd73
Add test for constraining container types to certain slots
Only the definition slot must hold a definition container. All the rest must hold an instance container. This fails currently because the properties don't even exist.

Contributes to issue CURA-3497.
2017-03-24 17:32:33 +01:00
Ghostkeeper
e3932cb21c
Document deserialize test cases
Contributes to issue CURA-3497.
2017-03-24 17:27:46 +01:00
Ghostkeeper
ccb9c07909
Align parameters of material deserialising test
For readability.

Contributes to issue CURA-3497.
2017-03-24 17:24:35 +01:00
Ghostkeeper
e09f41e485
Add tests for deserialising extruders with definitions
All extruders have definitions, but this one specifically tests whether the ID is correct.

Contributes to issue CURA-3497.
2017-03-24 17:23:56 +01:00
Ghostkeeper
df2ae12ca9
Add tests for deserialising extruders with variants
Contributes to issue CURA-3497.
2017-03-24 17:21:47 +01:00
Ghostkeeper
bbd0ca7b9f
Add tests for deserialising extruders with material
Contributes to issue CURA-3497.
2017-03-24 17:17:41 +01:00
Ghostkeeper
9cb7c30fcb
Add tests for deserialising extruders with quality
Only the greatest extruders with actual quality are deserialised...

Contributes to issue CURA-3497.
2017-03-24 17:13:32 +01:00
Ghostkeeper
71a946d1b9
Add tests for deserialising extruders with quality changes
Contributes to issue CURA-3497.
2017-03-24 17:08:34 +01:00
Ghostkeeper
91814a827b
Line up parameters of test cases
Better oversight.

Contributes to issue CURA-3497.
2017-03-24 17:05:06 +01:00
Ghostkeeper
73326ae53d
Extruders don't have definition changes
So remove them from our test extruder stacks.

Contributes to issue CURA-3497.
2017-03-24 17:03:29 +01:00
Ghostkeeper
dea86ca535
Add tests for deserialising a stack with user changes
Code is mostly copied over from the global stack, which should work in a similar way.

Contributes to issue CURA-3497.
2017-03-24 16:57:48 +01:00
Jaime van Kessel
f04d1efb8d Removed file progress from removable output device, as writefile job now handles that itself 2017-03-24 16:32:39 +01:00
Ghostkeeper
e881465050
Add delimiter between global stuff and test cases
Helps provide some oversight since this module is about to explode in size.

Contributes to issue CURA-3497.
2017-03-24 16:31:57 +01:00
Ghostkeeper
14ac41e58f
Add tests for setQualityChangesById
One for when the ID exists, one for when it doesn't exist.

Contributes to issue CURA-3497.
2017-03-24 16:24:27 +01:00
Ghostkeeper
498956a190
Add tests for setQualityById
One for when the ID exists, one for when it doesn't exist.

Contributes to issue CURA-3497.
2017-03-24 16:19:47 +01:00
Ghostkeeper
d9ba848dc8
Add tests for setMeterialById
One for when the ID exists, one for when it doesn't exist.

Contributes to issue CURA-3497.
2017-03-24 16:15:50 +01:00
Ghostkeeper
3e437074ae
Sort tests better
Alphabetically.

Contributes to issue CURA-3497.
2017-03-24 16:01:56 +01:00
Ghostkeeper
dbc4a90e10
Add tests for setDefinitionChangesById
One for when the ID exists, one for when it doesn't exist.

Contributes to issue CURA-3497.
2017-03-24 16:00:55 +01:00
Ghostkeeper
928181507d
Add tests for setDefinitionById
One for when the ID exists, one for when it doesn't exist.

Contributes to issue CURA-3497.
2017-03-24 15:58:32 +01:00
Ghostkeeper
f29d5e897c
Add tests for setVariantById
One for when the ID exists, one for when it doesn't exist.

Contributes to issue CURA-3497.
2017-03-24 15:55:01 +01:00
Ghostkeeper
72bbb8ec0c
Also test whether adding an extruder had any effect on the extruder list
Contributes to issue CURA-3497.
2017-03-24 15:46:29 +01:00
Ghostkeeper
55dd17cae7
Add tests for changing properties on specified containers
Other than just user, that is.

Contributes to issue CURA-3497.
2017-03-24 15:42:05 +01:00
Ghostkeeper
319fd929d8
Add test for setProperty to set properties on user changes
Contributes to issue CURA-3497.
2017-03-24 15:34:31 +01:00