Commit graph

2094 commits

Author SHA1 Message Date
Lipu Fei
98eed89686 Remove global changed check that prevents signal emit
CURA-5157
2018-03-27 14:32:40 +02:00
Ghostkeeper
013bb04a7d
Show configuration error if finding definition to add wasn't found
It must've gotten this ID from somewhere.

Contributes to issue CURA-5045.
2018-03-27 14:32:13 +02:00
Ghostkeeper
544c2c69b4
Remove unused imports
Contributes to issue CURA-5045.
2018-03-27 14:30:48 +02:00
Jack Ha
ca4cb419ff CURA-5157 prevent some startup crash after upgrading from 2.7 2018-03-27 14:08:12 +02:00
Jack Ha
04a135e6a3 CURA-5157 renamed extruder to position in addExtruderStackForSingleExtrusionMachine, fixes loading some upgrades from 3.0 2018-03-27 13:04:05 +02:00
Ghostkeeper
1aea5356b6
More early out if no global stack
This prevents all sorts of crashes on start-up, instead causing no active printer to appear and the add printer wizard to show up.

Contributes to issue CURA-5045.
2018-03-27 09:43:37 +02:00
Ghostkeeper
f2c8d8756e
Don't emit changed signals if the global stack ID doesn't exist
Because nothing will change then.

This is equivalent to putting the call to self.__emitChangedSignals() in the if-statement. But I switched the condition of the if-statement around because it looks more like error handling to me. This is the main case.

Contributes to issue CURA-5045.
2018-03-27 09:41:14 +02:00
Ghostkeeper
75e993eb60
Don't crash when updating material list without global container
There is nothing to update then.

Contributes to issue CURA-5045.
2018-03-27 09:39:10 +02:00
Ghostkeeper
d74c1e0d7a
Don't crash if getting container changed signals before global stack
Just don't get any signals. This function should be called again if the global container changed anyway.

Contributes to issue CURA-5045.
2018-03-27 09:29:41 +02:00
Ghostkeeper
bd4aba2572
Return empty extruder list if no global stack
Just about every call of this function (except 2) would break when this returns None. The signature also says it doesn't return None. Let's return an empty list instead.

Contributes to issue CURA-5045.
2018-03-27 09:28:19 +02:00
Ghostkeeper
6d3fed8f52
Allow getContainer() to return None
And in the rest of the locations we must then check if it's None and handle that gracefully.
Here we assume that the getContainer message shows a message to the user if necessary. For now we'll just log it.

Contributes to issue CURA-5045.
2018-03-26 15:48:03 +02:00
Jack Ha
c7a3d33411 CURA-5138 generate unique name for each per object setting container, fix per object settings being lost when multiplying 2018-03-26 11:20:35 +02:00
Lipu Fei
fd2abdd9fb
Merge pull request #3507 from guillemavila/Copy-all-values-to-all-extruders
add Copy all values to all extruders
2018-03-22 16:16:30 +01:00
Guillem
fecbf82551 Replace all user changed values
Removed check to change the values only if they were different
2018-03-22 15:49:30 +01:00
Guillem
01ec20f5ce Fixed docs, removed todo, changed way to get extruder stacks, slightly faster 2018-03-22 11:39:42 +01:00
Jack Ha
a2b03a2ac1 CURA-4400 fix setting extruders_enabled_count so print_sequence for Custom FDM printer is available again 2018-03-20 13:30:48 +01:00
Ian Paschal
d7b0f11ddf CURA-4400 Fixed project loading
"enabled" metadata is now read from saved projects (.3mf)
2018-03-20 11:17:39 +01:00
Diego Prado Gesto
51e7a18d1c Add high level functions for setting the variant, material and quality
using the name, id and quality_type respectively.
2018-03-19 17:25:49 +01:00
Guillem
faf8ed3ba6 Replace only user changed values
removed machine_settings and settable_per_extruder_check. Not needed.
2018-03-19 14:57:31 +01:00
Guillem
18fba5b529 Avoid replacing machine_settings and not settable_per_extruder settings 2018-03-19 14:21:45 +01:00
Lipu Fei
b13bfaa8e1 Rename setVariantGroup() -> setVariant()
There is no such thing as VariantGroup.
2018-03-19 12:27:15 +01:00
Lipu Fei
4a0b3ace9e Fix missing getExtruderPositionValueWithDefault() error
PerObjectContainerStack was not a PerObjectContainerStack so it didn't
have getExtruderPositionValueWithDefault(), and this will break SliceInfo.
2018-03-19 12:23:42 +01:00
Jack Ha
906ebe12e1 CURA-4400 fix disallowed areas by fixing the limit_to_extruder -1 value 2018-03-19 11:46:43 +01:00
Jack Ha
8f6f56a5e6 Merge branch 'master' of github.com:Ultimaker/Cura 2018-03-19 10:56:49 +01:00
Jack Ha
bd775cf32e CURA-4400 fix support_extruder_nr values in overhang angle and SliceInfo 2018-03-19 10:56:40 +01:00
Lipu Fei
7bf8e399ff Should always reslice upon settings changed
CURA-5115

When we switch a model from "support mesh" for example to "normal",
there will be no setting values in the per-object settings container,
but we should still trigger a reslice because settings have been changed.
2018-03-19 09:45:31 +01:00
Lipu Fei
2aaaf106b4 Fix update material in MachineManager
CURA-5098
2018-03-16 15:05:37 +01:00
Lipu Fei
ee4a6dc704 Always show confirm dialog upon material diameter change 2018-03-16 13:21:51 +01:00
Diego Prado Gesto
aa8d91faf6 Merge branch 'master' of github.com:Ultimaker/Cura 2018-03-16 10:58:56 +01:00
Diego Prado Gesto
06d028652d CURA-4870 Change code style 2018-03-16 10:58:31 +01:00
Lipu Fei
a115956575 Do not show a material itself in its linked material list 2018-03-16 10:40:16 +01:00
Diego Prado Gesto
99d653cea5 CURA-4870 Don't allow to connect more than one instance to the same
group.
2018-03-15 20:01:47 +01:00
Lipu Fei
f14ddb8711 Fix reset to default quality 2018-03-15 17:09:13 +01:00
Lipu Fei
3bb0a481f1 Simplify default quality reset 2018-03-15 17:01:05 +01:00
Jack Ha
8af82cc3f4 CURA-4400 prevent disabling last enabled extruder 2018-03-15 15:54:44 +01:00
Lipu Fei
08f43f6b2e Fix profile ordering in profile importing
CURA-5054
2018-03-15 15:27:47 +01:00
Diego Prado Gesto
b44f32ad1d Merge branch 'master' of github.com:Ultimaker/Cura 2018-03-15 15:14:40 +01:00
Diego Prado Gesto
dcb68bb33e CURA-4870 Move the checkCorrectGroupName to the machine manager, where
it must belong to.
2018-03-15 15:13:35 +01:00
Jack Ha
1dba5629f7 Merge branch 'master' of github.com:Ultimaker/Cura 2018-03-15 15:00:22 +01:00
Jack Ha
05cd937df3 CURA-4400 optional_extruders cannot be set to disabled extruders anymore 2018-03-15 15:00:13 +01:00
Diego Prado Gesto
1e9a1f2668 Merge branch 'master' of github.com:Ultimaker/Cura 2018-03-15 14:48:43 +01:00
Diego Prado Gesto
cbe929242e CURA-4870 Update the names of the groups in the container stacks when
there is temporary name after upgrading from 3.2
2018-03-15 14:44:01 +01:00
Lipu Fei
1f2602a2f4 Move SettingVisibilityPresetsModel to Machines.Models
CURA-5088
2018-03-15 14:41:34 +01:00
Diego Prado Gesto
15ff4045bf CURA-4870 When removing a network connected printer, also remove all the
other machines that were (possibly) created in the background so that
there is no orphan containers.
2018-03-15 11:02:29 +01:00
Diego Prado Gesto
2fdd51fc23 CURA-4870 Bind the network information with the output devices changed
signal.
2018-03-14 16:47:01 +01:00
Lipu Fei
22573a685d Fix quality definition comparison in quality importing
CURA-4946
2018-03-14 14:31:30 +01:00
Lipu Fei
0655ef0bc5 Fix quality profile import
CURA-4946
2018-03-14 14:22:46 +01:00
Lipu Fei
191faaba19 Fix machine definition in quality importing
CURA-4946
2018-03-14 13:49:16 +01:00
Ian Paschal
05c59ddaa7 CURA-4946 Handle gcode with wrong quality definition
Some gcode has its quality definition set to, say, UM2 extended, which is _actually_ just UM2 gcode. Thus, we check if the definition in the profile matches the current machine or what it in theory should be, either one being valid. See comments in code for details.
2018-03-14 13:29:48 +01:00
Lipu Fei
984e6ddd08
Merge pull request #3274 from fieldOfView/feature_setting_visibility_profiles
Setting Visibility Presets sidebar menu
2018-03-14 13:25:59 +01:00