Commit graph

3189 commits

Author SHA1 Message Date
Ghostkeeper
2fdfdaa00b
Rename iconOnRightSide to isIconOnRightSide
More accurately represents the type of value that's in this property.

Contributes to issue CURA-5876.
2018-12-04 14:47:34 +01:00
Ghostkeeper
ef29fb0cfa
Remove unnecessary item wrapper
Contributes to issue CURA-5876.
2018-12-04 14:44:12 +01:00
Ghostkeeper
2dde2438b2
Remove unnecessary anchors
Contributes to issue CURA-5876.
2018-12-04 14:38:13 +01:00
Ghostkeeper
347240410a
Use enumeration to check and switch state of configuration menu
Instead of a string. This is a bit more restrictive.

Contributes to issue CURA-5876.
2018-12-04 14:35:28 +01:00
Ghostkeeper
7cc1f021c1
Fix right-alignment of configuration items in list
The scrollbar will go on top of it now, but it looks nicer if you don't scroll. Maybe we have to make it adaptable?

Contributes to issue CURA-5876.
2018-12-04 14:25:58 +01:00
Ghostkeeper
759b5b5847
Use anchors rather than a calculation with padding
It's supposed to be slightly more efficient.

Contributes to issue CURA-5876.
2018-12-04 14:23:41 +01:00
Ghostkeeper
801701623e
Remove unnecessary top anchor in first subitem of item
It already gets aligned to the top anyway.

Contributes to issue CURA-5876.
2018-12-04 14:04:07 +01:00
Ghostkeeper
a1f579a528
Improve wording of iconOnRightSide documentation
Contributes to issue CURA-5876.
2018-12-04 14:01:49 +01:00
Jaime van Kessel
9b8b91b6a4
More specific variable type for is_connected
Contributes to issue CURA-5876.

Co-Authored-By: Ghostkeeper <Ghostkeeper@users.noreply.github.com>
2018-12-03 17:34:08 +01:00
Ghostkeeper
65d3aa4480
Fix broken sizes due to merged theme entry
Merge conflict went wrong, I think.

Contributes to issue CURA-5876.
2018-12-03 11:59:03 +01:00
Ghostkeeper
c8cb3a094a
Re-use SecondaryButton instead of setting colours ourselves
It has a pre-defined theme.

Contributes to issue CURA-5876.
2018-12-03 11:52:10 +01:00
Ghostkeeper
7df4c01814
Merge branch 'ui_rework_4_0' into CURA-5876-Configuration_dropdown
Conflicts:
	cura/Settings/MachineManager.py -> rowCount vs. count
	resources/qml/ExtruderIcon.qml -> Someone changed stuff that I had overwritten.
	resources/qml/Menus/ConfigurationMenu/PrintCoreConfiguration.qml -> Someone changed stuff that I had removed.
	resources/qml/Toolbar.qml -> Git was wrong, not a conflict.
	resources/themes/cura-light/theme.json -> Git was wrong, not a conflict.
2018-12-03 11:45:05 +01:00
Ghostkeeper
39411222da
Use normal font size for Auto slicing... message
It should've been the normal font size anyway. This is not small!

Contributes to issue CURA-5876.
2018-12-03 11:37:22 +01:00
Ghostkeeper
af747ae09c
Don't hide tab bar when disabling all but one extruder
And make sure the checkbox for enabling also disappears.
We don't want to make this dependent on the number of enabled extruders, but on the total number of extruders. This way you can actually re-enable an extruder again because the tab bar shouldn't disappear.

Contributes to issue CURA-5876.
2018-12-03 11:19:25 +01:00
Ghostkeeper
6012ea0b9e
Don't use QtQuick imports from Qt 5.11
Our build system uses 5.10.

Contributes to issue CURA-5876.
2018-12-03 11:15:11 +01:00
Ghostkeeper
f3af5a72ad
Use ListModel.count instead of rowCount
The .count property properly updates when the model is changed.

Contributes to issue CURA-5876.
2018-12-03 11:13:26 +01:00
Lipu Fei
c688f0ea88
Merge pull request #4864 from Ultimaker/CURA-5943_ui_usb_printing
Cura 5943 ui usb printing
2018-12-03 10:42:58 +01:00
Ghostkeeper
db05d7853a
Remove background colour from tab window
The colour is the same as what is behind it anyway.

Contributes to issue CURA-5876.
2018-12-03 09:04:35 +01:00
Ghostkeeper
82e66eeaa1
Remove tabs and lining with single-extruder printers
There's no sense in showing tabs if the user can't use them.

Contributes to issue CURA-5876.
2018-12-03 09:02:41 +01:00
Diego Prado Gesto
e73a91e746 Merge branch 'master' into ui_rework_4_0 2018-12-02 12:11:12 +01:00
Ghostkeeper
0a6e420710
Make active tab white
Contributes to issue CURA-5876.
2018-11-30 17:05:25 +01:00
Jaime van Kessel
6ab2ce7690 Decrease padding between time & material specification headers 2018-11-30 16:44:55 +01:00
Ghostkeeper
d5d49fcec8
Disable extruder enabled checkbox if it's the last one
You can't disable the last extruder.

Contributes to issue CURA-5876.
2018-11-30 16:43:48 +01:00
Ghostkeeper
82d4897ba4
Use MouseArea to catch click instead of onClicked
This is necessary because when you click it, the 'checked' property no longer depends on the active extruder. So prevent it from being clicked at all and handle the click separately in this MouseArea.

Contributes to issue CURA-5876.
2018-11-30 16:18:46 +01:00
Jaime van Kessel
ad26962cb9 Fix setting visibility not working in settingVisibilityPage
CURA-5981
2018-11-30 15:49:50 +01:00
Ghostkeeper
ed37e692a3
Don't disable enable checkbox before machine is loaded
It is unnecessary because you can't see it or click on it before adding a machine.

Contributes to issue CURA-5876.
2018-11-30 15:45:04 +01:00
Ghostkeeper
ede50ef3ca
Simplify dependencies on activeStack
The properties, being formulas, were not properly updated when the active stack changed.

Contributes to issue CURA-5876.
2018-11-30 15:44:15 +01:00
Ghostkeeper
1d9a13cac2
Reset tab index when repeater's model is rebuilt
We can't prevent the model from being rebuilt. At least, not without a major refactor.

Contributes to issue CURA-5876.
2018-11-30 15:40:59 +01:00
Jaime van Kessel
384c359db1 Merge branch 'master' of github.com:Ultimaker/Cura into ui_rework_4_0 2018-11-30 15:34:47 +01:00
Jaime van Kessel
a4a619370e Fix QML warnings 2018-11-30 15:33:57 +01:00
Jaime van Kessel
205b939b99 Merge branch 'remove_transitions' of github.com:Ultimaker/Cura 2018-11-30 15:30:53 +01:00
Ghostkeeper
e93bbf07a4
Fix circular dependency with tab index and active stack
Only when actually clicking the tab should it change the active extruder index; not when the current index is changed for any other reason.
Next up: Don't change the current index for any other reason.

Contributes to issue CURA-5876.
2018-11-30 14:53:10 +01:00
Jaime van Kessel
59a81be65c Fixed some leftover graphical issues
CURA-5943
2018-11-30 14:10:42 +01:00
Jaime van Kessel
6d4a460e58 Move USB sidebar into the main view of the monitorstage
CURA-5943
2018-11-30 13:53:53 +01:00
Lipu Fei
6db52dde46 Fix merge conflicts from ui_rework_40
CURA-5943
2018-11-29 15:27:06 +01:00
Lipu Fei
5df7cdde48 Merge remote-tracking branch 'origin/master' into ui_rework_4_0 2018-11-29 08:54:22 +01:00
Jaime van Kessel
d9c3faaae2 Codestyle
CURA-5879
2018-11-28 11:19:37 +01:00
Jaime van Kessel
d09d8a6ae3 Minor codestyle fixes
CURA-5879
2018-11-28 11:18:36 +01:00
Jaime van Kessel
1d013dc1e7
Merge pull request #4893 from Ultimaker/fix_toolbar_style
Fix toolbar style
2018-11-28 10:47:05 +01:00
Jaime van Kessel
bfa2ff5f5e Invert visibility of bottom & topsquare
It got derped.
2018-11-28 10:46:07 +01:00
Jaime van Kessel
d0da70a7ee
Change visibility of the rectangle
CURA-5984

Co-Authored-By: diegopradogesto <d.pradogesto@ultimaker.com>
2018-11-28 10:29:53 +01:00
Jaime van Kessel
454b47e3a0
Change visibility behavior of the rectangle
CURA-5984

Co-Authored-By: diegopradogesto <d.pradogesto@ultimaker.com>
2018-11-28 10:29:35 +01:00
Jaime van Kessel
bfebb33123
Code style
CURA-5984

Co-Authored-By: diegopradogesto <d.pradogesto@ultimaker.com>
2018-11-28 10:28:16 +01:00
Jaime van Kessel
aeb2887796 Merge branch 'CURA-5979_gcode_loading_new_ui' of github.com:Ultimaker/Cura into ui_rework_4_0 2018-11-28 10:15:07 +01:00
Diego Prado Gesto
c1c5eb2219 Rename the properties to quickly identify that they are a boolean
Contributes to CURA-5984.
2018-11-28 09:44:37 +01:00
Diego Prado Gesto
14b460a626 Remove unused styles 2018-11-27 17:25:10 +01:00
Diego Prado Gesto
309061ce31 Add a new ToolbarButton
Now also the Extruder button is a toolbar button since it will show in
the toolbar.
2018-11-27 17:16:52 +01:00
Ghostkeeper
0b8a56458d
Remove unused CustomConfigurationSelector
I checked. It is no longer used.

Contributes to issue CURA-5876.
2018-11-27 17:11:32 +01:00
Ghostkeeper
26c7558a53
Don't show labels if controls themselves are not shown
The height of the popup is luckily automatically adjusted now.

Contributes to issue CURA-5876.
2018-11-27 16:44:16 +01:00
Ghostkeeper
41a5f05391
Remove SyncButton
It hasn't been used now for a while.

Contributes to issue CURA-5876.
2018-11-27 15:57:26 +01:00