Commit graph

14 commits

Author SHA1 Message Date
Ghostkeeper
2e12cc1dc2
Fix missing typing and use American instead of pro'er Bri'ish
American is Ultimaker's code style too.
2020-04-10 01:12:13 +02:00
Ghostkeeper
c51647026c
Also make IDs unique
Took me a while to see why Cura was confusing the extruder stacks. It worked fine during the actual upgrade itself. Then later after the start-up sequence it suddenly re-wrote them wrongly.

Why is there an ID field in here? Shouldn't it just take the file name as the ID? Stupid!
2020-04-10 00:28:27 +02:00
Ghostkeeper
45d3f8ca6a
Fix typo
With this it's starting to look like something. It's no longer giving any corruption errors now with any of my test cases. However e1 is still being set to the definition of e3 for some reason.
2020-04-09 22:12:30 +02:00
Ghostkeeper
c8b6d7ec00
Extruder 1 got duplicated, not extruder 0 2020-04-09 21:58:14 +02:00
Ghostkeeper
851aef68bc
Don't rename empty_quality_changes
This one doesn't get duplicated since it doesn't actually list the Deltacomb printer.
2020-04-09 21:54:22 +02:00
Ghostkeeper
519d28a142
Fix upgrading user containers, which list the printer definition rather than the extruder 2020-04-09 21:52:23 +02:00
Ghostkeeper
e38b79fe35
Filenames don't include an extension
That makes this a lot easier actually.
2020-04-09 21:36:28 +02:00
Ghostkeeper
4bdea50fd5
Use deepcopies rather than copies to copy parsers
Turns out that the parsers apparently refer to a lot of subobjects which are crucial here, and they don't implement the normal copy well. Deepcopy it is then.
2020-04-09 21:26:35 +02:00
Ghostkeeper
accf080fb6
Don't use default= kwarg for dictionary .get function
It doesn't accept key word arguments.
2020-04-09 21:22:06 +02:00
Ghostkeeper
40cb3e37a9
Also actually update global stacks for Deltacomb
Really hope that this works.
2020-04-09 01:48:15 +02:00
Ghostkeeper
18ebdfafb7
Upgrade other per-extruder instance containers too
Global instance containers will also go through this function but won't get picked out by the if statement here.
2020-04-09 01:23:11 +02:00
Ghostkeeper
2410d05100
Upgrade extruder stacks
Stupid stuff. All of these containers need to be copied. It's not possible to work this out for all materials properly, since we can't read into these materials what their GUIDs and material types are.
2020-04-09 01:04:53 +02:00
Ghostkeeper
a5b4b15ae4
Add theoretical upgrade for definition changes
It's a LOT more work than I thought, because the new printer has 4 extruders instead of 2. That means that files have to be copied for the other two extruders. A big hassle.
2020-04-08 01:58:03 +02:00
Ghostkeeper
2aeca3ef8c
Add version upgrade for 4.6 to 4.7 to halve the maximum deviation
Contributes to issue CURA-7282.
2020-04-01 15:05:18 +02:00