Diego Prado Gesto
ab339e7784
Merge pull request #4024 from Ultimaker/fix_use_engine_ready
...
Use _engine_ready to detect if there is a QML engine
2018-07-05 13:57:53 +02:00
Ghostkeeper
ec00e5b721
Remove references to deleted settings
...
Also convert the values for prime_tower_min_volume to make it behave similar to what the minimum volume used to be. This feature fixed a bug with the computation from volume to thickness. Now it's correct but we have to correct the old values to be still the same (approximately) as what used to be the end result.
Contributes to issue CURA-5457.
2018-07-05 13:22:17 +02:00
Mark
4157cffdbd
Merge branch 'master' into fix_use_engine_ready
2018-07-05 13:18:12 +02:00
Ghostkeeper
8f8c515438
Fix bug when default_extruder_nr is not provided
...
Then this would not slice because of a KeyError that is not caught.
Contributes to issue CURA-5457.
2018-07-05 12:51:27 +02:00
Andreea Scorojitu
87fd4c9e70
Add color to text in toolboxFooter, CURA-5544
...
"You will need to restart Cura before changes in packages have effect." wasn't visible in Ultimaker darktheme, color has been added to the label, CURA-5544.
2018-07-05 12:44:11 +02:00
Diego Prado Gesto
a27ec30575
Merge pull request #4021 from Ultimaker/add_types_for_backup_metadata
...
Add types for backup metadata
2018-07-05 12:33:26 +02:00
Ghostkeeper
ef2250b889
Don't check if keys are str
...
Our type checking should take care of that.
2018-07-05 12:31:42 +02:00
Diego Prado Gesto
3d549d0fb0
Merge pull request #4023 from Ultimaker/add_types_volume_dimensions
...
Add types for width, height, depth and shape
2018-07-05 12:29:51 +02:00
Diego Prado Gesto
20a9d8568f
Merge branch 'master' of github.com:Ultimaker/Cura
2018-07-05 12:09:32 +02:00
Ian Paschal
6f20b9219d
code style fixes
2018-07-05 11:57:13 +02:00
Jack Ha
675c5064ed
Added checkPackageUsageAndUninstall and the package usage check. No confirmation dialog yet
2018-07-05 11:47:06 +02:00
Ian Paschal
1aac301f75
additional code style fixes
2018-07-05 11:46:21 +02:00
Ian Paschal
50da6d5176
Fix some code-style
2018-07-05 11:36:36 +02:00
Mark
e1bc5d0f74
fix typing
2018-07-05 11:25:22 +02:00
Ghostkeeper
807e8410c0
Give warning when sum of volumes exceeds volume of prime tower
...
It could happen that the desired volume is not entirely reached in the inner shells because of rounding the volume up to the nearest perimeter on the outer shells.
Contributes to issue CURA-5457.
2018-07-05 10:31:23 +02:00
Lipu Fei
e87f3d7ca9
Fix plugins import in CuraApplication
...
CURA-5543
Only import types for type checking when TYPE_CHECKING is true.
2018-07-05 10:23:20 +02:00
Ghostkeeper
192a581d6d
Don't round the warning threshold
...
The threshold is not visible. It's not necessary to round.
Contributes to issue CURA-5457.
2018-07-05 09:50:05 +02:00
Ghostkeeper
4f1b2d51cc
Remove old commented code
...
This is not valid any more by a long shot.
2018-07-05 09:45:20 +02:00
Mark
20180e3804
Merge pull request #4022 from Ultimaker/remove_id_raise3d
...
Remove ID from Raise3D definition
2018-07-05 09:44:42 +02:00
Diego Prado Gesto
7d7a51d772
Fix code-style in CuraEngineBackend
2018-07-05 08:04:19 +02:00
Ghostkeeper
2023973e98
Use _engine_ready to detect if there is a QML engine
...
We already have this variable. Let's not use a private variable from another class.
2018-07-04 17:39:24 +02:00
Ghostkeeper
b812989f1c
Add types for width, height, depth and shape
2018-07-04 17:34:26 +02:00
Ghostkeeper
9e18bb8b4c
Remove ID from Raise3D definition
...
These IDs are not used and should never be added again.
2018-07-04 17:31:58 +02:00
Diego Prado Gesto
71ca5f39f2
Fix indentation to move the remove function outside of the loop because
...
it only needs to be done once.
2018-07-04 17:30:29 +02:00
Ghostkeeper
c9480f2f2b
Add types for backup metadata
2018-07-04 17:30:01 +02:00
Diego Prado Gesto
efb9fcb645
Merge branch '3.4'
2018-07-04 17:28:08 +02:00
Diego Prado Gesto
ed882b917e
Merge branch 'check_before_install_packages' into 3.4
2018-07-04 17:20:03 +02:00
Ghostkeeper
b149ef57fd
Add test for the version number being incremented
2018-07-04 17:18:01 +02:00
Diego Prado Gesto
d7c1767a23
Merge branch '3.4' into check_before_install_packages
2018-07-04 17:12:46 +02:00
Diego Prado Gesto
8e9ded98e4
Merge branch '3.4'
2018-07-04 14:57:43 +02:00
Lipu Fei
2b5700e4e1
Check the package file before installing it
...
Make sure that the package file is there before we remove the existing
installed files.
2018-07-04 14:50:32 +02:00
Diego Prado Gesto
4fd4043706
CURA-5528 Make the variable remove_failures a set.
2018-07-04 14:39:01 +02:00
Diego Prado Gesto
3b406b5467
Merge branch 'master' of github.com:Ultimaker/Cura
2018-07-04 14:32:05 +02:00
Diego Prado Gesto
4722b5387b
CURA-5334 Add extruder definition for Wanhao printers, Uni Print 3d and
...
Tevo Tornado. Those definitions were added without extruder definitions.
2018-07-04 14:22:22 +02:00
Ghostkeeper
8ff4327c41
Remove Wipe Nozzle After Switch and Purge Volume settings
...
The entire purging algorithm is gone now since it purges by printing the prime tower. The prime tower should be sufficiently strong now to not need this.
Contributes to issue CURA-5457.
2018-07-04 14:17:57 +02:00
Ghostkeeper
7b2a5c9160
Remove prime_tower_wall_thickness setting
...
The wall thickness now depends on the order in which the prime towers are folded, which is really hard to obtain within an inheritance formula. So we forego one of the settings and compute the required thickness to obtain the desired volume in the engine where the shell order is known.
Contributes to issue CURA-5457.
2018-07-04 13:45:44 +02:00
Ian Paschal
d4aaec7355
CURA-5537 Style improvements
2018-07-04 12:51:01 +02:00
Mark Burton
9e0b79469b
Set default value of wall_overhang_speed_factor to 100, i.e. print overhang at the normal speed.
2018-07-04 11:50:30 +01:00
Mark Burton
9186dc2c89
Default value for wall_overhang_angle is now 90 so overhang detection is disabled by default.
2018-07-04 11:50:22 +01:00
Mark Burton
5f23bcf8e9
Allow wall_overhang_angle to be 90 and add blurb that describes how this disables overhang processing.
2018-07-04 11:50:10 +01:00
Mark Burton
41900e33b8
Add wall_overhang_angle and wall_overhang_speed_factor settings.
...
# Conflicts:
# resources/definitions/fdmprinter.def.json
2018-07-04 11:49:53 +01:00
Mark Burton
404551e30a
Remove bridge_wall_max_overhang - no longer required with new overhang settings.
...
# Conflicts:
# resources/definitions/fdmprinter.def.json
2018-07-04 11:49:08 +01:00
Mark Burton
a8685b10be
Change some settings to be settable per mesh rather than per extruder.
...
# Conflicts:
# resources/definitions/fdmprinter.def.json
2018-07-04 11:48:27 +01:00
Diego Prado Gesto
5b251fc6dc
CURA-5334 Remove machine nozzle size from machine definitions and move
...
it to extruder definitions.
2018-07-04 12:00:38 +02:00
Ian Paschal
7d30cee205
Revert "Add dummy details for when there is no selection"
...
This reverts commit 2e3528d9b2
.
2018-07-04 11:36:56 +02:00
Diego Prado Gesto
715eda4f59
Merge branch 'master' of github.com:Ultimaker/Cura
2018-07-03 17:57:45 +02:00
Diego Prado Gesto
f91b6faecc
Fix code-styling
2018-07-03 17:57:30 +02:00
Lipu Fei
5f2cbd4440
Merge pull request #4015 from Ultimaker/CURA-5537_toolbox_style_improvements
...
CURA-5537 improve styling of toolbox
2018-07-03 16:05:51 +02:00
Lipu Fei
2e3528d9b2
Add dummy details for when there is no selection
...
CURA-5521
2018-07-03 15:58:54 +02:00
Ian Paschal
bc05839940
CURA-5537 improve styling of toolbox
2018-07-03 15:54:20 +02:00