Commit graph

21777 commits

Author SHA1 Message Date
Ghostkeeper
5b70d409ed
Improve documentation for lazy-loading background task
In particular the thread switching sleep was a bit mysterious.

Contributes to issue CURA_6793.
2019-10-23 09:46:44 +02:00
Ghostkeeper
f69360fb14
Make lazy-load container a protected inner class
Contributes to issue CURA-6793.
2019-10-23 09:42:43 +02:00
Ghostkeeper
f1e35907d2
Make MachineNodeLoadJob protected inner class
It should not be used outside of this class.

Contributes to issue CURA-6793.
2019-10-23 09:41:05 +02:00
Ghostkeeper
f3736f0576
Add typing for _machines
Contributes to issue CURA-6793.

Co-Authored-By: Jaime van Kessel <nallath@gmail.com>
2019-10-23 07:40:12 +00:00
Lipu Fei
b2afaf305d Add @api decorator
CURA-6665
2019-10-23 08:33:00 +02:00
Ghostkeeper
59e55dab5e
Fixes for consistency with other printers
Contributes to issue CURA-6814.
2019-10-22 17:23:32 +02:00
Ghostkeeper
fa00600655
Merge branch '4.3' of https://github.com/samirabaza/Cura into samirabaza-4.3 2019-10-22 16:58:30 +02:00
Lipu Fei
f2c66f8d3a Fix TestVariantNode
CURA-6921
2019-10-22 15:31:17 +02:00
Lipu Fei
66005f28f3 Fix typo in removing Alternate Skin Rotations 2019-10-22 15:00:51 +02:00
Lipu Fei
66bc20eab1 Revert incorrect material handling code in VariantNode
CURA-6921
2019-10-22 14:53:14 +02:00
Lipu Fei
b6d591c64c Add typing
CURA-6858
2019-10-22 14:14:14 +02:00
Lipu Fei
1f3a7c976f Remove deprecated MachineManager.activeMachineHasRemoteConnection
CURA-6858
2019-10-22 14:14:14 +02:00
Lipu Fei
38ee4bf208 Remove deprecated functions in MachineManager
CURA-6858
2019-10-22 14:11:40 +02:00
Lipu Fei
7544d049c5 Remove deprecated ExtruderManager.getExtruderName
CURA-6858
2019-10-22 14:11:40 +02:00
Lipu Fei
9c92e61699 Remove deprecated getChildNode and getContainer in ContainerNode
CURA-6858
2019-10-22 14:11:40 +02:00
Lipu Fei
43ee68bdc7 Remove deprecated PrinterOutputDevice.setAcceptsCommands
CURA-6858
2019-10-22 14:11:36 +02:00
Lipu Fei
227b76d6f0 Remove deprecated currentExtruderPositions
CURA-6858
2019-10-22 14:11:31 +02:00
Ghostkeeper
cb9b385a85
Remove Alternate Skin Rotations setting
It's been replaced completely by the Top/Bottom Line Directions setting.
2019-10-22 13:46:42 +02:00
Lipu Fei
fc0b8185b7 Fix setMetaDataEntry() dependency on ContainerRegistery
CURA-6920
2019-10-22 11:38:32 +02:00
Ghostkeeper
985aac9e60
Assert that there is no ID metadata entry in definition containers 2019-10-22 11:01:16 +02:00
Ghostkeeper
d561810024
Remove ID metadata fields from definition files
They are not being used any more. For some reason people thought that an exception was made for extruders or something. And people keep adding them for the definition files too. I'll add a test to prevent that.
2019-10-22 11:00:49 +02:00
Ghostkeeper
51c3acc654
Document helper functions 2019-10-22 09:56:50 +02:00
Lipu Fei
00abde2c8f Update setting_version for key3d tyro qualities
CURA-6815
2019-10-22 08:09:31 +02:00
Lipu Fei
d2db9b28ca
Merge pull request #6368 from DragonJe/4.3
Hopefully Adding the Key3D Tyro to 4.3 Release
2019-10-22 08:07:59 +02:00
Nino van Hooff
c62ff262ed Change SDK version to 7.0.0
CURA-6858
2019-10-21 14:51:34 +02:00
Jaime van Kessel
a376d0e4d1
Merge pull request #6499 from Ultimaker/CURA-6853_layer_slider_behind_action_panel
Cura 6853 layer slider behind action panel
2019-10-21 14:26:44 +02:00
Jaime van Kessel
9d931d8d2b
Remove stray print statement
CURA-6853
2019-10-21 14:24:52 +02:00
Nino van Hooff
2058cf8601 Merge remote-tracking branch 'origin/master' 2019-10-21 13:37:37 +02:00
Nino van Hooff
3d30674465 Clarify "reset quality button" purpose 2019-10-21 13:37:28 +02:00
Jaime van Kessel
d3fb066cac
Merge branch 'CURA-6851' of github.com:Ultimaker/Cura 2019-10-21 11:49:12 +02:00
Jaime van Kessel
6e5b560fa7
Merge pull request #6564 from Ultimaker/CURA-6855_try_catch_for_zeroconf
CURA-6855 Catch WinErrors for zeroconf
2019-10-21 10:41:28 +02:00
Nino van Hooff
b2f9dc612d Change intent profile descriptions to not trigger pervs and prudes.
CURA-6851
2019-10-21 10:33:52 +02:00
Lipu Fei
5548c30616 Catch WinErrors for zeroconf
CURA-6855
2019-10-21 10:21:50 +02:00
Lipu Fei
5602c71ec7 Fix material model update and signal recursion
CURA-6904
2019-10-21 09:53:14 +02:00
Lipu Fei
cd0dbb3902 Fix defaultExtruderPosition() usage in fdmprinter
CURA-6913

getDefaultValueInExtruder() expects the extruder_position to be an int,
but defaultExtruderPosition() returns a str. This will cause the formula
evaluation to fail.
2019-10-21 09:22:55 +02:00
Lipu Fei
5149baf593 Fix custom quality fetching
CURA-6913
2019-10-21 09:06:07 +02:00
Lipu Fei
4aadcba01c
Merge pull request #6549 from Ultimaker/CURA-6897_qml_warnings_materials_page
CURA-6897_qml_warnings_materials_page
2019-10-21 08:50:31 +02:00
Ghostkeeper
8cd583ad33
Only show conical support min width if angle is positive
If the angle is 0 or negative, this setting won't have any effect since the support cannot be made wider than it already is using this setting. It can only prevent it from becoming smaller, and it will only become smaller from a positive conical support angle.

Discovered during work on the Settings Guide.
2019-10-21 01:48:01 +02:00
Ghostkeeper
4a5673746c
Remove unused default_value overrides
These are overrides of default_value while there is a value defined. As such these overrides had no effect at all.
Changing them to value can actually change the behaviour of the profile. That is not what the profile author has apparently tested with, so I'm not doing that. I'm just removing the unused data.
In the future if we get new definitions the author gets notified of the error so that he may test more effectively. The legacy can't be fixed without re-testing, so I'm leaving that to the authors.

Done during Turbo Testing & Tooling. I want to go home for the weekend now...
2019-10-18 18:38:16 +02:00
Ghostkeeper
15ea29924a
Sort definition files before testing them
When going through the list of tests for many printers to fix them, it's then easier to go through the failed list. They will appear in the same order as in my IDE. Just a bit of an ease of life thing without any real cost.

Done during Turbo Testing & Tooling.
2019-10-18 17:02:40 +02:00
Ghostkeeper
1d7ad38db2
Also name which setting has the dysfunctional override
So that it's easier to remove it.

Done during Turbo Testing & Tooling.
2019-10-18 17:00:47 +02:00
Ghostkeeper
76b5f9d37b
Fix testing if JSON elements are mappings
Turns out that the JSON objects extend from dict, so this works.
Also turns out that strings have a __getitem__. Who knew?

Done during Turbo Testing & Tooling.
2019-10-18 16:57:57 +02:00
Ghostkeeper
b24dad1563
Merge branch 'master' of ssh://github.com/Ultimaker/Cura 2019-10-18 16:53:08 +02:00
Ghostkeeper
9316df72b3
Add test for overriding default_value while there is a value
This should not be done anywhere since the default_value won't have any effect then. We disregard CuraEngine's command line method here but that's infeasible with those profiles anyway.

Done during Turbo Testing & Tooling.
2019-10-18 16:45:15 +02:00
Remco Burema
25d76aee5a Workaround: Make the type-checker understand what's going on. 2019-10-18 14:46:44 +02:00
Remco Burema
270cb67480 Merge branch 'master' of https://github.com/Ultimaker/Cura 2019-10-18 14:01:20 +02:00
Remco Burema
15bdf0fa1c Change the description of 'Initial Bottom Layers'.
part of CURA-5918
2019-10-18 14:00:16 +02:00
Remco Burema
1885dddf45 Merge branch 'feat_open_top_bottom' of https://github.com/BagelOrb/Cura into BagelOrb-feat_open_top_bottom 2019-10-18 12:55:52 +02:00
Jaime van Kessel
41dbf51e36
Merge branch 'master' of github.com:Ultimaker/Cura 2019-10-18 12:00:03 +02:00
Jaime van Kessel
c7a6fa4a00
Remove fixed override of prime tower position
Now it uses the calculated value from fdm_printer, which is way smarter about it
2019-10-18 11:59:21 +02:00