3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-19 12:47:49 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 5
34814 commits 306 branches 270 tags 779 MiB
Commit graph

18 commits

Author SHA1 Message Date
Saumya Jain
c6ff0d3030 Enhance error reporting for deleted files 
The code now checks if a requested file is present in the files list before diagnosing issues and generating error reports for it. It will help prevent attempting to diagnose or report on files that do not exist or deleted, thus enhancing efficiency and preventing possible error generation

CURA-10903
 2024-04-10 14:50:26 +02:00
Saumya Jain
a965392559 Update method for getting PR number and modify output report 
The code updates the way we fetch the Pull Request number in the Github action. Rather than using an external action, we directly make use of Github's CLI, which helps improve the speed and reliability of the workflow. Additionally, the output report's format in terminal.py, previously named as "Git Comment", has been changed to "Error Files" to better reflect the information it carries.

CURA-10903
 2024-04-10 14:16:25 +02:00
Saumya Jain
bb94ce9e75 fixing typo checks 
CURA-10903
 2024-04-09 11:37:42 +02:00
Saumya Jain
561a40d000 Implement GitComment class and update workflow files 
A new GitComment class was implemented to replace Diagnostic for deleted file checks. As part of this change, both main workflow files (printer-linter-pr-diagnose.yml and printer-linter-pr-post.yml) have been updated to accommodate this new class. Also, reports now use 'comment.md' instead of 'fixes.yml'. All of this is ultimately geared at improving diagnostic functionality and allowing deleted file checks to output directly to a Git comment.

CURA-10903
 2024-04-09 11:33:24 +02:00
Saumya Jain
38382eeec7 Add detection for deleted files in printer linter 
This update adds a new check for deleted files in the printer linter. This will alert the user when a file has been deleted that could potentially disrupt upgrade scripts. An argument "--deleted" is also added to terminal.py to facilitate this new check. Additionally, the printer-linter version has been incremented to 0.1.2.

CURA-10903
 2024-04-05 15:55:30 +02:00
jellespijker
b401ecee02 Add MacOS directory naming linting 
A new Linter subclass - 'Directory' has been created and integrated into the linting process to handle directory naming conventions, specifically for MacOS. MacOS has issues when signing and notarizing directories with '.' in their names. The new class will trigger an 'Error' level diagnostic if this convention is violated. The linter will become a required check with this update, as its new check configuration was added to '.printer-linter'. The version number in 'pyproject.toml' was also incremented to reflect these changes.

Contributes to CURA-11014
 2023-09-22 01:29:22 +02:00
jspijker
6b810fbd6c Allow for wildcard with printer-linter 2022-12-30 21:59:43 +01:00
Luis Gabriel Gomez
358f20a94e
printer-linter: exit on invalid definition file paths 
This PR prevents silent failure with empty diagnostics if an invalid file path was provided
 2022-12-04 19:45:25 -03:00
Joey de l'Arago
a809e5a91c don't shadow format function. 2022-11-28 09:13:19 +01:00
Joey de l'Arago
e83ed933e2 Update readme with instruction for developing. 
Change DiagnosticGenerator -> Linter since this is much easier to understand.
 2022-11-23 17:52:33 +01:00
Joey de l'Arago
8e027c4af9 Add is not None because it makes it clearer that the lamdba returns a boolean. 2022-11-23 17:21:31 +01:00
Joey de l'Arago
a7800f824a Use formatters in terminal.py 
Do some general refactoring for readability
 2022-11-23 17:20:22 +01:00
Joey de l'Arago
f74a40bed0 Flatten main logic. 
Parse files from directories to remove checking if a file is a directory in many places.
 2022-11-23 14:24:09 +01:00
Joey de l'Arago
ad7e719146 Format lists and dicts of a single item onto one line 
example:
"dict":
{
 "value": 10
}
becomes
"dict": { "value": 10 }
 2022-11-22 21:42:42 +01:00
Joey de l'Arago
91daf89c2d add return types 2022-11-22 14:38:41 +01:00
jspijker
187dfe1210 single-value-single-line formatting 
Need to figure out the regex expression.
To only select overrides consisting of a
single value
 2022-11-21 14:20:53 +01:00
jspijker
0070cb7af0 flatten list 2022-11-21 10:58:28 +01:00
jspijker
4b455d45e9 Use same yaml structure as cling-tidy 2022-11-21 10:51:08 +01:00
Renamed from printer-linter/src/printerlinter/terminal.py (Browse further)