Commit graph

6332 commits

Author SHA1 Message Date
Nino van Hooff
649cc4a881 Replace support_tree_enable by a support_structure enum
CURA-6711
2020-07-09 17:17:40 +02:00
Ghostkeeper
3032221b70
Prevent division by 0 if total download size is 0
This can happen if the downloads are all so small that it gets rounded to 0kB.

Fixes Sentry issue CURA-ZM.
2020-07-06 17:23:58 +02:00
Jaime van Kessel
21e28089a8
Merge branch 'CURA-7248_fix_misp_config_detection' of github.com:Ultimaker/Cura 2020-07-02 16:37:53 +02:00
Nino van Hooff
9ffadb369d Fix ExtruderConfigurationModel.__eq__
Fixes an issue where 2 configurations
(empty, empty) and (pla, empty) were considered
equal

CURA-7248
2020-07-02 15:44:22 +02:00
Nino van Hooff
06284b6a73 Implement Review comments
CURA-5479
2020-07-01 16:47:20 +02:00
Nino van Hooff
24820bab07 Fix: incorrect return statement
CURA-5479
2020-07-01 15:00:35 +02:00
Nino van Hooff
c50f7aa455 Add a print job name setting to general preferences
CURA-5479
2020-06-30 17:04:03 +02:00
Jaime van Kessel
440474b1e8
Pass the cached normal transformation to the rendere
CURA-7106
2020-06-30 13:39:32 +02:00
Jaime van Kessel
ccd9a17be4
Remove normals for ConvexHullNode
They are rendered flat, so no need to store the normals

CURA-7106
2020-06-30 13:22:45 +02:00
Jaime van Kessel
22de878e5c
Merge branch 'CURA-7473_account_pending_update_button' of github.com:Ultimaker/Cura 2020-06-29 15:11:42 +02:00
Konstantinos Karmas
c6fd25e7e9
Merge pull request #7971 from Ultimaker/CURA-7106-Speedup-multiple-objects-on-build-plate
CURA-7106 Speedup multiple objects on build plate
2020-06-29 12:36:02 +02:00
Nino van Hooff
979407eddf Additional typing fixes
CURA-7473
2020-06-29 11:10:50 +02:00
Nino van Hooff
8e62a6d6d7
Apply suggestions from code review
Typing suggestions by Jaime

CURA-7473

Co-authored-by: Jaime van Kessel <nallath@gmail.com>
2020-06-29 10:35:49 +02:00
Nino van Hooff
294afdb7ca Connect sync timer to sync() for consistency and add unit tests.
Also rename a function to camelCase

CURA-7473
2020-06-26 16:09:33 +02:00
Nino van Hooff
4f1a18f102 Add Install Pending Updates button to Account popup
CURA-7473
2020-06-26 11:37:01 +02:00
Ghostkeeper
ffac9adb96
Add default for extruder position
The position argument metadata always be there. However if it's not (because the file is old, or manually modified, or a version upgrade worked incorrectly, or whatever) then we shouldn't crash. We just don't know how to order it correctly then. This tries to repair it as best it can.
2020-06-25 15:08:08 +02:00
Ghostkeeper
79cc6ec897
Also report failure if the file system can't handle the archive contents
For instance if the file name is too long for this file system, if the computer is running out of disk space or if there is a general failure to write here.

Fixes Sentry issue CURA-YQ.
2020-06-25 09:47:59 +02:00
Jaime van Kessel
27277d4e54
Add missing typing 2020-06-24 15:28:41 +02:00
Jaime van Kessel
68807d99d2
Fix issue that no disallowed areas were show if there were no active objects
CURA-7106
2020-06-24 15:18:20 +02:00
Jaime van Kessel
b1fe4793e4
Put all objects normal models in a single render batch
THis speeds things up a fair bit for build plates with multiple models

CURA-7106
2020-06-24 10:42:35 +02:00
Jaime van Kessel
03e66beafd
Re-use some render batches
This prevents us from having to re-create them everytime

CURA-7106
2020-06-23 17:12:47 +02:00
Jaime van Kessel
b0ed47daf1
Don't copy transformations if it's not needed
CURA=7106
2020-06-23 16:24:34 +02:00
Jaime van Kessel
ac0c0d0698
Let the error checker calculate the error values a bit more "on demand"
Previously it would just re-try all settings, but this really isn't needed (since
we have a setting relationship object that can tell us what settings depend on what).
This won't speed things up in a worst case scenario (since that will still be "caluclate
all the settings") but it will speed it up in most cases.

Most setting changes now only trigger a calculation that takes <0.2 sec isntead of the 1.1 sec.
Yes, those numbers seem big, but the error checking is already built in such a way that it spreads this
out over multiple frames (so it's not actually freezing that time, but it is doing shit it shouldn't do!)

CURA-7106
2020-06-23 14:54:56 +02:00
Jaime van Kessel
7e8e051eb2
Short circuit finding the extruders that are active
CURA-7106
2020-06-23 13:38:00 +02:00
Jaime van Kessel
f9b288f3c6
Move checking for some global features outside of the per node loop
CURA-7106
2020-06-23 13:24:22 +02:00
Jaime van Kessel
1f698fd664
Further simplify the getUsedExtruderStacks function
Should be a tiny bit faster

CURA-7106
2020-06-23 13:13:49 +02:00
Jaime van Kessel
1d9c92c47f
Use cached values for anti overhang and support mesh
CURA-7106
2020-06-23 13:08:03 +02:00
Jaime van Kessel
d897299b31
Simplify recomputeConvexHull code
CURA-7106
2020-06-23 12:55:13 +02:00
Jaime van Kessel
1900b0841a
Use cheaper convexhull function when not using raft
CURA-7106
2020-06-23 12:03:15 +02:00
Jaime van Kessel
1dc688dd4a
Prevent double updateNextStack during deepcopy
CURA-7106
2020-06-23 11:40:52 +02:00
Jaime van Kessel
4729bd1d0f
Remove unneeded check from deepcopy of settingoverride decorator
CURA-7106
2020-06-23 11:32:57 +02:00
Jaime van Kessel
85797c4cf5
Add processEvents calls to multiply job
Because we want them delicious updates

CURA-7106
2020-06-23 11:17:38 +02:00
Jaime van Kessel
9014fa79e2
Cache result of getEdgeDisallowedSize
CURA-7106
2020-06-23 11:01:43 +02:00
Kostas Karmas
d0d7e671ed Make the deletion of the definitionChanges safer
Just in case findContainerStacks returns an empty list
2020-06-23 10:56:48 +02:00
Jaime van Kessel
ea568f4ad5
Make the updating of the buildvolume a bit trigger happy
CURA-7106
2020-06-23 10:52:39 +02:00
Jaime van Kessel
1505d59f4b
Add extra process events to arrange job
Doesn't actually speed up something, but it does prevent the GUI from
freezing, so it looks less laggy.

CURA-7106
2020-06-23 10:38:21 +02:00
Jaime van Kessel
737a9faa5f
Speed up the objects model
It was using a few expensive calls that had already been cached.

CURA-7106
2020-06-23 10:32:42 +02:00
Jaime van Kessel
46076bf21d
Simplify the renameNodes method
Especially when duplicating large amounts of items this would cause a bit of a slowdown

CURA-7106
2020-06-23 10:14:44 +02:00
Jaime van Kessel
f00e3f7363
Remove useless code
CURA-7106
2020-06-23 09:21:24 +02:00
Jaime van Kessel
570efc8310
Remove unneeded checks in convex hull node
CURA-7106
2020-06-22 17:18:22 +02:00
Jaime van Kessel
16bc2071ee
Cache values to speed up the rendering
CURA-7106
2020-06-22 16:49:42 +02:00
Jaime van Kessel
1b973b3f3c
Remove bit of code duplication
CURA-7106
2020-06-22 16:31:37 +02:00
Jaime van Kessel
61def4ba25
Prevent crash when requested polygon is too large
CURA-6P
2020-06-19 16:59:27 +02:00
Nino van Hooff
5e921698b2
Merge pull request #7947 from Ultimaker/CURA-7522_Removing_printer_created_by_projectfile_removes_original_printer
CURA-7522: Removing printer created by project file also removes the original printer
2020-06-19 16:39:03 +02:00
Ghostkeeper
ba8cb4ce4a
Don't pre-load engine before other plug-ins
This was a fix for the post-processing plug-in that's no longer required.
It was also only applied when running from source, so obviously it's not required or we'd have seen it in the builds.
2020-06-19 16:12:36 +02:00
Jaime van Kessel
d0a84828ff
Remove unneeded call to autosave trigger on initializaiton 2020-06-18 17:59:35 +02:00
Jaime van Kessel
f0002e265b
Mark recently constructed stacks as not dirty
The stacks would get marked dirty for setting some metadata, but since thats
part of their construction, they aren't really dirty.

Previously, every single stack that was loaded would be marked as dirty, which causes unneeded
saving.
2020-06-18 17:39:58 +02:00
Ghostkeeper
f8a88642c2
Don't crash when failing to create Toolbox.qml dialogue
Basically we should never be raising the master Exception class, really.
The enclosing class has error handling in case this returns None already, so this fix is easy.

Contributes to Sentry issue CURA-Y5.
2020-06-18 14:53:18 +02:00
Kostas Karmas
364769d821 Remove only the hidden printers when removing a printers
When printers share the same group_id, they are removed, regardless if
they are hidden or not. This was resulting in sometimes removing
multiple printers when removing a printer that was created by a project
file.
This PR fixes that by actually checking whether the printer to be
removed is hidden.

CURA-7522
2020-06-18 13:49:50 +02:00
Jaime van Kessel
466ec7c42a
Remove duplicated variable
It was holding the same data as extruders_to_disable
2020-06-18 11:08:17 +02:00