3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-16 11:17:49 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Add test to ensure that no definitions define new settings

Browse source 
See the documentation of the test.
This commit is contained in:
Ghostkeeper 2021-03-08 16:53:38 +01:00
parent cbafac6133
commit fde9449358
No known key found for this signature in database
GPG key ID: D2A8871EE34EC59A
1 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/Settings/TestDefinitionContainer.py
View file

@ -227,4 +227,20 @@ def test_extruderMatch(file_path: str):
# Also test if the extruder_nr setting is properly overridden.
if "overrides" not in doc or "extruder_nr" not in doc["overrides"] or "default_value" not in doc["overrides"]["extruder_nr"]:
assert position == "0" # Default to 0 is allowed.
assert doc["overrides"]["extruder_nr"]["default_value"] == int(position)
assert doc["overrides"]["extruder_nr"]["default_value"] == int(position)
@pytest.mark.parametrize("file_path", definition_filepaths)
def test_noNewSettings(file_path: str):
"""
Tests that a printer definition doesn't define any new settings.
Settings that are not common to all printers can cause Cura to crash, for instance when the setting is saved in a
profile and that profile is then used in a different printer.
:param file_path: A path to a definition file to test.
"""
filename = os.path.basename(file_path)
if filename == "fdmprinter.def.json" or filename == "fdmextruder.def.json":
return # FDMPrinter and FDMExtruder, being the basis for all printers and extruders, are allowed to define new settings since they will be available for all printers then.
with open(file_path, encoding = "utf-8") as f:
doc = json.load(f)
assert "settings" not in doc