3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-08-03 12:03:57 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Merge pull request #11674 from Ultimaker/CURA-9039_combobox_open_out_of_window

Browse source 
[CURA-9039] fix combobox scrolling out of view
This commit is contained in:
Joey de l'Arago 2022-03-17 07:46:56 +00:00 • committed by GitHub
commit fcfc47920f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
resources/qml/Preferences/GeneralPage.qml
View file

@ -148,6 +148,14 @@ UM.PreferencesPage
bottom: parent.bottom bottom: parent.bottom
right: parent.right right: parent.right
} }
onPositionChanged: {
// This removes focus from items when scrolling.
// This fixes comboboxes staying open and scrolling container
if (!activeFocus) {
forceActiveFocus();
}
}
} }
Column Column

16
resources/qml/Settings/SettingView.qml
View file

@ -188,13 +188,15 @@ Item
} }
clip: true clip: true
cacheBuffer: 1000000 // Set a large cache to effectively just cache every list item. cacheBuffer: 1000000 // Set a large cache to effectively just cache every list item.
ScrollBar.vertical: UM.ScrollBar { id: scrollBar } ScrollBar.vertical: UM.ScrollBar
{
onContentYChanged: { id: scrollBar
// This removes focus from SettingItems when scrolling. onPositionChanged: {
// This fixes comboboxes staying open and scrolling out of the settingView. // This removes focus from items when scrolling.
if (!scrollBar.activeFocus) { // This fixes comboboxes staying open and scrolling container
scrollBar.forceActiveFocus(); if (!activeFocus) {
forceActiveFocus();
}
} }
} }