3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 06:57:28 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Don't pollute the package_info with section_title

Browse source 
The previous implementation added a section_title to the package_info
which was also stored in the packages.json. The section_title is now
provided to the PackageModel as an extra optional argument.

Contributes to CURA-8558
This commit is contained in:
j.spijker@ultimaker.com 2021-11-03 14:11:07 +01:00 • committed by Jelle Spijker
parent edc71f12a3
commit f9f43b79b0
No known key found for this signature in database
GPG key ID: 6662DC033BE6B99A
2 changed files with 31 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

5
plugins/Marketplace/PackageModel.py
View file

@ -16,16 +16,17 @@ class PackageModel(QObject):
QML. The model can also be constructed directly from a response received by the API.
"""
def __init__(self, package_data: Dict[str, Any], parent: QObject = None) -> None:
def __init__(self, package_data: Dict[str, Any], section_title: Optional[str] = None, parent: Optional[QObject] = None) -> None:
"""
Constructs a new model for a single package.
:param package_data: The data received from the Marketplace API about the package to create.
:param section_title: If the packages are to be categorized per section provide the section_title
:param parent: The parent QML object that controls the lifetime of this model (normally a PackageList).
"""
super().__init__(parent)
self._package_id = package_data.get("package_id", "UnknownPackageId")
self._display_name = package_data.get("display_name", catalog.i18nc("@label:property", "Unknown Package"))
self._section_title = package_data.get("section_title", None)
self._section_title = section_title
@pyqtProperty(str, constant = True)
def packageId(self) -> str: