Fix some codestyle issues

This commit is contained in:
Jaime van Kessel 2019-12-23 11:13:59 +01:00
parent 5061a36aba
commit f983990ac1
No known key found for this signature in database
GPG key ID: 3710727397403C91
2 changed files with 107 additions and 111 deletions

View file

@ -40,7 +40,8 @@ Item
// update active type label // update active type label
for (var button in meshTypeButtons.children) for (var button in meshTypeButtons.children)
{ {
if (meshTypeButtons.children[button].checked){ if (meshTypeButtons.children[button].checked)
{
meshTypeLabel.text = catalog.i18nc("@label", "Mesh Type") + ": " + meshTypeButtons.children[button].text meshTypeLabel.text = catalog.i18nc("@label", "Mesh Type") + ": " + meshTypeButtons.children[button].text
break break
} }
@ -130,7 +131,7 @@ Item
} }
Label Label
{ {
id: meshTypeLabel id: meshTypeLabel
font: UM.Theme.getFont("default") font: UM.Theme.getFont("default")
@ -321,10 +322,7 @@ Item
Connections Connections
{ {
target: inheritStackProvider target: inheritStackProvider
onPropertiesChanged: onPropertiesChanged: provider.forcePropertiesChanged()
{
provider.forcePropertiesChanged()
}
} }
Connections Connections
@ -460,5 +458,4 @@ Item
Cura.SettingUnknown { } Cura.SettingUnknown { }
} }
} }

View file

@ -7,130 +7,129 @@ import Cura 1.0 as Cura
import ".." import ".."
UM.Dialog UM.Dialog
{
id: settingPickDialog
title: catalog.i18nc("@title:window", "Select Settings to Customize for this model")
width: screenScaleFactor * 360
property var additional_excluded_settings
onVisibilityChanged:
{ {
id: settingPickDialog // force updating the model to sync it with addedSettingsModel
if (visible)
title: catalog.i18nc("@title:window", "Select Settings to Customize for this model")
width: screenScaleFactor * 360
property var additional_excluded_settings
onVisibilityChanged:
{ {
// force updating the model to sync it with addedSettingsModel listview.model.forceUpdate()
if (visible) updateFilter()
{ }
listview.model.forceUpdate() }
updateFilter()
} function updateFilter()
{
var new_filter = {}
new_filter["settable_per_mesh"] = true
// Don't filter on "settable_per_meshgroup" any more when `printSequencePropertyProvider.properties.value`
// is set to "one_at_a_time", because the current backend architecture isn't ready for that.
if (filterInput.text != "")
{
new_filter["i18n_label"] = "*" + filterInput.text
} }
function updateFilter() listview.model.filter = new_filter
}
TextField
{
id: filterInput
anchors
{ {
var new_filter = {} top: parent.top
new_filter["settable_per_mesh"] = true left: parent.left
// Don't filter on "settable_per_meshgroup" any more when `printSequencePropertyProvider.properties.value` right: toggleShowAll.left
// is set to "one_at_a_time", because the current backend architecture isn't ready for that. rightMargin: UM.Theme.getSize("default_margin").width
if (filterInput.text != "")
{
new_filter["i18n_label"] = "*" + filterInput.text
}
listview.model.filter = new_filter
} }
TextField { placeholderText: catalog.i18nc("@label:textbox", "Filter...")
id: filterInput
anchors { onTextChanged: settingPickDialog.updateFilter()
top: parent.top }
left: parent.left
right: toggleShowAll.left
rightMargin: UM.Theme.getSize("default_margin").width
}
placeholderText: catalog.i18nc("@label:textbox", "Filter...") CheckBox
{
id: toggleShowAll
onTextChanged: settingPickDialog.updateFilter() anchors
{
top: parent.top
right: parent.right
} }
CheckBox text: catalog.i18nc("@label:checkbox", "Show all")
checked: listview.model.showAll
onClicked: listview.model.showAll = checked
}
ScrollView
{
id: scrollView
anchors
{ {
id: toggleShowAll top: filterInput.bottom
left: parent.left
anchors { right: parent.right
top: parent.top bottom: parent.bottom
right: parent.right
}
text: catalog.i18nc("@label:checkbox", "Show all")
checked: listview.model.showAll
onClicked:
{
listview.model.showAll = checked
}
} }
ListView
ScrollView
{ {
id: scrollView id:listview
model: UM.SettingDefinitionsModel
anchors
{ {
top: filterInput.bottom id: definitionsModel
left: parent.left containerId: Cura.MachineManager.activeMachine != null ? Cura.MachineManager.activeMachine.definition.id: ""
right: parent.right visibilityHandler: UM.SettingPreferenceVisibilityHandler {}
bottom: parent.bottom expanded: [ "*" ]
} exclude:
ListView
{
id:listview
model: UM.SettingDefinitionsModel
{ {
id: definitionsModel var excluded_settings = [ "machine_settings", "command_line_settings", "support_mesh", "anti_overhang_mesh", "cutting_mesh", "infill_mesh" ]
containerId: Cura.MachineManager.activeMachine != null ? Cura.MachineManager.activeMachine.definition.id: "" excluded_settings = excluded_settings.concat(settingPickDialog.additional_excluded_settings)
visibilityHandler: UM.SettingPreferenceVisibilityHandler {} return excluded_settings
expanded: [ "*" ] }
exclude: }
delegate:Loader
{
id: loader
width: parent.width
height: model.type != undefined ? UM.Theme.getSize("section").height : 0
property var definition: model
property var settingDefinitionsModel: definitionsModel
asynchronous: true
source:
{
switch(model.type)
{ {
var excluded_settings = [ "machine_settings", "command_line_settings", "support_mesh", "anti_overhang_mesh", "cutting_mesh", "infill_mesh" ] case "category":
excluded_settings = excluded_settings.concat(settingPickDialog.additional_excluded_settings) return "PerObjectCategory.qml"
return excluded_settings default:
return "PerObjectItem.qml"
} }
} }
delegate:Loader
{
id: loader
width: parent.width
height: model.type != undefined ? UM.Theme.getSize("section").height : 0
property var definition: model
property var settingDefinitionsModel: definitionsModel
asynchronous: true
source:
{
switch(model.type)
{
case "category":
return "PerObjectCategory.qml"
default:
return "PerObjectItem.qml"
}
}
}
Component.onCompleted: settingPickDialog.updateFilter()
} }
Component.onCompleted: settingPickDialog.updateFilter()
} }
}
rightButtons: [ rightButtons: [
Button { Button
text: catalog.i18nc("@action:button", "Close") {
onClicked: { text: catalog.i18nc("@action:button", "Close")
settingPickDialog.visible = false onClicked: settingPickDialog.visible = false
} }
} ]
] }
}