From 4fb9a6a699cb146a8f942e9c934afbede70a0c95 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Tue, 15 Mar 2016 16:15:13 +0100 Subject: [PATCH 1/5] Per object settings now also uses visible depth CURA-1160 --- plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml b/plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml index 85d631b82f..c664aeaeef 100644 --- a/plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml +++ b/plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml @@ -237,7 +237,7 @@ Item { delegate: ToolButton { id: button; - x: model.depth * UM.Theme.getSize("default_margin").width; + x: model.visible_depth * UM.Theme.getSize("default_margin").width; text: model.name; tooltip: model.description; visible: !model.global_only From 7c22fe1eb55a0aaad5b36945ec346df163193a6d Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Tue, 15 Mar 2016 16:43:14 +0100 Subject: [PATCH 2/5] Removable drive plugin is now forced to use machine preference for output type Fixes CURA-1165 --- plugins/RemovableDriveOutputDevice/RemovableDriveOutputDevice.py | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/RemovableDriveOutputDevice/RemovableDriveOutputDevice.py b/plugins/RemovableDriveOutputDevice/RemovableDriveOutputDevice.py index f73ba46c85..f854e2711e 100644 --- a/plugins/RemovableDriveOutputDevice/RemovableDriveOutputDevice.py +++ b/plugins/RemovableDriveOutputDevice/RemovableDriveOutputDevice.py @@ -26,6 +26,7 @@ class RemovableDriveOutputDevice(OutputDevice): self._writing = False def requestWrite(self, node, file_name = None, filter_by_machine = False): + filter_by_machine = True # This plugin is indended to be used by machine (regardless of what it was told to do) if self._writing: raise OutputDeviceError.DeviceBusyError() From 0bf41cf5282cac7ec546fd05392a5fd0c3b9e60d Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Tue, 15 Mar 2016 16:48:35 +0100 Subject: [PATCH 3/5] Changed dimensions of UM2 CURA-1166 --- resources/machines/ultimaker2.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/machines/ultimaker2.json b/resources/machines/ultimaker2.json index 16867145cb..fed01312de 100644 --- a/resources/machines/ultimaker2.json +++ b/resources/machines/ultimaker2.json @@ -40,8 +40,8 @@ "machine_settings": { "machine_start_gcode" : { "default": "" }, "machine_end_gcode" : { "default": "" }, - "machine_width": { "default": 230 }, - "machine_depth": { "default": 225 }, + "machine_width": { "default": 223 }, + "machine_depth": { "default": 223 }, "machine_height": { "default": 205 }, "machine_heated_bed": { "default": true }, From 65499bd06c05856c9e6eed802a4636c9f28c3b38 Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Tue, 15 Mar 2016 17:48:58 +0100 Subject: [PATCH 4/5] JSON: made parent-child relations logical (CURA-1171) the child should depend foremost on the parent no parent may be used in the engine --- resources/machines/fdmprinter.json | 136 ++++++++++++++--------------- 1 file changed, 67 insertions(+), 69 deletions(-) diff --git a/resources/machines/fdmprinter.json b/resources/machines/fdmprinter.json index 346a0b10db..1d3ded2adf 100644 --- a/resources/machines/fdmprinter.json +++ b/resources/machines/fdmprinter.json @@ -374,14 +374,6 @@ } } }, - "alternate_extra_perimeter": { - "label": "Alternate Extra Wall", - "description": "Make an extra wall at every second layer, so that infill will be caught between an extra wall above and one below. This results in a better cohesion between infill and walls, but might have an impact on the surface quality.", - "type": "boolean", - "default": false, - "visible": false, - "inherit": false - }, "top_bottom_thickness": { "label": "Bottom/Top Thickness", "description": "This controls the thickness of the bottom and top layers. The number of solid layers put down is calculated from the layer thickness and this value. Having this value a multiple of the layer thickness makes sense. Keep it near your wall thickness to make an evenly strong part.", @@ -439,6 +431,15 @@ } } }, + + "alternate_extra_perimeter": { + "label": "Alternate Extra Wall", + "description": "Make an extra wall at every second layer, so that infill will be caught between an extra wall above and one below. This results in a better cohesion between infill and walls, but might have an impact on the surface quality.", + "type": "boolean", + "default": false, + "visible": false, + "inherit": false + }, "remove_overlapping_walls_enabled": { "label": "Remove Overlapping Wall Parts", "description": "Remove parts of a wall which share an overlap which would result in overextrusion in some places. These overlaps occur in thin pieces in a model and sharp corners.", @@ -996,22 +997,20 @@ "default": true, "visible": false, "enabled": "retraction_combing", - "global_only": "True", - "children": { - "travel_avoid_distance": { - "label": "Avoid Distance", - "description": "The distance to stay clear of parts which are avoided during travel.", - "unit": "mm", - "type": "float", - "default": 1.5, - "min_value": "0", - "max_value_warning": "machine_nozzle_tip_outer_diameter * 5", - "visible": false, - "inherit": false, - "enabled": "retraction_combing", - "global_only": "True" - } - } + "global_only": "True" + }, + "travel_avoid_distance": { + "label": "Avoid Distance", + "description": "The distance to stay clear of parts which are avoided during travel.", + "unit": "mm", + "type": "float", + "default": 1.5, + "min_value": "0", + "max_value_warning": "machine_nozzle_tip_outer_diameter * 5", + "visible": false, + "inherit": false, + "enabled": "retraction_combing and travel_avoid_other_parts", + "global_only": "True" }, "coasting_enable": { "label": "Enable Coasting", @@ -1071,43 +1070,44 @@ "description": "Enable the cooling fan during the print. The extra cooling from the cooling fan helps parts with small cross sections that print each layer quickly.", "type": "boolean", "default": true, + "global_only": "True" + }, + "cool_fan_speed": { + "label": "Fan Speed", + "description": "Fan speed used for the print cooling fan on the printer head.", + "unit": "%", + "type": "float", + "min_value": "0", + "max_value": "100", + "default": 100, + "visible": false, + "inherit_function": "100.0 if parent_value else 0.0", + "enabled": "cool_fan_enabled", "global_only": "True", "children": { - "cool_fan_speed": { - "label": "Fan Speed", - "description": "Fan speed used for the print cooling fan on the printer head.", + "cool_fan_speed_min": { + "label": "Minimum Fan Speed", + "description": "Normally the fan runs at the minimum fan speed. If the layer is slowed down due to minimum layer time, the fan speed adjusts between minimum and maximum fan speed.", "unit": "%", "type": "float", "min_value": "0", "max_value": "100", "default": 100, "visible": false, - "inherit_function": "100.0 if parent_value else 0.0", - "global_only": "True", - "children": { - "cool_fan_speed_min": { - "label": "Minimum Fan Speed", - "description": "Normally the fan runs at the minimum fan speed. If the layer is slowed down due to minimum layer time, the fan speed adjusts between minimum and maximum fan speed.", - "unit": "%", - "type": "float", - "min_value": "0", - "max_value": "100", - "default": 100, - "visible": false, - "global_only": "True" - }, - "cool_fan_speed_max": { - "label": "Maximum Fan Speed", - "description": "Normally the fan runs at the minimum fan speed. If the layer is slowed down due to minimum layer time, the fan speed adjusts between minimum and maximum fan speed.", - "unit": "%", - "type": "float", - "min_value": "0", - "max_value": "100", - "default": 100, - "visible": false, - "global_only": "True" - } - } + "enabled": "cool_fan_enabled", + "global_only": "True" + }, + "cool_fan_speed_max": { + "label": "Maximum Fan Speed", + "description": "Normally the fan runs at the minimum fan speed. If the layer is slowed down due to minimum layer time, the fan speed adjusts between minimum and maximum fan speed.", + "unit": "%", + "type": "float", + "min_value": "0", + "max_value": "100", + "default": 100, + "visible": false, + "enabled": "cool_fan_enabled", + "global_only": "True" } } }, @@ -1457,22 +1457,20 @@ "min_value": "0", "max_value_warning": "10", "visible": false, - "enabled": "support_enable and support_use_towers", - "children": { - "support_minimal_diameter": { - "label": "Minimum Diameter", - "description": "Minimum diameter in the X/Y directions of a small area which is to be supported by a specialized support tower.", - "unit": "mm", - "type": "float", - "default": 3.0, - "min_value": "0", - "max_value_warning": "10", - "max_value": "support_tower_diameter", - "inherit": true, - "visible": false, - "enabled": "support_enable and support_use_towers" - } - } + "enabled": "support_enable and support_use_towers" + }, + "support_minimal_diameter": { + "label": "Minimum Diameter", + "description": "Minimum diameter in the X/Y directions of a small area which is to be supported by a specialized support tower.", + "unit": "mm", + "type": "float", + "default": 3.0, + "min_value": "0", + "max_value_warning": "10", + "max_value": "support_tower_diameter", + "inherit": true, + "visible": false, + "enabled": "support_enable and support_use_towers" }, "support_tower_roof_angle": { "label": "Tower Roof Angle", From 802623443a603750b623b0dfe51b22560194d0ea Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Tue, 15 Mar 2016 17:51:52 +0100 Subject: [PATCH 5/5] JSON: fix for inherit function of fan speed (CURA-1171) --- resources/machines/fdmprinter.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/machines/fdmprinter.json b/resources/machines/fdmprinter.json index 1d3ded2adf..e7f538beae 100644 --- a/resources/machines/fdmprinter.json +++ b/resources/machines/fdmprinter.json @@ -1081,7 +1081,7 @@ "max_value": "100", "default": 100, "visible": false, - "inherit_function": "100.0 if parent_value else 0.0", + "inherit_function": "100.0 if cool_fan_enabled else 0.0", "enabled": "cool_fan_enabled", "global_only": "True", "children": {