From f3fd2d6f8088e192e56b61e92c9cbaca98e9a4f8 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Thu, 30 Jun 2022 11:48:22 +0200 Subject: [PATCH] Fix calling subprocesses We shouldn't unpack the list. The first argument is allowed to be a list. If we unpack it, it'll override other arguments to the call function that would be the wrong type then (buffer size). Contributes to issue CURA-9409. --- packaging/create_appimage.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packaging/create_appimage.py b/packaging/create_appimage.py index 6ae0c64aa5..e9b3d85fa3 100644 --- a/packaging/create_appimage.py +++ b/packaging/create_appimage.py @@ -47,13 +47,13 @@ def copy_metadata_files(): def generate_appimage(): appimage_path = os.path.join(dist_path, appimage_filename) command = ["appimagetool", "--appimage-extract-and-run", f"{dist_path}/", appimage_path] - result = subprocess.call(*command) + result = subprocess.call(command) if result != 0: raise RuntimeError(f"The AppImageTool command returned non-zero: {result}") def sign_appimage(): appimage_path = os.path.join(dist_path, appimage_filename) - command = ["gpg", "--yes", "--armor", "--detach-sig", {appimage_path}] - result = subprocess.call(*command) + command = ["gpg", "--yes", "--armor", "--detach-sig", appimage_path] + result = subprocess.call(command) if result != 0: raise RuntimeError(f"The GPG command returned non-zero: {result}")