mirror of
https://github.com/Ultimaker/Cura.git
synced 2025-07-08 07:27:29 -06:00
Apply fix for single extrusion machines when a new global stack is added
CURA-4713 Now the machines are not all loaded in the beginning, so the old way of adding extruder stacks for old single-extrusion machines don't work. With this fix, it now happens whenever a global stack is added to the registry.
This commit is contained in:
parent
57651e837f
commit
f26872ec1f
2 changed files with 23 additions and 3 deletions
|
@ -36,6 +36,11 @@ class CuraContainerRegistry(ContainerRegistry):
|
||||||
def __init__(self, *args, **kwargs):
|
def __init__(self, *args, **kwargs):
|
||||||
super().__init__(*args, **kwargs)
|
super().__init__(*args, **kwargs)
|
||||||
|
|
||||||
|
# We don't have all the machines loaded in the beginning, so in order to add the missing extruder stack
|
||||||
|
# for single extrusion machines, we subscribe to the containerAdded signal, and whenever a global stack
|
||||||
|
# is added, we check to see if an extruder stack needs to be added.
|
||||||
|
self.containerAdded.connect(self._onContainerAdded)
|
||||||
|
|
||||||
## Overridden from ContainerRegistry
|
## Overridden from ContainerRegistry
|
||||||
#
|
#
|
||||||
# Adds a container to the registry.
|
# Adds a container to the registry.
|
||||||
|
@ -410,6 +415,17 @@ class CuraContainerRegistry(ContainerRegistry):
|
||||||
if not extruder_stacks:
|
if not extruder_stacks:
|
||||||
self.addExtruderStackForSingleExtrusionMachine(machine, "fdmextruder")
|
self.addExtruderStackForSingleExtrusionMachine(machine, "fdmextruder")
|
||||||
|
|
||||||
|
def _onContainerAdded(self, container):
|
||||||
|
# We don't have all the machines loaded in the beginning, so in order to add the missing extruder stack
|
||||||
|
# for single extrusion machines, we subscribe to the containerAdded signal, and whenever a global stack
|
||||||
|
# is added, we check to see if an extruder stack needs to be added.
|
||||||
|
if not isinstance(container, ContainerStack) or container.getMetaDataEntry("type") != "machine":
|
||||||
|
return
|
||||||
|
|
||||||
|
extruder_stacks = self.findContainerStacks(type = "extruder_train", machine = container.getId())
|
||||||
|
if not extruder_stacks:
|
||||||
|
self.addExtruderStackForSingleExtrusionMachine(container, "fdmextruder")
|
||||||
|
|
||||||
def addExtruderStackForSingleExtrusionMachine(self, machine, extruder_id):
|
def addExtruderStackForSingleExtrusionMachine(self, machine, extruder_id):
|
||||||
new_extruder_id = extruder_id
|
new_extruder_id = extruder_id
|
||||||
|
|
||||||
|
@ -425,7 +441,6 @@ class CuraContainerRegistry(ContainerRegistry):
|
||||||
extruder_stack.setName(extruder_definition.getName())
|
extruder_stack.setName(extruder_definition.getName())
|
||||||
extruder_stack.setDefinition(extruder_definition)
|
extruder_stack.setDefinition(extruder_definition)
|
||||||
extruder_stack.addMetaDataEntry("position", extruder_definition.getMetaDataEntry("position"))
|
extruder_stack.addMetaDataEntry("position", extruder_definition.getMetaDataEntry("position"))
|
||||||
extruder_stack.setNextStack(machine)
|
|
||||||
|
|
||||||
# create empty user changes container otherwise
|
# create empty user changes container otherwise
|
||||||
user_container = InstanceContainer(extruder_stack.id + "_user")
|
user_container = InstanceContainer(extruder_stack.id + "_user")
|
||||||
|
@ -444,8 +459,8 @@ class CuraContainerRegistry(ContainerRegistry):
|
||||||
user_container.addInstance(machine.userChanges.getInstance(user_setting_key))
|
user_container.addInstance(machine.userChanges.getInstance(user_setting_key))
|
||||||
machine.userChanges.removeInstance(user_setting_key, postpone_emit = True)
|
machine.userChanges.removeInstance(user_setting_key, postpone_emit = True)
|
||||||
|
|
||||||
extruder_stack.setUserChanges(user_container)
|
|
||||||
self.addContainer(user_container)
|
self.addContainer(user_container)
|
||||||
|
extruder_stack.setUserChanges(user_container)
|
||||||
|
|
||||||
variant_id = "default"
|
variant_id = "default"
|
||||||
if machine.variant.getId() not in ("empty", "empty_variant"):
|
if machine.variant.getId() not in ("empty", "empty_variant"):
|
||||||
|
@ -491,6 +506,9 @@ class CuraContainerRegistry(ContainerRegistry):
|
||||||
|
|
||||||
self.addContainer(extruder_stack)
|
self.addContainer(extruder_stack)
|
||||||
|
|
||||||
|
# Set next stack at the end
|
||||||
|
extruder_stack.setNextStack(machine)
|
||||||
|
|
||||||
return extruder_stack
|
return extruder_stack
|
||||||
|
|
||||||
def _findQualityChangesContainerInCuraFolder(self, name):
|
def _findQualityChangesContainerInCuraFolder(self, name):
|
||||||
|
|
|
@ -369,7 +369,9 @@ class MachineManager(QObject):
|
||||||
self.blurSettings.emit() # Ensure no-one has focus.
|
self.blurSettings.emit() # Ensure no-one has focus.
|
||||||
self._cancelDelayedActiveContainerStackChanges()
|
self._cancelDelayedActiveContainerStackChanges()
|
||||||
|
|
||||||
containers = ContainerRegistry.getInstance().findContainerStacks(id = stack_id)
|
container_registry = ContainerRegistry.getInstance()
|
||||||
|
|
||||||
|
containers = container_registry.findContainerStacks(id = stack_id)
|
||||||
if containers:
|
if containers:
|
||||||
Application.getInstance().setGlobalContainerStack(containers[0])
|
Application.getInstance().setGlobalContainerStack(containers[0])
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue