From f0002e265ba4bc753d6d26fbca3be4bc216061af Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Thu, 18 Jun 2020 17:39:58 +0200 Subject: [PATCH] Mark recently constructed stacks as not dirty The stacks would get marked dirty for setting some metadata, but since thats part of their construction, they aren't really dirty. Previously, every single stack that was loaded would be marked as dirty, which causes unneeded saving. --- cura/Settings/CuraContainerStack.py | 2 ++ cura/Settings/ExtruderStack.py | 2 ++ cura/Settings/GlobalStack.py | 2 ++ 3 files changed, 6 insertions(+) diff --git a/cura/Settings/CuraContainerStack.py b/cura/Settings/CuraContainerStack.py index 36548ed5de..4595bf3996 100755 --- a/cura/Settings/CuraContainerStack.py +++ b/cura/Settings/CuraContainerStack.py @@ -60,6 +60,8 @@ class CuraContainerStack(ContainerStack): import cura.CuraApplication #Here to prevent circular imports. self.setMetaDataEntry("setting_version", cura.CuraApplication.CuraApplication.SettingVersion) + self.setDirty(False) + # This is emitted whenever the containersChanged signal from the ContainerStack base class is emitted. pyqtContainersChanged = pyqtSignal() diff --git a/cura/Settings/ExtruderStack.py b/cura/Settings/ExtruderStack.py index 7520d436e9..bb35b336c7 100644 --- a/cura/Settings/ExtruderStack.py +++ b/cura/Settings/ExtruderStack.py @@ -32,6 +32,8 @@ class ExtruderStack(CuraContainerStack): self.propertiesChanged.connect(self._onPropertiesChanged) + self.setDirty(False) + enabledChanged = pyqtSignal() @override(ContainerStack) diff --git a/cura/Settings/GlobalStack.py b/cura/Settings/GlobalStack.py index 929c567921..a9164d0fb9 100755 --- a/cura/Settings/GlobalStack.py +++ b/cura/Settings/GlobalStack.py @@ -55,6 +55,8 @@ class GlobalStack(CuraContainerStack): # properties. So we need to tie them together like this. self.metaDataChanged.connect(self.configuredConnectionTypesChanged) + self.setDirty(False) + extrudersChanged = pyqtSignal() configuredConnectionTypesChanged = pyqtSignal()