3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-24 15:13:56 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Add more logging to AuthorizationRequestHandler

Browse source 
I don't know why this wasn't there yet. We only had user messages,
which makes it hard to debug this
This commit is contained in:
Jaime van Kessel 2023-04-24 13:18:51 +02:00
parent 6a704f4802
commit ed968f85b8
No known key found for this signature in database
GPG key ID: C85F7A3AF1BAA7C4
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
cura/OAuth2/AuthorizationRequestHandler.py
View file

@ -6,6 +6,7 @@ from threading import Lock # To turn an asynchronous call synchronous.
from typing import Optional, Callable, Tuple, Dict, Any, List, TYPE_CHECKING
from urllib.parse import parse_qs, urlparse
from UM.Logger import Logger
from cura.OAuth2.Models import AuthenticationResponse, ResponseData, HTTP_STATUS
from UM.i18n import i18nCatalog
@ -70,11 +71,13 @@ class AuthorizationRequestHandler(BaseHTTPRequestHandler):
code = self._queryGet(query, "code")
state = self._queryGet(query, "state")
if state != self.state:
Logger.log("w", f"The provided state was not correct. Got {state} and expected {self.state}")
token_response = AuthenticationResponse(
success = False,
err_message = catalog.i18nc("@message", "The provided state is not correct.")
)
elif code and self.authorization_helpers is not None and self.verification_code is not None:
Logger.log("d", "Timeout when authenticating with the account server.")
token_response = AuthenticationResponse(
success = False,
err_message = catalog.i18nc("@message", "Timeout when authenticating with the account server.")
@ -92,6 +95,7 @@ class AuthorizationRequestHandler(BaseHTTPRequestHandler):
elif self._queryGet(query, "error_code") == "user_denied":
# Otherwise we show an error message (probably the user clicked "Deny" in the auth dialog).
Logger.log("d", "User did not give the required permission when authorizing this application")
token_response = AuthenticationResponse(
success = False,
err_message = catalog.i18nc("@message", "Please give the required permissions when authorizing this application.")
@ -99,6 +103,7 @@ class AuthorizationRequestHandler(BaseHTTPRequestHandler):
else:
# We don't know what went wrong here, so instruct the user to check the logs.
Logger.log("w", f"Unexpected error when logging in. Error_code: {self._queryGet(query, 'error_code')}, State: {state}")
token_response = AuthenticationResponse(
success = False,
error_message = catalog.i18nc("@message", "Something unexpected happened when trying to log in, please try again.")