3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-23 14:44:13 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix success code in MyPy script

Browse source 
The 'return' variable was used for two things, shadowing each other. Because of that, it would fill the variable with a subprocess.run result which would evaluate to True so it would always say that the test failed.
This commit is contained in:
Ghostkeeper 2019-09-17 09:35:12 +02:00
parent 0085660153
commit e4edd5732f
No known key found for this signature in database
GPG key ID: 86BEF881AE2CF276
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
run_mypy.py
View file

@ -61,7 +61,7 @@ def main():
plugins.sort() plugins.sort()
mods = ["cura"] + plugins + findModules("plugins/VersionUpgrade") mods = ["cura"] + plugins + findModules("plugins/VersionUpgrade")
result = 0 success_code = 0
for mod in mods: for mod in mods:
print("------------- Checking module {mod}".format(**locals())) print("------------- Checking module {mod}".format(**locals()))
if sys.platform == "win32": if sys.platform == "win32":
@ -70,10 +70,10 @@ def main():
result = subprocess.run([sys.executable, mypy_module, "-p", mod, "--ignore-missing-imports"]) result = subprocess.run([sys.executable, mypy_module, "-p", mod, "--ignore-missing-imports"])
if result.returncode != 0: if result.returncode != 0:
print("\nModule {mod} failed checking. :(".format(**locals())) print("\nModule {mod} failed checking. :(".format(**locals()))
result = 1 success_code = 1
else: else:
print("\n\nDone checking. All is good.") print("\n\nDone checking. All is good.")
return result return success_code
if __name__ == "__main__": if __name__ == "__main__":