Express getConfigurationTypeFromSerialized as function of its parent

This prevents code duplication a bit and allows us to make it a classmethod.

Contributes to issue CURA-4243.
This commit is contained in:
Ghostkeeper 2017-11-01 16:17:26 +01:00
parent 07947d5d2c
commit e48b151d40
No known key found for this signature in database
GPG key ID: 5252B696FB5E7C7A

View file

@ -43,15 +43,11 @@ class GlobalStack(CuraContainerStack):
def getLoadingPriority(cls) -> int:
return 2
def getConfigurationTypeFromSerialized(self, serialized: str) -> Optional[str]:
configuration_type = None
try:
parser = self._readAndValidateSerialized(serialized)
configuration_type = parser["metadata"].get("type")
if configuration_type == "machine":
configuration_type = "machine_stack"
except Exception as e:
Logger.log("e", "Could not get configuration type: %s", e)
@classmethod
def getConfigurationTypeFromSerialized(cls, serialized: str) -> Optional[str]:
configuration_type = super().getConfigurationTypeFromSerialized(serialized)
if configuration_type == "machine":
return "machine_stack"
return configuration_type
## Add an extruder to the list of extruders of this stack.