From 47ef9d623e645769b6cc3a3694108260ba41024d Mon Sep 17 00:00:00 2001 From: Remco Burema Date: Thu, 23 Mar 2023 16:21:59 +0100 Subject: [PATCH 1/2] Pause at height was not working for UM printers. Hold-stepper-motor (and maybe beep) options, newly introduced previously, _and on by default_ (even though it was clear they where not meant for Griffin flavour GCode -- because at least the hold-motor option was not even visible for Griffin) where causing UltiMaker printers with prints that had the pause-at-height script enabled to fail. should fix internal ticket CURA-10451 --- plugins/PostProcessingPlugin/scripts/PauseAtHeight.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/PostProcessingPlugin/scripts/PauseAtHeight.py b/plugins/PostProcessingPlugin/scripts/PauseAtHeight.py index 7f8d1d118a..16eae77fbc 100644 --- a/plugins/PostProcessingPlugin/scripts/PauseAtHeight.py +++ b/plugins/PostProcessingPlugin/scripts/PauseAtHeight.py @@ -67,7 +67,7 @@ class PauseAtHeight(Script): "label": "Keep motors engaged", "description": "Keep the steppers engaged to allow change of filament without moving the head. Applying too much force will move the head/bed anyway", "type": "bool", - "default_value": true, + "default_value": false, "enabled": "pause_method != \\\"griffin\\\"" }, "disarm_timeout": @@ -218,7 +218,7 @@ class PauseAtHeight(Script): "label": "Beep at pause", "description": "Make a beep when pausing", "type": "bool", - "default_value": true + "default_value": false }, "beep_length": { From a5fbb21fa78ac92dfe9286ba289735996801c404 Mon Sep 17 00:00:00 2001 From: Remco Burema Date: Fri, 24 Mar 2023 20:12:35 +0100 Subject: [PATCH 2/2] Disable hold-steppers option completely for Griffin-flavour. Users could still set the option first, _then_ switch to Griffin, giving the same problems before the default was switched to false (since the setting is disabled for Griffin flavour anyway). part of CURA-10451 --- plugins/PostProcessingPlugin/scripts/PauseAtHeight.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/plugins/PostProcessingPlugin/scripts/PauseAtHeight.py b/plugins/PostProcessingPlugin/scripts/PauseAtHeight.py index 16eae77fbc..18452f6446 100644 --- a/plugins/PostProcessingPlugin/scripts/PauseAtHeight.py +++ b/plugins/PostProcessingPlugin/scripts/PauseAtHeight.py @@ -478,10 +478,11 @@ class PauseAtHeight(Script): prepend_gcode += "M117 " + display_text + "\n" # Set the disarm timeout - if hold_steppers_on: - prepend_gcode += self.putValue(M = 84, S = 3600) + " ; Keep steppers engaged for 1h\n" - elif disarm_timeout > 0: - prepend_gcode += self.putValue(M = 84, S = disarm_timeout) + " ; Set the disarm timeout\n" + if pause_method != "griffin": + if hold_steppers_on: + prepend_gcode += self.putValue(M = 84, S = 3600) + " ; Keep steppers engaged for 1h\n" + elif disarm_timeout > 0: + prepend_gcode += self.putValue(M = 84, S = disarm_timeout) + " ; Set the disarm timeout\n" # Beep at pause if beep_at_pause: