From 9dd61ba094e15491d17189bd2f3602be0795cf4f Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Thu, 2 Feb 2017 10:44:25 +0000 Subject: [PATCH 1/4] Added combing_retract_before_outer_wall setting. This boolean setting controls whether travel moves to the first point in an outer wall will always involve a retraction. IMHO, forcing a retraction has two benefits: 1 - avoids taking the ooze that would occur during the travel to the outer surface. 2 - the slight pause when un-retracting could help reduce any ripples introduced by the rapid movement hot-end movement. --- resources/definitions/fdmprinter.def.json | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index b19c97b793..1a1eea4227 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -2418,6 +2418,16 @@ "settable_per_mesh": false, "settable_per_extruder": false }, + "combing_retract_before_outer_wall": + { + "label": "Retract Before Outer Wall", + "description": "When combing is enabled, always retract when moving to start an outer wall.", + "type": "bool", + "default_value": false, + "enabled": "resolveOrValue('retraction_combing') != 'off'", + "settable_per_mesh": false, + "settable_per_extruder": true + }, "travel_avoid_other_parts": { "label": "Avoid Printed Parts When Traveling", From d5ea0f0bc2b7ea9f89344fa0861f467f94429d29 Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Thu, 2 Feb 2017 11:18:52 +0000 Subject: [PATCH 2/4] Don't let combing_retract_before_outer_wall be settable per extruder. Combing mode isn't, so why should this be? --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 1a1eea4227..8c2d0cc1e3 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -2426,7 +2426,7 @@ "default_value": false, "enabled": "resolveOrValue('retraction_combing') != 'off'", "settable_per_mesh": false, - "settable_per_extruder": true + "settable_per_extruder": false }, "travel_avoid_other_parts": { From aca2faa6968b994b55a03aa245064d14c18c3e4f Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Mon, 6 Mar 2017 12:56:27 +0100 Subject: [PATCH 3/4] fix: combing_retract_before_outer_wall always causes retraction now (CURA-3438) --- resources/definitions/fdmprinter.def.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 72f165a93d..4457ecfda4 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -2423,10 +2423,10 @@ "combing_retract_before_outer_wall": { "label": "Retract Before Outer Wall", - "description": "When combing is enabled, always retract when moving to start an outer wall.", + "description": "Always retract when moving to start an outer wall.", "type": "bool", "default_value": false, - "enabled": "resolveOrValue('retraction_combing') != 'off'", + "enabled": "retraction_enable", "settable_per_mesh": false, "settable_per_extruder": false }, From 5a7812b4b7c3fb21decde4105629b2980dc18586 Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Wed, 8 Mar 2017 09:30:58 +0000 Subject: [PATCH 4/4] Rename combing_retract_before_outer_wall setting to travel_retract_before_outer_wall. The forced retraction can now occur irrespective of whether combing is in use or not. --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index d808984117..017b4deb8e 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -2520,7 +2520,7 @@ "settable_per_mesh": false, "settable_per_extruder": false }, - "combing_retract_before_outer_wall": + "travel_retract_before_outer_wall": { "label": "Retract Before Outer Wall", "description": "Always retract when moving to start an outer wall.",