From e182459dba736d7637dddbbc260a9f15f551e9b6 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Tue, 2 Jul 2019 15:16:41 +0200 Subject: [PATCH] Fix the updating of material diameter. This was a weeeird bug. It worked if you changed the value and selected another field. Pressing enter however (aka; The behavior that 80%+ of the users have) would change it but it would switch back in half a second. It seems to have been caused by mutliple onEditingFinished signals being emitted in sequence. As I can't be bothered to go through the bowels of QML and figure out why exactly this is doing what it's doing, I just tied the enter to losing the focus, which ensures that the right behavior happens (Field is no longer selected, and the onEditingFinished is emitted) Contributes to CURA-6590 --- resources/qml/Preferences/ReadOnlySpinBox.qml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/qml/Preferences/ReadOnlySpinBox.qml b/resources/qml/Preferences/ReadOnlySpinBox.qml index 1bbef82b1e..11e47b38b2 100644 --- a/resources/qml/Preferences/ReadOnlySpinBox.qml +++ b/resources/qml/Preferences/ReadOnlySpinBox.qml @@ -34,8 +34,8 @@ Item anchors.fill: parent onEditingFinished: base.editingFinished() - Keys.onEnterPressed: base.editingFinished() - Keys.onReturnPressed: base.editingFinished() + Keys.onEnterPressed: spinBox.focus = false + Keys.onReturnPressed: spinBox.focus = false } Label