From dcac9b6a876656ccdc01718f95f319a69ecbfc3b Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Wed, 29 Apr 2020 13:52:29 +0200 Subject: [PATCH] Prevent a crash when retrying even though it completed in the meanwhile Fixes Sentry issue CURA-NA. --- plugins/UM3NetworkPrinting/src/Cloud/ToolPathUploader.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plugins/UM3NetworkPrinting/src/Cloud/ToolPathUploader.py b/plugins/UM3NetworkPrinting/src/Cloud/ToolPathUploader.py index d5de7fe10a..6aa341c0e5 100644 --- a/plugins/UM3NetworkPrinting/src/Cloud/ToolPathUploader.py +++ b/plugins/UM3NetworkPrinting/src/Cloud/ToolPathUploader.py @@ -125,7 +125,10 @@ class ToolPathUploader: if self._retries < self.MAX_RETRIES and status_code in self.RETRY_HTTP_CODES: self._retries += 1 Logger.log("i", "Retrying %s/%s request %s", self._retries, self.MAX_RETRIES, reply.url().toString()) - self._uploadChunk() + try: + self._uploadChunk() + except ValueError: # Asynchronously it could have completed in the meanwhile. + pass return # Http codes that are not to be retried are assumed to be errors.