From dc52e939e9fa3d8d82aa9aed0c4b51d9edcfe8b9 Mon Sep 17 00:00:00 2001 From: Lipu Fei Date: Wed, 25 Apr 2018 17:55:17 +0200 Subject: [PATCH] Fix unit tests for adding CuraContainerStacks CURA-5281 Because of the definition_changes fix, CuraContainerStack.deserialize() may create and add extra containers, so the unit tests need to be adjusted. --- tests/Settings/TestCuraContainerRegistry.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/Settings/TestCuraContainerRegistry.py b/tests/Settings/TestCuraContainerRegistry.py index 9e5692b565..b97f6b4faf 100644 --- a/tests/Settings/TestCuraContainerRegistry.py +++ b/tests/Settings/TestCuraContainerRegistry.py @@ -76,9 +76,9 @@ def test_addContainerExtruderStack(container_registry, definition_container): with unittest.mock.patch("UM.Settings.ContainerRegistry.ContainerRegistry.addContainer", mock_super_add_container): container_registry.addContainer(container_stack) - assert len(mock_super_add_container.call_args_list) == 1 #Called only once. - assert len(mock_super_add_container.call_args_list[0][0]) == 1 #Called with one parameter. - assert type(mock_super_add_container.call_args_list[0][0][0]) == ExtruderStack + assert len(mock_super_add_container.call_args_list) == 2 #Called only once. + assert len(mock_super_add_container.call_args_list[1][0]) == 1 #Called with one parameter. + assert type(mock_super_add_container.call_args_list[1][0][0]) == ExtruderStack ## Tests whether addContainer properly converts to GlobalStack. def test_addContainerGlobalStack(container_registry, definition_container): @@ -92,9 +92,9 @@ def test_addContainerGlobalStack(container_registry, definition_container): with unittest.mock.patch("UM.Settings.ContainerRegistry.ContainerRegistry.addContainer", mock_super_add_container): container_registry.addContainer(container_stack) - assert len(mock_super_add_container.call_args_list) == 1 #Called only once. - assert len(mock_super_add_container.call_args_list[0][0]) == 1 #Called with one parameter. - assert type(mock_super_add_container.call_args_list[0][0][0]) == GlobalStack + assert len(mock_super_add_container.call_args_list) == 2 #Called only once. + assert len(mock_super_add_container.call_args_list[1][0]) == 1 #Called with one parameter. + assert type(mock_super_add_container.call_args_list[1][0][0]) == GlobalStack def test_addContainerGoodSettingVersion(container_registry, definition_container): from cura.CuraApplication import CuraApplication