3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Correct and consistent spelling of g-code

Browse source 
This spelling is in Ultimaker's style guide.
We use g-code, and capitalise the G if it's at the start of a sentence or header.
Pretty good score, considering there are literally thousands of user- or log-visible strings mentioning g-code across Cura.
This commit is contained in:
Ghostkeeper 2020-07-20 13:36:49 +02:00
parent e6c305de40
commit db15bc84cf
No known key found for this signature in database
GPG key ID: D2A8871EE34EC59A
8 changed files with 24 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

10
plugins/GCodeReader/FlavorParser.py
View file

@ -312,7 +312,7 @@ class FlavorParser:
# F5, that gcode SceneNode will be removed because it doesn't have a file to be reloaded from.
#
def processGCodeStream(self, stream: str, filename: str) -> Optional["CuraSceneNode"]:
Logger.log("d", "Preparing to load GCode")
Logger.log("d", "Preparing to load g-code")
self._cancelled = False
# We obtain the filament diameter from the selected extruder to calculate line widths
global_stack = CuraApplication.getInstance().getGlobalContainerStack()
@ -352,7 +352,7 @@ class FlavorParser:
self._message.setProgress(0)
self._message.show()
Logger.log("d", "Parsing Gcode...")
Logger.log("d", "Parsing g-code...")
current_position = Position(0, 0, 0, 0, [0])
current_path = [] #type: List[List[float]]
@ -363,7 +363,7 @@ class FlavorParser:
for line in stream.split("\n"):
if self._cancelled:
Logger.log("d", "Parsing Gcode file cancelled")
Logger.log("d", "Parsing g-code file cancelled.")
return None
current_line += 1
@ -482,7 +482,7 @@ class FlavorParser:
gcode_dict = {active_build_plate_id: gcode_list}
CuraApplication.getInstance().getController().getScene().gcode_dict = gcode_dict #type: ignore #Because gcode_dict is generated dynamically.
Logger.log("d", "Finished parsing Gcode")
Logger.log("d", "Finished parsing g-code.")
self._message.hide()
if self._layer_number == 0:
@ -493,7 +493,7 @@ class FlavorParser:
machine_depth = global_stack.getProperty("machine_depth", "value")
scene_node.setPosition(Vector(-machine_width / 2, 0, machine_depth / 2))
Logger.log("d", "GCode loading finished")
Logger.log("d", "G-code loading finished.")
if CuraApplication.getInstance().getPreferences().getValue("gcodereader/show_caution"):
caution_message = Message(catalog.i18nc(

4
plugins/GCodeReader/GCodeReader.py
View file

@ -1,5 +1,5 @@
# Copyright (c) 2017 Aleph Objects, Inc.
# Copyright (c) 2018 Ultimaker B.V.
# Copyright (c) 2020 Ultimaker B.V.
# Cura is released under the terms of the LGPLv3 or higher.
from typing import Optional, Union, List, TYPE_CHECKING
@ -32,7 +32,7 @@ class GCodeReader(MeshReader):
MimeTypeDatabase.addMimeType(
MimeType(
name = "application/x-cura-gcode-file",
comment = "Cura GCode File",
comment = "Cura G-code File",
suffixes = ["gcode"]
)
)