3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fixed returning an error after the package is destroyed

Browse source 
Defensive programming

Contributes to: CURA-8587
This commit is contained in:
Jelle Spijker 2021-12-08 10:59:28 +01:00
parent 7be2da587b
commit db09954ac8
No known key found for this signature in database
GPG key ID: 6662DC033BE6B99A
1 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
plugins/Marketplace/PackageList.py
View file

@ -237,11 +237,17 @@ class PackageList(ListModel):
if reply:
reply_string = bytes(reply.readAll()).decode()
Logger.error(f"Failed to download package: {package_id} due to {reply_string}")
package = self.getPackageModel(package_id)
if update:
package.is_updating = ManageState.FAILED
else:
package.is_installing = ManageState.FAILED
try:
package = self.getPackageModel(package_id)
if update:
package.is_updating = ManageState.FAILED
else:
package.is_installing = ManageState.FAILED
except RuntimeError:
# Setting the ownership of this object to not qml can still result in a RuntimeError. Which can occur when quickly toggling
# between de-/constructing Remote or Local PackageLists. This try-except is here to prevent a hard crash when the wrapped C++ object
# was deleted when it was still parsing the response
return
def subscribeUserToPackage(self, package_id: str, sdk_version: str) -> None:
"""Subscribe the user (if logged in) to the package for a given SDK