From d97dddcfe2db72e9397a3ab2b3e078e4e7cba001 Mon Sep 17 00:00:00 2001 From: "c.lamboo" Date: Tue, 13 Sep 2022 10:41:46 +0200 Subject: [PATCH] Revert "More agressivly check online printers" This reverts commit 92b371cd508ebf5102aa5ae979865d2bac591b7e. --- cura/Settings/MachineManager.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cura/Settings/MachineManager.py b/cura/Settings/MachineManager.py index 699942ebaf..2051ce1b99 100755 --- a/cura/Settings/MachineManager.py +++ b/cura/Settings/MachineManager.py @@ -205,7 +205,11 @@ class MachineManager(QObject): ConnectionType.NetworkConnection in machine.configuredConnectionTypes, machines) if online_only: - machines = filter(lambda machine: parseBool(machine.getMetaDataEntry("is_online", False)), machines) + # LAN printers can have is_online = False but should still be included, + # their online status is only checked when they are the active printer. + machines = filter(lambda machine: parseBool(machine.getMetaDataEntry("is_online", False) or + ConnectionType.NetworkConnection in machine.configuredConnectionTypes), + machines) return list(machines)