3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-25 07:33:57 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Add test for getCurrentQualityGroups

Browse source 
The test succeeded but in writing it I discovered a bug. I'll fix that soon.

Contributes to issue CURA-6600.
This commit is contained in:
Ghostkeeper 2019-09-06 17:06:32 +02:00
parent 71b94f6d5b
commit d618f2df71
No known key found for this signature in database
GPG key ID: 86BEF881AE2CF276
1 changed files with 36 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

42
tests/Machines/TestContainerTree.py
View file

@ -10,15 +10,30 @@ import cura.CuraApplication # DEBUG!
def createMockedStack(definition_id: str): def createMockedStack(definition_id: str):
result = MagicMock(spec = GlobalStack) result = MagicMock(spec = GlobalStack)
result.definition.getId = MagicMock(return_value = definition_id) result.definition.getId = MagicMock(return_value = definition_id)
extruder_left_mock = MagicMock()
extruder_left_mock.variant.getName = MagicMock(return_value = definition_id + "_left_variant_name")
extruder_left_mock.material.getMetaDataEntry = MagicMock(return_value = definition_id + "_left_material_base_file")
extruder_left_mock.isEnabled = True
extruder_right_mock = MagicMock()
extruder_right_mock.variant.getName = MagicMock(return_value = definition_id + "_right_variant_name")
extruder_right_mock.material.getMetaDataEntry = MagicMock(return_value = definition_id + "_right_material_base_file")
extruder_right_mock.isEnabled = True
extruder_dict = {"1": extruder_right_mock, "0": extruder_left_mock}
result.extruders = extruder_dict
return result return result
@pytest.fixture @pytest.fixture
def container_registry(): def container_registry():
result = MagicMock() result = MagicMock()
result.findContainerStacks = MagicMock(return_value=[createMockedStack("machine_1"), createMockedStack("machine_2")]) result.findContainerStacks = MagicMock(return_value = [createMockedStack("machine_1"), createMockedStack("machine_2")])
return result return result
@pytest.fixture
def application():
return MagicMock(getGlobalContainerStack = MagicMock(return_value = createMockedStack("current_global_stack")))
def test_containerTreeInit(container_registry): def test_containerTreeInit(container_registry):
with patch("UM.Settings.ContainerRegistry.ContainerRegistry.getInstance", MagicMock(return_value=container_registry)): with patch("UM.Settings.ContainerRegistry.ContainerRegistry.getInstance", MagicMock(return_value=container_registry)):
@ -32,7 +47,7 @@ def test_newMachineAdded(container_registry):
mocked_definition_container = MagicMock(spec=DefinitionContainer) mocked_definition_container = MagicMock(spec=DefinitionContainer)
mocked_definition_container.getId = MagicMock(return_value = "machine_3") mocked_definition_container.getId = MagicMock(return_value = "machine_3")
with patch("UM.Settings.ContainerRegistry.ContainerRegistry.getInstance", MagicMock(return_value=container_registry)): with patch("UM.Settings.ContainerRegistry.ContainerRegistry.getInstance", MagicMock(return_value = container_registry)):
container_tree = ContainerTree() container_tree = ContainerTree()
# machine_3 shouldn't be there, as on init it wasn't in the registry # machine_3 shouldn't be there, as on init it wasn't in the registry
assert "machine_3" not in container_tree.machines assert "machine_3" not in container_tree.machines
@ -46,10 +61,10 @@ def test_newMachineAdded(container_registry):
def test_alreadyKnownMachineAdded(container_registry): def test_alreadyKnownMachineAdded(container_registry):
mocked_definition_container = MagicMock(spec=DefinitionContainer) mocked_definition_container = MagicMock(spec = DefinitionContainer)
mocked_definition_container.getId = MagicMock(return_value="machine_2") mocked_definition_container.getId = MagicMock(return_value = "machine_2")
with patch("UM.Settings.ContainerRegistry.ContainerRegistry.getInstance", MagicMock(return_value=container_registry)): with patch("UM.Settings.ContainerRegistry.ContainerRegistry.getInstance", MagicMock(return_value = container_registry)):
container_tree = ContainerTree() container_tree = ContainerTree()
assert len(container_tree.machines) == 2 assert len(container_tree.machines) == 2
@ -63,4 +78,19 @@ def test_getCurrentQualityGroupsNoGlobalStack(container_registry):
container_tree = ContainerTree() container_tree = ContainerTree()
result = container_tree.getCurrentQualityGroups() result = container_tree.getCurrentQualityGroups()
assert len(result) == 0 assert len(result) == 0
def test_getCurrentQualityGroups(container_registry, application):
with patch("UM.Settings.ContainerRegistry.ContainerRegistry.getInstance", MagicMock(return_value = container_registry)):
container_tree = ContainerTree()
container_tree.machines["current_global_stack"] = MagicMock() # Mock so that we can track whether the getQualityGroups function gets called with correct parameters.
with patch("cura.CuraApplication.CuraApplication.getInstance", MagicMock(return_value = application)):
result = container_tree.getCurrentQualityGroups()
# As defined in the fixture for application.
expected_variant_names = ["current_global_stack_left_variant_name", "current_global_stack_right_variant_name"]
expected_material_base_files = ["current_global_stack_left_material_base_file", "current_global_stack_right_material_base_file"]
expected_is_enabled = [True, True]
container_tree.machines["current_global_stack"].getQualityGroups.assert_called_with(expected_variant_names, expected_material_base_files, expected_is_enabled)