3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-11-02 20:52:20 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Dialog was immediately being destroyed because a reference to it was not being stored in memory. Added a missingPackageDialog variable to WorkspaceDialog to fix this.

Browse source 
Swapped the loading order of Marketplace extensions so SyncOrchestractor is not fetched by PluginRegistry.getInstance().getPluginObject("Marketplace") in WorkspaceDialog.

CURA-8610
This commit is contained in:
j.delarago 2022-06-08 12:19:36 +02:00
parent 25250a8205
commit d5511a078c
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
plugins/Marketplace/Marketplace.py
View file

@ -41,6 +41,7 @@ class Marketplace(Extension, QObject):
self._tab_shown: int = 0 self._tab_shown: int = 0
self._restart_needed = False self._restart_needed = False
self.missingPackageDialog = None
def getTabShown(self) -> int: def getTabShown(self) -> int:
return self._tab_shown return self._tab_shown
@ -128,5 +129,5 @@ class Marketplace(Extension, QObject):
:param ignore_warning_callback: A callback that gets executed when the user ignores the pop-up, to show them a :param ignore_warning_callback: A callback that gets executed when the user ignores the pop-up, to show them a
warning. warning.
""" """
dialog = InstallMissingPackageDialog(packages_metadata, ignore_warning_callback) self.missingPackageDialog = InstallMissingPackageDialog(packages_metadata, ignore_warning_callback)
dialog.show() self.missingPackageDialog.show()

2
plugins/Marketplace/__init__.py
View file

@ -14,4 +14,4 @@ def register(app):
""" """
Register the plug-in object with Uranium. Register the plug-in object with Uranium.
""" """
return { "extension": [Marketplace(), SyncOrchestrator(app)] } return { "extension": [SyncOrchestrator(app), Marketplace()] }