From d1301d16a92dcb8e952152ff319acc217b729fb7 Mon Sep 17 00:00:00 2001 From: Lipu Fei Date: Wed, 12 Sep 2018 16:56:04 +0200 Subject: [PATCH] Skip the do-not-handle URLs instead of returning CURA-5718 The request-url dict is not ordered so you cannot garuantee the ordering when you use .items(). This can cause a problem that if a do-not-handle item occurs first then nothing will be handled at all. --- plugins/Toolbox/src/Toolbox.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/Toolbox/src/Toolbox.py b/plugins/Toolbox/src/Toolbox.py index cc9f8ac354..9488b50e4e 100644 --- a/plugins/Toolbox/src/Toolbox.py +++ b/plugins/Toolbox/src/Toolbox.py @@ -626,7 +626,7 @@ class Toolbox(QObject, Extension): # HACK: Do nothing because we'll handle these from the "packages" call if type in do_not_handle: - return + continue if reply.url() == url: if reply.attribute(QNetworkRequest.HttpStatusCodeAttribute) == 200: